[Bug target/32219] optimizer causes wrong code in pic/hidden/weak symbol checking.

[Bug target/32219] optimizer causes wrong code in pic/hidden/weak symbol checking.

[aldot at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32219

--- Comment #13 from Bernhard Reutner-Fischer <aldot at gcc dot gnu.org> 2012-06-28 22:49:52 UTC ---
Created attachment 27716
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27716
testcase

This was (accidentally) fixed on for at least 4.7 ff but without adding a
testcase like the attached.

[Bug target/32219] optimizer causes wrong code in pic/hidden/weak symbol checking.

[mikpe at it dot uu.se]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32219

Mikael Pettersson <mikpe at it dot uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikpe at it dot uu.se

--- Comment #14 from Mikael Pettersson <mikpe at it dot uu.se> 2012-09-01 15:17:28 UTC ---
(In reply to comment #13)
> This was (accidentally) fixed on for at least 4.7 ff but without adding a
> testcase like the attached.

Are you sure it's been fixed? The test case segfaults for me on x86_64-linux
when compiled by 4.8-20120826, 4.7-20120825, or 4.6-20120810, with -O1 -m32 and
-fPIC or -fPIE. Without -m32 it doesn't segfault.

[Bug rtl-optimization/32219] optimizer causes wrong code in pic/hidden/weak symbol checking.

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=32219

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|target                      |rtl-optimization

--- Comment #15 from H.J. Lu <hjl.tools at gmail dot com> ---
A patch is posted at

https://gcc.gnu.org/ml/gcc-patches/2015-02/msg00410.html

[Bug rtl-optimization/32219] optimizer causes wrong code in pic/hidden/weak symbol checking.

[rth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=32219

--- Comment #16 from Richard Henderson <rth at gcc dot gnu.org> ---
Author: rth
Date: Fri Feb 13 04:52:45 2015
New Revision: 220674

URL: https://gcc.gnu.org/viewcvs?rev=220674&root=gcc&view=rev
Log:
PR rtl/32219

gcc/
    * cgraphunit.c (cgraph_node::finalize_function): Set definition
    before notice_global_symbol.
    (varpool_node::finalize_decl): Likewise.
    * varasm.c (default_binds_local_p_2): Rename from
    default_binds_local_p_1, add weak_dominate argument.  Use direct
    returns instead of assigning to local variable.  Unify varpool and
    cgraph paths via symtab_node.  Reject undef weak variables before
    testing visibility.  Reorder tests for simplicity.
    (default_binds_local_p): Use default_binds_local_p_2.
    (default_binds_local_p_1): Likewise.
    (decl_binds_to_current_def_p): Unify varpool and cgraph paths
    via symtab_node.
    (default_elf_asm_output_external): Emit visibility when specified.
gcc/testsuite/
    * gcc.dg/visibility-22.c: New test.
    * gcc.dg/visibility-23.c: New test.
    * gcc.target/i386/pr32219-1.c: New test.
    * gcc.target/i386/pr32219-2.c: New test.
    * gcc.target/i386/pr32219-3.c: New test.
    * gcc.target/i386/pr32219-4.c: New test.
    * gcc.target/i386/pr32219-5.c: New test.
    * gcc.target/i386/pr32219-6.c: New test.
    * gcc.target/i386/pr32219-7.c: New test.
    * gcc.target/i386/pr32219-8.c: New test.
    * gcc.target/i386/pr64317.c: Expect GOTOFF, not GOT.

Added:
    trunk/gcc/testsuite/gcc.dg/visibility-22.c
    trunk/gcc/testsuite/gcc.dg/visibility-23.c
    trunk/gcc/testsuite/gcc.target/i386/pr32219-1.c
    trunk/gcc/testsuite/gcc.target/i386/pr32219-2.c
    trunk/gcc/testsuite/gcc.target/i386/pr32219-3.c
    trunk/gcc/testsuite/gcc.target/i386/pr32219-4.c
    trunk/gcc/testsuite/gcc.target/i386/pr32219-5.c
    trunk/gcc/testsuite/gcc.target/i386/pr32219-6.c
    trunk/gcc/testsuite/gcc.target/i386/pr32219-7.c
    trunk/gcc/testsuite/gcc.target/i386/pr32219-8.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cgraphunit.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.target/i386/pr64317.c
    trunk/gcc/varasm.c

[Bug rtl-optimization/32219] optimizer causes wrong code in pic/hidden/weak symbol checking.

[rth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=32219

Richard Henderson <rth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |rth at gcc dot gnu.org
         Resolution|---                         |FIXED

--- Comment #17 from Richard Henderson <rth at gcc dot gnu.org> ---
Fixed.  Thanks for the work on this one, HJ.

[Bug rtl-optimization/32219] optimizer causes wrong code in pic/hidden/weak symbol checking.

[pthaugen at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=32219

Pat Haugen <pthaugen at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pthaugen at gcc dot gnu.org

--- Comment #18 from Pat Haugen <pthaugen at gcc dot gnu.org> ---
The following error started with r220674 on powerpc64-linux when trying to
build 447.dealII from CPU2006 with -m64.

/usr/bin/ld: exceptions.o: In function `ExceptionBase::what() const':
exceptions.cc:(.text+0xda0): unresolvable R_PPC64_TOC16_HA against
`std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>
>::~basic_string()@@GLIBCXX_3.4.21'
/usr/bin/ld: exceptions.cc:(.text+0xdac): unresolvable R_PPC64_TOC16_LO against
`std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>
>::~basic_string()@@GLIBCXX_3.4.21'
/usr/bin/ld: final link failed: Nonrepresentable section on output
collect2: error: ld returned 1 exit status

[Bug rtl-optimization/32219] optimizer causes wrong code in pic/hidden/weak symbol checking.

[pthaugen at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=32219

--- Comment #20 from Pat Haugen <pthaugen at gcc dot gnu.org> ---
(In reply to H.J. Lu from comment #19)
> 
> Can you try fix in PR 65074?

Yes, that fixes the problem.