[Bug bootstrap/32287] gas version style changed causes warnings with configure

[Bug bootstrap/32287] gas version style changed causes warnings with configure

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32287

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kwieman at blackrock dot
                   |                            |com

--- Comment #17 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-02-03 22:44:54 UTC ---
*** Bug 34924 has been marked as a duplicate of this bug. ***

[Bug bootstrap/32287] gas version style changed causes warnings with configure

[hjl dot tools at gmail dot com]

------- Comment #16 from hjl dot tools at gmail dot com  2008-01-22 14:14 -------
Fixed.


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32287

[Bug bootstrap/32287] gas version style changed causes warnings with configure

[hjl at gcc dot gnu dot org]

------- Comment #15 from hjl at gcc dot gnu dot org  2008-01-22 13:55 -------
Subject: Bug 32287

Author: hjl
Date: Tue Jan 22 13:55:11 2008
New Revision: 131718

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131718
Log:
2008-01-22  H.J. Lu  <hongjiu.lu@intel.com>

        PR bootstrap/32287
        * configure.ac (ld_vers): Support GNU linker version xx.xx.*
        (as_vers): Likewise.
        * configure: Regenerated.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/configure
    trunk/gcc/configure.ac


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32287

[Bug bootstrap/32287] gas version style changed causes warnings with configure

[drow at gcc dot gnu dot org]

------- Comment #14 from drow at gcc dot gnu dot org  2008-01-22 13:30 -------
Subject: Re:  gas version style changed causes
        warnings with configure

Thanks, H.J.!


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32287

[Bug bootstrap/32287] gas version style changed causes warnings with configure

[hjl dot tools at gmail dot com]

------- Comment #13 from hjl dot tools at gmail dot com  2008-01-21 23:34 -------
A patch is posted at

http://gcc.gnu.org/ml/gcc-patches/2008-01/msg00974.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32287

[Bug bootstrap/32287] gas version style changed causes warnings with configure

[hjl dot tools at gmail dot com]

------- Comment #12 from hjl dot tools at gmail dot com  2008-01-21 21:57 -------
(In reply to comment #11)
> Subject: Re:  gas version style changed causes
>         warnings with configure
> 
> On Mon, Jan 21, 2008 at 09:43:09PM -0000, hjl dot tools at gmail dot com wrote:
> > The second line isn't needed. I checked the following versions:
> > 
> >         ./check "GNU ld version 2.17.50.0.6-5.fc6 20061020"
> >         ./check "GNU ld version 2.17.50.0.12-4 20070128"
> >         ./check "GNU ld version 2.15.92.0.2 20040927"
> >         ./check "GNU ld (GNU Binutils) 2.18.50.20070913"
> >         ./check "GNU ld (Linux/GNU Binutils) 2.18.50.0.1.20070906"
> >         ./check "GNU ld (GNU Binutils) 2.17.50.20070726-12 (SUSE Linux)"
> >         ./check "GNU assembler (GNU Binutils for Debian) 2.17.50.20070426"
> > 
> > and they work fine. Do you have more to add?
> 
> It will fail on any line that contains xx.yy after the binutils
> version.  Didn't that used to happen?

It worked on binutils 2.9.1, which was released in Feb, 1999.

> If not we can remove basically the entire test.  Once the first
> pattern matches the rest is mostly irrelevant.

Maybe they are irrelevant. Can you find a binutils which fails the current
linker version test?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32287

[Bug bootstrap/32287] gas version style changed causes warnings with configure

[drow at gcc dot gnu dot org]

------- Comment #11 from drow at gcc dot gnu dot org  2008-01-21 21:46 -------
Subject: Re:  gas version style changed causes
        warnings with configure

On Mon, Jan 21, 2008 at 09:43:09PM -0000, hjl dot tools at gmail dot com wrote:
> The second line isn't needed. I checked the following versions:
> 
>         ./check "GNU ld version 2.17.50.0.6-5.fc6 20061020"
>         ./check "GNU ld version 2.17.50.0.12-4 20070128"
>         ./check "GNU ld version 2.15.92.0.2 20040927"
>         ./check "GNU ld (GNU Binutils) 2.18.50.20070913"
>         ./check "GNU ld (Linux/GNU Binutils) 2.18.50.0.1.20070906"
>         ./check "GNU ld (GNU Binutils) 2.17.50.20070726-12 (SUSE Linux)"
>         ./check "GNU assembler (GNU Binutils for Debian) 2.17.50.20070426"
> 
> and they work fine. Do you have more to add?

It will fail on any line that contains xx.yy after the binutils
version.  Didn't that used to happen?

If not we can remove basically the entire test.  Once the first
pattern matches the rest is mostly irrelevant.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32287

[Bug bootstrap/32287] gas version style changed causes warnings with configure

[hjl dot tools at gmail dot com]

------- Comment #10 from hjl dot tools at gmail dot com  2008-01-21 21:43 -------
(In reply to comment #9)
>
> HJ, Richi, I can find a lot of confused versions of HJ's patch in that thread,
> which starts here:
>   http://gcc.gnu.org/ml/gcc-patches/2007-09/msg01170.html

It is a good idea.

> Nowhere can I find the actual approval.  The only version which was approved
> was safe, but the patch as applied is unsafe.  If you put a .* there, then it
> will match any "xx.yy" string anywhere in the version string, including after
> the binutils version!  This does not mess up on --with-pkgversion on new
> versions of binutils but only because sed will use the shorter match, and the
> binutils version comes second.
> 
> +       -e 's,^.*[       ]\([0-9][0-9]*\.[0-9][0-9]*.*\)$,\1,p' \
>         -e 's,^.*[       ]\([0-9][0-9]*\.[0-9][0-9]*\)[  ].*$,\1,p' \
> 
> Note that second line will never match now.

The second line isn't needed. I checked the following versions:

        ./check "GNU ld version 2.17.50.0.6-5.fc6 20061020"
        ./check "GNU ld version 2.17.50.0.12-4 20070128"
        ./check "GNU ld version 2.15.92.0.2 20040927"
        ./check "GNU ld (GNU Binutils) 2.18.50.20070913"
        ./check "GNU ld (Linux/GNU Binutils) 2.18.50.0.1.20070906"
        ./check "GNU ld (GNU Binutils) 2.17.50.20070726-12 (SUSE Linux)"
        ./check "GNU assembler (GNU Binutils for Debian) 2.17.50.20070426"

and they work fine. Do you have more to add?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32287

[Bug bootstrap/32287] gas version style changed causes warnings with configure

[drow at gcc dot gnu dot org]

------- Comment #9 from drow at gcc dot gnu dot org  2008-01-21 20:41 -------
Here's why I didn't remember the patch - I just checked it in, I didn't write
it.

2007-08-23  Brian Sidebotham  <brian.sidebotham@gmail.com>

        * configure.ac (leb128): Modify sed statement to work with any
        binutils version string.
        * configure: Regenerate

That version definitely handles:
as_ver='GNU assembler (GNU Binutils for Debian) 2.18.20071027'

It does not handle:
as_ver='GNU assembler (Linux/GNU Binutils) 2.18.50.0.3.20071102'

This version format is new and is not produced by the FSF binutils.  I assume
it's a result of HJ Lu's Linux binutils after a merge from FSF trunk.

The ld_vers check up higher in the file was changed to handle the new version
format on 2007-09-23.

HJ, Richi, I can find a lot of confused versions of HJ's patch in that thread,
which starts here:
  http://gcc.gnu.org/ml/gcc-patches/2007-09/msg01170.html

Nowhere can I find the actual approval.  The only version which was approved
was safe, but the patch as applied is unsafe.  If you put a .* there, then it
will match any "xx.yy" string anywhere in the version string, including after
the binutils version!  This does not mess up on --with-pkgversion on new
versions of binutils but only because sed will use the shorter match, and the
binutils version comes second.

+       -e 's,^.*[       ]\([0-9][0-9]*\.[0-9][0-9]*.*\)$,\1,p' \
        -e 's,^.*[       ]\([0-9][0-9]*\.[0-9][0-9]*\)[  ].*$,\1,p' \

Note that second line will never match now.

The ld and as tests should be made uniform again but I think that we should go
back to this one:
  http://gcc.gnu.org/ml/gcc-patches/2007-09/msg01170.html


-- 

drow at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl dot tools at gmail dot
                   |                            |com, rguenther at suse dot
                   |                            |de, bonzini at gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32287

[Bug bootstrap/32287] gas version style changed causes warnings with configure

[aldot at gcc dot gnu dot org]

------- Comment #8 from aldot at gcc dot gnu dot org  2008-01-15 10:10 -------
This was recently changed on trunk:
http://gcc.gnu.org/ml/gcc-patches/2007-08/msg01574.html
via
r127745 | drow | 2007-08-23 19:42:08 +0200 (Thu, 23 Aug 2007) | 4 lines

        * configure.ac (leb128): Modify sed statement to work with any binutils
        version string.
        * configure: Regenerate


But this doesn't seem to work for me:

checking assembler for .sleb128 and .uleb128...
/there/toolchain_build_sh4/gcc-4.3.0/gcc/configure: line 14146: test: -eq:
unary operator expected

/there/build_sh4/staging_dir/usr/bin/sh4-linux-uclibcgnueabi-as --version | sed
1q
GNU assembler (Linux/GNU Binutils) 2.18.50.0.3.20071102

Should be fixed before 4.3.0..


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aldot at gcc dot gnu dot
                   |                            |org, drow at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32287

[Bug bootstrap/32287] gas version style changed causes warnings with configure

[rask at gcc dot gnu dot org]

------- Comment #7 from rask at gcc dot gnu dot org  2007-11-20 19:46 -------
*** Bug 34165 has been marked as a duplicate of this bug. ***


-- 

rask at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |warren dot l dot dodge at
                   |                            |tektronix dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32287

[Bug bootstrap/32287] gas version style changed causes warnings with configure

[haubi at gentoo dot org]

------- Comment #6 from haubi at gentoo dot org  2007-10-10 20:47 -------
Because 'grep -o' is not portable, what about this patch, done against
gcc-4.1.1:

--- gcc-4.1.1/gcc/configure.ac.orig Wed Oct 10 08:44:23 2007
+++ gcc-4.1.1/gcc/configure.ac  Wed Oct 10 09:03:22 2007
@@ -2061,7 +2061,7 @@
   as_ver=`$gcc_cv_as --version 2>/dev/null | sed 1q`
   if echo "$as_ver" | grep GNU > /dev/null; then
 changequote(,)dnl
-    as_ver=`echo $as_ver | sed -e 's/GNU assembler \([0-9.][0-9.]*\).*/\1/'`
+    as_ver=`echo $as_ver | sed -e 's/GNU assembler[^0-9]*
\([0-9.][0-9.]*\).*/\1/'`
     as_major=`echo $as_ver | sed 's/\..*//'`
     as_minor=`echo $as_ver | sed 's/[^.]*\.\([0-9]*\).*/\1/'`
 changequote([,])dnl


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32287

[Bug bootstrap/32287] gas version style changed causes warnings with configure

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2007-07-28 00:52 -------
*** Bug 32922 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32287

[Bug bootstrap/32287] gas version style changed causes warnings with configure

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2007-07-28 00:53 -------
Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |build
   Last reconfirmed|0000-00-00 00:00:00         |2007-07-28 00:53:45
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32287