[Bug rtl-optimization/32773] New: [4.3 Regression] SH: ICE in create_pre_exit, at mode-switching.c:223

[Bug rtl-optimization/32773] New: [4.3 Regression] SH: ICE in create_pre_exit, at mode-switching.c:223

[kkojima at gcc dot gnu dot org]

With -m4 -O -fprofile-use, sh-elf compiler fails for

void foo (int *p)
{
  if (p)
    *p = 0;
}

with

  internal compiler error: in create_pre_exit, at mode-switching.c:223

It starts to fail after the patch

r126576 | rakdver | 2007-07-12 19:24:19 +0900 (Thu, 12 Jul 2007) | 5 lines

        PR rtl-optimization/32729
        * cfghooks.c (can_duplicate_block_p): Do not forbid duplicating blocks
        that fallthru to exit.

mode-switching.c:create_pre_exit seems to assume that there is
at most one fallthru predecessor to exit block.  Unfortunately,
cfg_layout_finalize can't fix the problem, as mode-switching pass
runs before reload_completed and cfg_layout_finalize calls
fixup_fallthru_exit_predecessor only after reload_completed.


-- 
           Summary: [4.3 Regression] SH: ICE in create_pre_exit, at mode-
                    switching.c:223
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: kkojima at gcc dot gnu dot org
GCC target triplet: sh-elf


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32773

[Bug rtl-optimization/32773] [4.3 Regression] SH: ICE in create_pre_exit, at mode-switching.c:223

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32773

[Bug rtl-optimization/32773] [4.3 Regression] SH: ICE in create_pre_exit, at mode-switching.c:223

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2007-07-16 09:47 -------
Zdenek, I think this change also breaks FDO compiles with tramp3d, sed, gawk
and gzip (the resulting -fprofile-use binaries segfault).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32773

[Bug rtl-optimization/32773] [4.3 Regression] SH: ICE in create_pre_exit, at mode-switching.c:223

[rakdver at gcc dot gnu dot org]

------- Comment #2 from rakdver at gcc dot gnu dot org  2007-07-16 09:56 -------
(In reply to comment #1)
> Zdenek, I think this change also breaks FDO compiles with tramp3d, sed, gawk
> and gzip (the resulting -fprofile-use binaries segfault).

At least now we know why the check was there :-)


-- 

rakdver at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rakdver at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-07-16 09:56:03
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32773

[Bug rtl-optimization/32773] [4.3 Regression] SH: ICE in create_pre_exit, at mode-switching.c:223

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2007-07-16 10:23 -------
I verified that reverting r126576 fixes the tramp3d miscompile.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32773

[Bug rtl-optimization/32773] [4.3 Regression] SH: ICE in create_pre_exit, at mode-switching.c:223

[burnus at gcc dot gnu dot org]

------- Comment #4 from burnus at gcc dot gnu dot org  2007-07-16 15:56 -------
*** Bug 32779 has been marked as a duplicate of this bug. ***


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32773

[Bug rtl-optimization/32773] [4.3 Regression] SH: ICE in create_pre_exit, at mode-switching.c:223

[rakdver at gcc dot gnu dot org]

------- Comment #5 from rakdver at gcc dot gnu dot org  2007-07-16 19:39 -------
Patch: http://gcc.gnu.org/ml/gcc-patches/2007-07/msg01462.html


-- 

rakdver at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2007-
                   |                            |07/msg01462.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32773

[Bug rtl-optimization/32773] [4.3 Regression] SH: ICE in create_pre_exit, at mode-switching.c:223

[rakdver at gcc dot gnu dot org]

------- Comment #6 from rakdver at gcc dot gnu dot org  2007-07-17 03:56 -------
Subject: Bug 32773

Author: rakdver
Date: Tue Jul 17 03:56:40 2007
New Revision: 126700

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=126700
Log:
        PR rtl-optimization/32773
        * cfglayout.c (force_one_exit_fallthru): New function.
        (cfg_layout_finalize): Use it.

        * gcc.dg/pr32773.c: New test.


Added:
    trunk/gcc/testsuite/gcc.dg/pr32773.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cfglayout.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32773

[Bug rtl-optimization/32773] [4.3 Regression] SH: ICE in create_pre_exit, at mode-switching.c:223

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2007-07-18 19:45 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32773