[Bug fortran/32867] New: [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[Bug fortran/32867] New: [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[hjl at lucon dot org]

This patch

http://gcc.gnu.org/ml/gcc-cvs/2007-07/msg00685.html

causes

(gdb) r readdata.f90 -quiet -dumpbase readdata.f90 -mtune=generic -auxbase
readdata -O2 -version -ffast-math -o readdata.s -fintrinsic-modules-path
/export/gnu/import/rrs/126826/usr/lib/gcc/x86_64-unknown-linux-gnu/4.3.0/finclude
Starting program:
/export/gnu/import/rrs/126826/usr/libexec/gcc/x86_64-unknown-linux-gnu/4.3.0/f951
readdata.f90 -quiet -dumpbase readdata.f90 -mtune=generic -auxbase readdata -O2
-version -ffast-math -o readdata.s -fintrinsic-modules-path
/export/gnu/import/rrs/126826/usr/lib/gcc/x86_64-unknown-linux-gnu/4.3.0/finclude
GNU F95 version 4.3.0 20070722 (experimental) (x86_64-unknown-linux-gnu)
        compiled by GNU C version 3.4.6 20060404 (Red Hat 3.4.6-8), GMP version
4.2.1, MPFR version 2.2.1.
GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072

Program received signal SIGSEGV, Segmentation fault.
0x00000000004072b5 in gfc_compare_string (a=0xe78f90, b=0xe79710)
    at ../../src/gcc/fortran/arith.c:1171
1171          ac = (unsigned char) ((i < alen) ? a->value.character.string[i] :
' ');
(gdb) p a->value
$1 = {logical = 15170912, integer = {{_mp_alloc = 15170912, _mp_size = 0,
      _mp_d = 0xe660fd}}, real = {{_mpfr_prec = 15170912,
      _mpfr_sign = 15098109, _mpfr_exp = 14833104, _mpfr_d = 0x0}}, complex = {
    r = {{_mpfr_prec = 15170912, _mpfr_sign = 15098109, _mpfr_exp = 14833104,
        _mpfr_d = 0x0}}, i = {{_mpfr_prec = 0, _mpfr_sign = 0, _mpfr_exp = 0,
        _mpfr_d = 0x0}}}, op = {operator = 15170912, uop = 0xe660fd,
    op1 = 0xe255d0, op2 = 0x0}, function = {actual = 0xe77d60,
    name = 0xe660fd "__trim_1", isym = 0xe255d0, esym = 0x0}, character = {
    length = 15170912, string = 0xe660fd "__trim_1"}, constructor = 0xe77d60}
(gdb) p a->value.character
$2 = {length = 15170912, string = 0xe660fd "__trim_1"}
(gdb) list
1166
1167      for (i = 0; i < len; i++)
1168        {
1169          /* We cast to unsigned char because default char, if it is
signed,
1170             would lead to ac < 0 for string[i] > 127.  */
1171          ac = (unsigned char) ((i < alen) ? a->value.character.string[i] :
' ');
1172          bc = (unsigned char) ((i < blen) ? b->value.character.string[i] :
' ');
1173
1174          if (ac < bc)
1175            return -1;
(gdb) p b->value.character.string
$3 = 0xe660fd "__trim_1"
(gdb) p a->value.character.string
$4 = 0xe660fd "__trim_1"
(gdb) p i
$5 = 741123
(gdb) p len
$6 = 15180528
(gdb) bt
#0  0x00000000004072b5 in gfc_compare_string (a=0xe78f90, b=0xe79710)
    at ../../src/gcc/fortran/arith.c:1171
#1  0x0000000000407393 in gfc_compare_expr (op1=0xe78f90, op2=0xe79710)
    at ../../src/gcc/fortran/arith.c:1126
#2  0x000000000045567a in resolve_code (code=0xe78b30, ns=0xe6e770)
    at ../../src/gcc/fortran/resolve.c:4541
#3  0x00000000004558e4 in gfc_resolve_blocks (b=0xe75530, ns=0xe6e770)
    at ../../src/gcc/fortran/resolve.c:5699
#4  0x0000000000454150 in resolve_code (code=0xe71740, ns=0xe6e770)
    at ../../src/gcc/fortran/resolve.c:5758
#5  0x000000000045771b in resolve_codes (ns=0xe6e770)
    at ../../src/gcc/fortran/resolve.c:8463
#6  0x00000000004576da in resolve_codes (ns=0xe63e70)
    at ../../src/gcc/fortran/resolve.c:8455
#7  0x0000000000457755 in gfc_resolve (ns=0xe63e70)
    at ../../src/gcc/fortran/resolve.c:8482
#8  0x000000000044acac in gfc_parse_file ()
    at ../../src/gcc/fortran/parse.c:3270
#9  0x000000000046d7ce in gfc_be_parse_file (set_yydebug=<value optimized out>)
    at ../../src/gcc/fortran/f95-lang.c:301
#10 0x00000000005f9f7e in toplev_main (argc=<value optimized out>,
    argv=<value optimized out>) at ../../src/gcc/toplev.c:1044
#11 0x00000033b381c3fb in __libc_start_main () from /lib64/tls/libc.so.6
---Type <return> to continue, or q <return> to quit---
#12 0x00000000004053da in _start ()
(gdb)

Daniel, does it ring a bell?


-- 
           Summary: [4.3 Regression]  459.GemsFDTD in SPEC CPU 2006 fails to
                    compile
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl at lucon dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867

[Bug fortran/32867] [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[hjl at lucon dot org]

------- Comment #1 from hjl at lucon dot org  2007-07-23 15:02 -------
(gdb) p b->value.character
$10 = {length = 15180528, string = 0xe660fd "__trim_1"}
(gdb) p a->value.character
$11 = {length = 15170912, string = 0xe660fd "__trim_1"}

The length field doesn't look right.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867

[Bug fortran/32867] [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[dfranke at gcc dot gnu dot org]

------- Comment #2 from dfranke at gcc dot gnu dot org  2007-07-23 15:08 -------
Not yet.

http://gcc.gnu.org/ml/gcc-patches/2007-07/msg01652.html

is an update for the quoted patch, it might help to the extend that you get an
error, not an ice. 

What does the corresponding Fortran code look like?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867

[Bug fortran/32867] [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[hjl at lucon dot org]

------- Comment #3 from hjl at lucon dot org  2007-07-23 16:09 -------
(In reply to comment #2)
> Not yet.
> 
> http://gcc.gnu.org/ml/gcc-patches/2007-07/msg01652.html
> 
> is an update for the quoted patch, it might help to the extend that you get an
> error, not an ice.

It makes no difference.

> 
> What does the corresponding Fortran code look like?

I am working on a small testcase.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867

[Bug fortran/32867] [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[hjl at lucon dot org]

------- Comment #4 from hjl at lucon dot org  2007-07-23 16:23 -------
Here is a small testcase:

[hjl@gnu-26 459.GemsFDTD]$ cat foo.f90 
MODULE Readdata_mod
IMPLICIT NONE
Private
Public  Parser
integer, parameter                    :: nkeywords = 2
character(80), PARAMETER, dimension(1:nkeywords) :: keywords = &
 (/'PROBLEMSIZE                                  ',            &
   'NFTRANS_TD                                   '/)

CONTAINS
SUBROUTINE Parser(nx, ny, keyword)
  integer, intent(inout) :: nx, ny
  character(80), intent(inout) :: keyword
  select case (keyword)
  case (trim(keywords(1))) ! PROBLEMSIZE
    nx = 1
  case (trim(keywords(2))) !'NFTRANS_TD'
    ny = 1
  end select
END SUBROUTINE Parser
END MODULE Readdata_mod
[hjl@gnu-26 459.GemsFDTD]$ ../126826/usr/bin/gfortran       -O2 -ffast-math    
   -DSPEC_CPU_LP64          -S  foo.f90
foo.f90:0: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.
[hjl@gnu-26 459.GemsFDTD]$  


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867

[Bug fortran/32867] [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[hjl at lucon dot org]

------- Comment #5 from hjl at lucon dot org  2007-07-23 16:31 -------
A smaller testcase:

[hjl@gnu-26 459.GemsFDTD]$ cat foo.f90 
SUBROUTINE Parser(nx, ny, keyword)
  character(80), PARAMETER, dimension(1:2) :: keywords = &
   (/'PROBLEMSIZE', &
     'NFTRANS_TD'/)
  integer, intent(inout) :: nx, ny
  character(80), intent(inout) :: keyword
  select case (keyword)
  case (trim(keywords(1))) ! PROBLEMSIZE
    nx = 1
  case (trim(keywords(2))) !'NFTRANS_TD'
    ny = 1
  end select
END SUBROUTINE Parser
[hjl@gnu-26 459.GemsFDTD]$ ../126826/usr/bin/gfortran       -O2 -ffast-math    
   -DSPEC_CPU_LP64          -S  foo.f90
foo.f90:0: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.
[hjl@gnu-26 459.GemsFDTD]$ 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867

[Bug fortran/32867] [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[dfranke at gcc dot gnu dot org]

------- Comment #6 from dfranke at gcc dot gnu dot org  2007-07-23 16:36 -------
Confirmed. Will look into it.
As it works with scalars, I think I forgot to take arrays into account ...


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|franke dot daniel at gmail  |
                   |dot com                     |
         AssignedTo|unassigned at gcc dot gnu   |dfranke at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-07-23 16:36:25
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867

[Bug fortran/32867] [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[jv244 at cam dot ac dot uk]

------- Comment #7 from jv244 at cam dot ac dot uk  2007-07-23 18:46 -------
(In reply to comment #5)
>   character(80), PARAMETER, dimension(1:2) :: keywords = &
>    (/'PROBLEMSIZE', &
>      'NFTRANS_TD'/)


it is probably not related to the ICE, but the above is invalid F95. 
Error: test.f90, line 2: Array constructor values have differing CHARACTER
lengths (11 and 10). gfortran should error out on this.


-- 

jv244 at cam dot ac dot uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |32834
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867

[Bug fortran/32867] [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[dfranke at gcc dot gnu dot org]

------- Comment #8 from dfranke at gcc dot gnu dot org  2007-07-23 18:50 -------
> it is probably not related to the ICE, but the above is invalid F95. 
> Error: test.f90, line 2: Array constructor values have differing CHARACTER
> lengths (11 and 10). gfortran should error out on this.

This is PR29267 (and PR32707 is probably a dupe).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867

[Bug fortran/32867] [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[dfranke at gcc dot gnu dot org]

------- Comment #9 from dfranke at gcc dot gnu dot org  2007-07-23 19:42 -------
Currently regtesting the patch below without problem so far.
H.J. could you please verify that it fixes your problem?

Index: expr.c
===================================================================
--- expr.c      (revision 126826)
+++ expr.c      (working copy)
@@ -2121,7 +2132,7 @@
        }

       if (m == MATCH_YES)
-       t = SUCCESS;
+       t =  gfc_simplify_expr (e, 0);

       break;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867

[Bug fortran/32867] [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[hjl at lucon dot org]

------- Comment #10 from hjl at lucon dot org  2007-07-23 19:53 -------
(In reply to comment #9)
> Currently regtesting the patch below without problem so far.
> H.J. could you please verify that it fixes your problem?
> 
> Index: expr.c
> ===================================================================
> --- expr.c      (revision 126826)
> +++ expr.c      (working copy)
> @@ -2121,7 +2132,7 @@
>         }
> 
>        if (m == MATCH_YES)
> -       t = SUCCESS;
> +       t =  gfc_simplify_expr (e, 0);
> 
>        break;
> 

It passed my small testcase. The full test will take several hours.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867

[Bug fortran/32867] [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[dfranke at gcc dot gnu dot org]

------- Comment #11 from dfranke at gcc dot gnu dot org  2007-07-23 20:08 -------
Patch in comment #9 passed regression testing on i686-pc-linux-gnu.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867

[Bug fortran/32867] [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[hjl at lucon dot org]

------- Comment #12 from hjl at lucon dot org  2007-07-24 03:33 -------
(In reply to comment #9)
> Currently regtesting the patch below without problem so far.
> H.J. could you please verify that it fixes your problem?
> 
> Index: expr.c
> ===================================================================
> --- expr.c      (revision 126826)
> +++ expr.c      (working copy)
> @@ -2121,7 +2132,7 @@
>         }
> 
>        if (m == MATCH_YES)
> -       t = SUCCESS;
> +       t =  gfc_simplify_expr (e, 0);
> 
>        break;
> 

I have verified that 459.GemsFDTD is compiled correctly with this patch.
Thanks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867

[Bug fortran/32867] [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[patchapp at dberlin dot org]

------- Comment #13 from patchapp at dberlin dot org  2007-07-24 08:45 -------
Subject: Bug number PR32867

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-07/msg01713.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867

[Bug fortran/32867] [4.3 Regression] 459.GemsFDTD in SPEC CPU 2006 fails to compile

[dfranke at gcc dot gnu dot org]

------- Comment #14 from dfranke at gcc dot gnu dot org  2007-07-24 16:57 -------
Subject: Bug 32867

Author: dfranke
Date: Tue Jul 24 16:57:02 2007
New Revision: 126882

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=126882
Log:
gcc/fortran:
2007-07-24  Daniel Franke  <franke.daniel@gmail.com>

        PR fortran/32867
        * expr.c (check_init_expr): Simplify matched functions.

gcc/testsuite:
2007-07-24  Daniel Franke  <franke.daniel@gmail.com>

        PR fortran/32867
        * fortran.dg/initialization_10.f90: New test.


Added:
    trunk/gcc/testsuite/gfortran.dg/initialization_10.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/expr.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867

[Bug fortran/32867] [4.3 Regression] ICE on nested initialization expressions

[dfranke at gcc dot gnu dot org]

------- Comment #15 from dfranke at gcc dot gnu dot org  2007-07-24 16:59 -------
Changed the title to reflect the actual problem.
Closing as fixed.


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Summary|[4.3 Regression]            |[4.3 Regression]  ICE on
                   |459.GemsFDTD in SPEC CPU    |nested initialization
                   |2006 fails to compile       |expressions
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32867