public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/32899] New: [4.3 regresssion] Broken diagnostic for invalid use of .eq. for logicals
@ 2007-07-25 22:19 reichelt at gcc dot gnu dot org
2007-07-25 22:19 ` [Bug fortran/32899] " reichelt at gcc dot gnu dot org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: reichelt at gcc dot gnu dot org @ 2007-07-25 22:19 UTC (permalink / raw)
To: gcc-bugs
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1806 bytes --]
Mainline produces a bad diagnostic for the following code snippet:
===========================
subroutine FOO
logical I
I = I .eq. I
end subroutine
===========================
ePR22503.f:3.13:
I = I .eq. I
1
Error: Logicals at (1) must be compared with .neqv. instead of .eq.
This should read ".eqv." instead of ".neqv.".
The regression was caused by the following patch:
2007-07-08 Daniel Franke <franke.daniel@gmail.com>
Tobias Schlüter <tobias.schlueter@physik.uni-muenchen.de>
PR fortran/17711
* gfortran.h (gfc_intrinsic_op): Added INTRINSIC_EQ_OS,
INTRINSIC_NE_OS, INTRINSIC_GT_OS, INTRINSIC_GE_OS,
INTRINSIC_LT_OS and INTRINSIC_LE_OS.
...
The problem is in the following code snipppet from the function
resolve_operator in resolve.c:
...
if (op1->ts.type == BT_LOGICAL && op2->ts.type == BT_LOGICAL)
sprintf (msg,
_("Logicals at %%L must be compared with %s instead of %s"),
e->value.op.operator == INTRINSIC_EQ ? ".eqv." : ".neqv.",
gfc_op2string (e->value.op.operator));
else
...
Instead of only testing for INTRINSIC_EQ there should also be a test for
INTRINSIC_EQ_OS IMHO.
--
Summary: [4.3 regresssion] Broken diagnostic for invalid use of
.eq. for logicals
Product: gcc
Version: 4.3.0
Status: UNCONFIRMED
Keywords: diagnostic
Severity: normal
Priority: P3
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: reichelt at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32899
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug fortran/32899] [4.3 regresssion] Broken diagnostic for invalid use of .eq. for logicals
2007-07-25 22:19 [Bug fortran/32899] New: [4.3 regresssion] Broken diagnostic for invalid use of .eq. for logicals reichelt at gcc dot gnu dot org
@ 2007-07-25 22:19 ` reichelt at gcc dot gnu dot org
2007-07-25 23:57 ` kargl at gcc dot gnu dot org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: reichelt at gcc dot gnu dot org @ 2007-07-25 22:19 UTC (permalink / raw)
To: gcc-bugs
--
reichelt at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.3.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32899
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug fortran/32899] [4.3 regresssion] Broken diagnostic for invalid use of .eq. for logicals
2007-07-25 22:19 [Bug fortran/32899] New: [4.3 regresssion] Broken diagnostic for invalid use of .eq. for logicals reichelt at gcc dot gnu dot org
2007-07-25 22:19 ` [Bug fortran/32899] " reichelt at gcc dot gnu dot org
@ 2007-07-25 23:57 ` kargl at gcc dot gnu dot org
2007-07-26 8:15 ` dfranke at gcc dot gnu dot org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: kargl at gcc dot gnu dot org @ 2007-07-25 23:57 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from kargl at gcc dot gnu dot org 2007-07-25 23:57 -------
Confirmed.
Volker's suggestion is the correct fix. I have a patch
and test case. I'm regression testing I as I type.
--
kargl at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kargl at gcc dot gnu dot org
AssignedTo|unassigned at gcc dot gnu |kargl at gcc dot gnu dot org
|dot org |
Status|UNCONFIRMED |ASSIGNED
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2007-07-25 23:57:31
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32899
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug fortran/32899] [4.3 regresssion] Broken diagnostic for invalid use of .eq. for logicals
2007-07-25 22:19 [Bug fortran/32899] New: [4.3 regresssion] Broken diagnostic for invalid use of .eq. for logicals reichelt at gcc dot gnu dot org
2007-07-25 22:19 ` [Bug fortran/32899] " reichelt at gcc dot gnu dot org
2007-07-25 23:57 ` kargl at gcc dot gnu dot org
@ 2007-07-26 8:15 ` dfranke at gcc dot gnu dot org
2007-07-27 16:59 ` kargl at gcc dot gnu dot org
2007-07-27 17:00 ` kargl at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: dfranke at gcc dot gnu dot org @ 2007-07-26 8:15 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from dfranke at gcc dot gnu dot org 2007-07-26 08:14 -------
Thanks Steve :)
--
dfranke at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|franke dot daniel at gmail |dfranke at gcc dot gnu dot
|dot com |org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32899
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug fortran/32899] [4.3 regresssion] Broken diagnostic for invalid use of .eq. for logicals
2007-07-25 22:19 [Bug fortran/32899] New: [4.3 regresssion] Broken diagnostic for invalid use of .eq. for logicals reichelt at gcc dot gnu dot org
` (2 preceding siblings ...)
2007-07-26 8:15 ` dfranke at gcc dot gnu dot org
@ 2007-07-27 16:59 ` kargl at gcc dot gnu dot org
2007-07-27 17:00 ` kargl at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: kargl at gcc dot gnu dot org @ 2007-07-27 16:59 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from kargl at gcc dot gnu dot org 2007-07-27 16:59 -------
Subject: Bug 32899
Author: kargl
Date: Fri Jul 27 16:59:32 2007
New Revision: 126985
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=126985
Log:
2007-07-26 Steven G. Kargl <kargl@gcc.gnu.org>
PR fortran/32899
* resolve.c (resolve_operator): Add INTRINSIC_EQ_OS comparison.
2007-07-26 Steven G. Kargl <kargl@gcc.gnu.org>
PR fortran/32899
* gfortran.dg/logical_comp.f90: Update dg-error strings.
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/resolve.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gfortran.dg/logical_comp.f90
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32899
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug fortran/32899] [4.3 regresssion] Broken diagnostic for invalid use of .eq. for logicals
2007-07-25 22:19 [Bug fortran/32899] New: [4.3 regresssion] Broken diagnostic for invalid use of .eq. for logicals reichelt at gcc dot gnu dot org
` (3 preceding siblings ...)
2007-07-27 16:59 ` kargl at gcc dot gnu dot org
@ 2007-07-27 17:00 ` kargl at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: kargl at gcc dot gnu dot org @ 2007-07-27 17:00 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from kargl at gcc dot gnu dot org 2007-07-27 17:00 -------
Fixed on trunk.
--
kargl at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32899
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-07-27 17:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-25 22:19 [Bug fortran/32899] New: [4.3 regresssion] Broken diagnostic for invalid use of .eq. for logicals reichelt at gcc dot gnu dot org
2007-07-25 22:19 ` [Bug fortran/32899] " reichelt at gcc dot gnu dot org
2007-07-25 23:57 ` kargl at gcc dot gnu dot org
2007-07-26 8:15 ` dfranke at gcc dot gnu dot org
2007-07-27 16:59 ` kargl at gcc dot gnu dot org
2007-07-27 17:00 ` kargl at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).