[Bug target/33120] Data not put in BSS section on Mac OS

[Bug target/33120] Data not put in BSS section on Mac OS

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

--- Comment #18 from Iain Sandoe <iains at gcc dot gnu.org> 2010-11-29 14:58:24 UTC ---
Author: iains
Date: Mon Nov 29 14:58:16 2010
New Revision: 167242

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=167242
Log:

    PR target/26427
    PR target/33120
    PR testsuite/35710

gcc:
    * config/i386/darwin.h (ASM_OUTPUT_COMMON): Remove
    (ASM_OUTPUT_LOCAL): Likewise.
    * config/darwin-protos.h (darwin_asm_declare_object_name): New.
    (darwin_output_aligned_bss): Likewise.
    (darwin_asm_output_aligned_decl_local): Likewise.
    (darwin_asm_output_aligned_decl_common): Likewise.
    (darwin_use_anchors_for_symbol_p): Likewise.
    * config/rs6000/darwin.h (ASM_OUTPUT_COMMON): Remove.
    (TARGET_ASM_OUTPUT_ANCHOR): Define.
    (TARGET_USE_ANCHORS_FOR_SYMBOL_P): Define.
    (DARWIN_SECTION_ANCHORS): Set to 1.
    * config/darwin.c (emit_aligned_common): New var.
    (darwin_init_sections): Check that the Darwin private zero-size section
    marker is in range.
    (darwin_text_section): Check for zero-sized objects.
    (darwin_mergeable_string_section): Likewise.
    (darwin_mergeable_constant_section): Likewise.
    (machopic_select_section): Adjust to check for zero-sized objects.
    Assert that OBJC meta data are non-zero sized.
    (darwin_asm_declare_object_name): New.
    (darwin_asm_declare_constant_name): Adjust for zero-sized
    object sections.
    (BYTES_ZFILL): Define.
    (darwin_emit_weak_or_comdat): New.
    (darwin_emit_local_bss): New.
    (darwin_emit_common): New.
    (darwin_output_aligned_bss): New.
    (darwin_asm_output_aligned_decl_common): New.
    (darwin_asm_output_aligned_decl_local): New.
    (darwin_file_end): Disable subsections_via_symbols when section
    anchoring is active.
    (darwin_asm_output_anchor): Re-enable.
    (darwin_use_anchors_for_symbol_p): New.
    (darwin_override_options): Check for versions that can emit
    aligned common.  Update usage of flags to current.
    * config/darwin-sections.def: Update comments and flags for
    non-anchor sections.  zobj_const_section, zobj_data_section,
    zobj_bss_section, zobj_const_data_section: New.
    * config/darwin.h (ASM_DECLARE_OBJECT_NAME): Redefine.
    (ASM_OUTPUT_ALIGN): Make whitespace output consistent.
    (L2_MAX_OFILE_ALIGNMENT): Define.
    (ASM_OUTPUT_ALIGNED_BSS): Define.
    (ASM_OUTPUT_ALIGNED_DECL_LOCAL): Define.
    (ASM_OUTPUT_ALIGNED_DECL_COMMON): Define.
    (SECTION_NO_ANCHOR): Define.
    (TARGET_ASM_OUTPUT_ANCHOR) Define with a default of NULL.
    (DARWIN_SECTION_ANCHORS): Define with a default of 0.

boehm-gc:
    * dyn_load.c (GC_register_dynamic_libraries/DARWIN):  Add new writable
    data section names.
    (GC_dyld_name_for_hdr): Adjust layout.
    (GC_dyld_image_add): Adjust layout, add new Darwin sections, adjust
    debug to name the sections.
    (GC_dyld_image_remove): Adjust layout, remove new Darwin sections,
    adjust debug to name the sections.
    (GC_register_dynamic_libraries): Adjust layout.
    (GC_init_dyld): Likewise.
    (GC_register_main_static_data): Likewise.

gcc/testsuite:
    * gcc.target/powerpc/darwin-abi-12.c: Adjust for new allocators.
    * gcc.dg/pr26427.c: Remove redundant warning for powerpc.
    * gcc.dg/darwin-comm.c: Adjust for new allocators.
    * gcc.dg/darwin-sections.c: New test.
    * g++.dg/ext/instantiate2.C: Adjust for new allocators.


Added:
    trunk/gcc/testsuite/gcc.dg/darwin-sections.c
Modified:
    trunk/boehm-gc/ChangeLog
    trunk/boehm-gc/dyn_load.c
    trunk/gcc/ChangeLog
    trunk/gcc/config/darwin-protos.h
    trunk/gcc/config/darwin-sections.def
    trunk/gcc/config/darwin.c
    trunk/gcc/config/darwin.h
    trunk/gcc/config/i386/darwin.h
    trunk/gcc/config/rs6000/darwin.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/ext/instantiate2.C
    trunk/gcc/testsuite/gcc.dg/darwin-comm.c
    trunk/gcc/testsuite/gcc.dg/pr26427.c
    trunk/gcc/testsuite/gcc.target/powerpc/darwin-abi-12.c

[Bug target/33120] Data not put in BSS section on Mac OS

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.2                       |4.5.3

--- Comment #19 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-12-16 13:03:21 UTC ---
GCC 4.5.2 is being released, adjusting target milestone.

[Bug target/33120] Data not put in BSS section on Mac OS

[mrs at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

mrs@gcc.gnu.org <mrs at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW
                 CC|                            |mrs at gcc dot gnu.org

[Bug target/33120] Data not put in BSS section on Mac OS

[mrs at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

mrs@gcc.gnu.org <mrs at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|4.5.3                       |4.5.2

--- Comment #20 from mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> 2010-12-16 19:57:30 UTC ---
I believe this is fixed now.  Let us know if there are any remaining bits.

[Bug target/33120] Data not put in BSS section on Mac OS

[mrs at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

--- Comment #21 from mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> 2010-12-16 20:00:20 UTC ---
Oh, Iain, is the target milestone 4.6.0, or 4.5.2?  I was thinking 4.5.2, but
not sure.

[Bug target/33120] Data not put in BSS section on Mac OS

[mrs at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

mrs@gcc.gnu.org <mrs at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.2                       |4.6.0

--- Comment #22 from mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> 2010-12-16 20:05:47 UTC ---
Oops, fixed in 4.6.0.

[Bug target/33120] Data not put in BSS section on Mac OS

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

--- Comment #23 from Iain Sandoe <iains at gcc dot gnu.org> 2010-12-16 20:07:46 UTC ---
it's fixed on trunk.

Although it was reported against 4.2, since it's not a regression I'm not sure
of the policy on back-porting.
(and, to be honest, a back-port for this is not high on my list).  Happy to
review/test if anyone else wants to do it tho. :-)

If it's not eligible for back-port then we should just close it as fixed.

[Bug target/33120] Data not put in BSS section on Mac OS

[mikestump at comcast dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

--- Comment #24 from Mike Stump <mikestump at comcast dot net> 2010-12-16 21:05:06 UTC ---
Yeah, I don't think it is too important to back port.  The next release is
coming out soon, and I don't think its a big issue and has always been there. 
I'd propose to not back port.

[Bug target/33120] Data not put in BSS section on Mac OS

[rguenth at gcc dot gnu dot org]

------- Comment #17 from rguenth at gcc dot gnu dot org  2010-07-31 09:29 -------
GCC 4.5.1 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.1                       |4.5.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

[Bug target/33120] Data not put in BSS section on Mac OS

[rguenth at gcc dot gnu dot org]

------- Comment #16 from rguenth at gcc dot gnu dot org  2010-04-06 11:19 -------
GCC 4.5.0 is being released.  Deferring to 4.5.1.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.0                       |4.5.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

[Bug target/33120] Data not put in BSS section on Mac OS

[developer at sandoe-acoustics dot co dot uk]

------- Comment #15 from developer at sandoe-acoustics dot co dot uk  2010-03-24 17:39 -------
(In reply to comment #14)
> Note that there was no libjava test failure with the patch in
> http://gcc.gnu.org/ml/fortran/2010-03/txt00007.txt . Also with this patch the
> test in comment #8 was not improved.

since this is re-opened a few notes .. 

(a) the test at comment #8 is different from the original bug since it carries
out explicit initialization (as opposed to implicit).

(b) I don't think the issue is the segment into which the data are assembled,
but rather that the .space instruction is inefficient c.f. the .zerofill one.  

(c) comment (b) might lead to the observation that we could further improve
things by replacing .space with .zerofill as the darwin ASM_SKIP_OP ..
unfortunately, .zerofill needs state information (viz-a-viz what segment is
current) or, alternatively, a priori knowledge of the target segment.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

[Bug target/33120] Data not put in BSS section on Mac OS

[dominiq at lps dot ens dot fr]

------- Comment #14 from dominiq at lps dot ens dot fr  2010-03-24 17:27 -------
Note that there was no libjava test failure with the patch in
http://gcc.gnu.org/ml/fortran/2010-03/txt00007.txt . Also with this patch the
test in comment #8 was not improved.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

[Bug target/33120] Data not put in BSS section on Mac OS

[mrs at gcc dot gnu dot org]

------- Comment #13 from mrs at gcc dot gnu dot org  2010-03-24 16:13 -------
The fixed cause many failures in the libjava testsuite.  I've reverted this fix
for now until I can spend some time to resolve those issues.  We should also
ensure that ada is clean as well before we consider this done.


-- 

mrs at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikestump at comcast dot net
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

[Bug target/33120] Data not put in BSS section on Mac OS

[mrs at gcc dot gnu dot org]

------- Comment #12 from mrs at gcc dot gnu dot org  2010-03-24 16:08 -------
Subject: Bug 33120

Author: mrs
Date: Wed Mar 24 16:07:51 2010
New Revision: 157697

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=157697
Log:
        PR java/43504
        Revert fix for PR target/33120.

Removed:
    trunk/gcc/testsuite/gcc.target/i386/darwin-zerofill.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/darwin-protos.h
    trunk/gcc/config/darwin.c
    trunk/gcc/config/darwin.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/ext/instantiate2.C


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

[Bug target/33120] Data not put in BSS section on Mac OS

[mrs at gcc dot gnu dot org]

------- Comment #11 from mrs at gcc dot gnu dot org  2010-03-23 20:13 -------
This should now be fixed.


-- 

mrs at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

[Bug target/33120] Data not put in BSS section on Mac OS

[mrs at gcc dot gnu dot org]

------- Comment #10 from mrs at gcc dot gnu dot org  2010-03-23 20:03 -------
Subject: Bug 33120

Author: mrs
Date: Tue Mar 23 20:02:57 2010
New Revision: 157677

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=157677
Log:
        PR target/33120
        * config/darwin.h (ASM_OUTPUT_ALIGNED_BSS): Add.
        * config/darwin.c (darwin_output_aligned_bss): Add.
        * config/darwin-protos.h: Add darwin_output_aligned_bss.

testsuite:
        * g++.dg/ext/instantiate2.C: Update for .zerofill as it doesn't
        follow the usual conventions for symbol definitions.
        * gcc.target/i386/darwin-zerofill.c: Add.

Added:
    trunk/gcc/testsuite/gcc.target/i386/darwin-zerofill.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/darwin-protos.h
    trunk/gcc/config/darwin.c
    trunk/gcc/config/darwin.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/ext/instantiate2.C


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

[Bug target/33120] Data not put in BSS section on Mac OS

[pinskia at gcc dot gnu dot org]

------- Comment #9 from pinskia at gcc dot gnu dot org  2010-03-22 18:57 -------
*** Bug 43481 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |developer at sandoe-
                   |                            |acoustics dot co dot uk


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120

[Bug target/33120] Data not put in BSS section on Mac OS

[fxcoudert at gcc dot gnu dot org]

------- Comment #8 from fxcoudert at gcc dot gnu dot org  2009-12-29 21:34 -------
This is not a Fortran issue, but a generic Darwin issue:

$ cat a.c 
int x[9999999] = { 0 };
$ gcc -c a.c && ll a.o
-rw-r--r--  1 fx  wheel    38M Dec 29 22:32 a.o

On Linux, for example, we don't get such a large object file as x is put in the
BSS section. Seems like this does not happen on darwin.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fxcoudert at gcc dot gnu dot
                   |                            |org
   Last reconfirmed|2007-10-05 12:45:37         |2009-12-29 21:34:35
               date|                            |
            Summary|Large module object files   |Data not put in BSS section
                   |when declare arrays on Mac  |on Mac OS
                   |OSX                         |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33120