[Bug fortran/33228] New: Accepts use-associated functions in MODULE PROCEDURE

[Bug fortran/33228] New: Accepts use-associated functions in MODULE PROCEDURE

[burnus at gcc dot gnu dot org]

module m
USE MOD, only: foo1
interface generic_intrf
  module procedure foo1
end interface

is accepted although "bar" is not a host-associated procedure, but a
use-associated procedure.

(Using "PROCEDURE foo1" instead of "MODULE PROCEDURE foo1" allows
use-associated procedures.)

NAG f95 correctly diagnoses:

Error: a.f90, line 13: FOO1 is not a module procedure

Full example, from:
http://groups.google.com/group/comp.lang.fortran/browse_thread/thread/4d51d6ca89f7d4f8/

MODULE a
  USE iso_c_binding
  INTERFACE
    SUBROUTINE foo1(a) BIND(C,name="a_c_routine")
      IMPORT C_INT
      INTEGER(C_INT) ::a
    END SUBROUTINE
  END INTERFACE
END MODULE
MODULE b
  USE a,ONLY : foo1
  INTERFACE foo
    MODULE procedure foo1,foo2,foo3
  END INTERFACE
  CONTAINS
  SUBROUTINE foo2(a)
    DOUBLE PRECISION ::a
  END SUBROUTINE
  SUBROUTINE foo3(a)
    CHARACTER ::a
  END SUBROUTINE
END MODULE


-- 
           Summary: Accepts use-associated functions in MODULE PROCEDURE
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: accepts-invalid
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33228

[Bug fortran/33228] Accepts use-associated functions in MODULE PROCEDURE

[burnus at gcc dot gnu dot org]

------- Comment #1 from burnus at gcc dot gnu dot org  2007-08-30 11:44 -------
I have a patch -> accept.

The standard says:

"C1208 (R1206) If MODULE appears in a procedure-stmt, each procedure-name in
that statement shall be accessible in the current scope as a module procedure."
"module procedure (2.2.3.2) : A procedure that is defined by a module
subprogram."

This means the following is correct:

module b
contains
    subroutine foo(a)
      real :: a
    end subroutine foo
end module b
module a
  use b
  implicit none
  interface gen
    module procedure foo
  end interface gen
end module a


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |burnus at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-08-30 11:44:24
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33228

[Bug fortran/33228] Accepts use-associated functions in MODULE PROCEDURE

[patchapp at dberlin dot org]

------- Comment #2 from patchapp at dberlin dot org  2007-08-30 13:05 -------
Subject: Bug number PR33228

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-08/msg02178.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33228

[Bug fortran/33228] Accepts use-associated functions in MODULE PROCEDURE

[burnus at gcc dot gnu dot org]

------- Comment #3 from burnus at gcc dot gnu dot org  2007-08-30 13:45 -------
Subject: Bug 33228

Author: burnus
Date: Thu Aug 30 13:44:47 2007
New Revision: 127925

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=127925
Log:
2007-08-30  Tobias Burnus  <burnus@net-b.de>

        PR fortran/33228
        * interface.c (check_interface0): Improve error for external procs.
        (check_sym_interfaces): Fix checking of module procedures.

2007-08-30  Tobias Burnus  <burnus@net-b.de>

        PR fortran/33228
        * gfortran.dg/generic_9.f90: Update error message.
        * gfortran.dg/generic_14.f90: New.


Added:
    trunk/gcc/testsuite/gfortran.dg/generic_14.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/interface.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/generic_9.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33228

[Bug fortran/33228] Accepts use-associated functions in MODULE PROCEDURE

[burnus at gcc dot gnu dot org]

------- Comment #4 from burnus at gcc dot gnu dot org  2007-08-30 13:47 -------
FIXED.


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33228