* [Bug middle-end/33315] If condition not getting eliminated
[not found] <bug-33315-4@http.gcc.gnu.org/bugzilla/>
@ 2012-02-04 2:34 ` pinskia at gcc dot gnu.org
2020-04-15 10:24 ` [Bug tree-optimization/33315] stores not commoned by sinking rguenth at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2012-02-04 2:34 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33315
--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-02-04 02:33:16 UTC ---
tail merge should be able to do this. It currently does not though for the
provided testcase in comment #1 but that is PR 52009.
Also note cselim should be able to do it too.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug tree-optimization/33315] stores not commoned by sinking
[not found] <bug-33315-4@http.gcc.gnu.org/bugzilla/>
2012-02-04 2:34 ` [Bug middle-end/33315] If condition not getting eliminated pinskia at gcc dot gnu.org
@ 2020-04-15 10:24 ` rguenth at gcc dot gnu.org
2020-04-15 18:17 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-04-15 10:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=33315
--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
Created attachment 48279
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48279&action=edit
patch
Patch forward ported to current trunk.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug tree-optimization/33315] stores not commoned by sinking
[not found] <bug-33315-4@http.gcc.gnu.org/bugzilla/>
2012-02-04 2:34 ` [Bug middle-end/33315] If condition not getting eliminated pinskia at gcc dot gnu.org
2020-04-15 10:24 ` [Bug tree-optimization/33315] stores not commoned by sinking rguenth at gcc dot gnu.org
@ 2020-04-15 18:17 ` rguenth at gcc dot gnu.org
2020-04-16 12:40 ` rguenth at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-04-15 18:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=33315
--- Comment #13 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #12)
> Created attachment 48279 [details]
> patch
>
> Patch forward ported to current trunk.
Surprisingly small fallout:
FAIL: gcc.dg/tree-ssa/split-path-7.c scan-tree-dump-times split-paths
"Duplicating join block" 0
I've thought the approach is too simplistic but I'll do some statistics
over bootstrap in stage1 and push it if it looks useful - we certainly
have more "hackish" optimization pieces.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug tree-optimization/33315] stores not commoned by sinking
[not found] <bug-33315-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2020-04-15 18:17 ` rguenth at gcc dot gnu.org
@ 2020-04-16 12:40 ` rguenth at gcc dot gnu.org
2020-05-15 6:56 ` cvs-commit at gcc dot gnu.org
2020-05-15 6:57 ` rguenth at gcc dot gnu.org
5 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-04-16 12:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=33315
--- Comment #14 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #13)
> (In reply to Richard Biener from comment #12)
> > Created attachment 48279 [details]
> > patch
> >
> > Patch forward ported to current trunk.
>
> Surprisingly small fallout:
>
> FAIL: gcc.dg/tree-ssa/split-path-7.c scan-tree-dump-times split-paths
> "Duplicating join block" 0
>
> I've thought the approach is too simplistic but I'll do some statistics
> over bootstrap in stage1 and push it if it looks useful - we certainly
> have more "hackish" optimization pieces.
stage3 gcc/ files show (first column is the number of edges we sink from,
second column the number of stores we sink):
2: 3195
3: 193
4: 130
5: 55
6: 28
7: 4
8: 9
9: 3
10: 3
12: 1
13: 6
16: 2
18: 1
22: 2
so it seems worth it.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug tree-optimization/33315] stores not commoned by sinking
[not found] <bug-33315-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2020-04-16 12:40 ` rguenth at gcc dot gnu.org
@ 2020-05-15 6:56 ` cvs-commit at gcc dot gnu.org
2020-05-15 6:57 ` rguenth at gcc dot gnu.org
5 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-15 6:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=33315
--- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:84935c9822183ce403bb361c5f405711b9a808c6
commit r11-408-g84935c9822183ce403bb361c5f405711b9a808c6
Author: Richard Biener <rguenther@suse.de>
Date: Wed Apr 15 12:09:01 2020 +0200
tree-optimization/33315 - common stores during sinking
This implements commoning of stores to a common successor in
a simple ad-hoc way. I've decided to put it into the code sinking
pass since, well, it sinks stores. It's still separate since
it does not really sink code into less executed places.
It's ad-hoc since it does not perform any dataflow or alias analysis
but simply only considers trailing stores in a block, iteratively
though. If the stores are from different values a PHI node is
inserted to merge them. gcc.dg/tree-ssa/split-path-7.c shows
that path splitting will eventually undo this very transform,
I've decided to not bother with it and simply disable sinking for
the particular testcase.
Doing this transform is good for code size when the stores are
from constants, once we have to insert PHIs the situation becomes
less clear but it's a transform we do elsewhere as well
(cselim for one), and reversing the transform should be easy.
2020-05-15 Richard Biener <rguenther@suse.de>
PR tree-optimization/33315
* tree-ssa-sink.c: Include tree-eh.h.
(sink_stats): Add commoned member.
(sink_common_stores_to_bb): New function implementing store
commoning by sinking to the successor.
(sink_code_in_bb): Call it, pass down TODO_cleanup_cfg returned.
(pass_sink_code::execute): Likewise. Record commoned stores
in statistics.
* gcc.dg/tree-ssa/ssa-sink-13.c: New testcase.
* gcc.dg/tree-ssa/ssa-sink-14.c: Likewise.
* gcc.dg/tree-ssa/split-path-7.c: Disable sinking.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug tree-optimization/33315] stores not commoned by sinking
[not found] <bug-33315-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2020-05-15 6:56 ` cvs-commit at gcc dot gnu.org
@ 2020-05-15 6:57 ` rguenth at gcc dot gnu.org
5 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-05-15 6:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=33315
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #16 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk. Individual missed cases should be tracked by separate
bugreports.
^ permalink raw reply [flat|nested] 6+ messages in thread