From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4418 invoked by alias); 12 Jan 2012 14:28:48 -0000 Received: (qmail 4403 invoked by uid 22791); 12 Jan 2012 14:28:47 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Jan 2012 14:28:34 +0000 From: "rguenther at suse dot de" To: gcc-bugs@gcc.gnu.org Subject: [Bug c/33763] [4.4/4.5/4.6/4.7 Regression] Bogus inlining failed in call to `xxx': redefined extern inline functions are not considered for inlining Date: Thu, 12 Jan 2012 14:28:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: c X-Bugzilla-Keywords: wrong-code X-Bugzilla-Severity: normal X-Bugzilla-Who: rguenther at suse dot de X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 4.4.7 X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2012-01/txt/msg01381.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33763 --- Comment #25 from rguenther at suse dot de 2012-01-12 14:27:12 UTC --- On Thu, 12 Jan 2012, hubicka at ucw dot cz wrote: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33763 > > --- Comment #24 from Jan Hubicka 2012-01-12 14:22:52 UTC --- > > OTOH, it is time to deprecate this extension and warn about it (after > > all we miscompile this since quite some time, GCC 3.3 and 4.1 already produce > > the recursive open - how was this intended to work? ...) I don't have > > 3.2 (and 2.95 does not have always_inline). > > pre cgraph compilers handled it in a way that inline body was kept after > parsing > extern inline version and inlined into every new parsed function until > the offline version was reached. Then the function was marked uninlinable, > offline body was produced and all subsequentely parsed calls was not inlined > (including calls in the offline body). > > I think extern inlines are sadly rather common to be deprecated... Well, not deprecating extern inlines but re-definitions in the same TU which miscompiles once the extern inline is used in that TU (ok, so you can say in 99% of all cases that won't happen). Thus, another workaround would be to avoid transitioning the attribute to the redefinition in merge_decls (under the exact same condition as we allow the redefinition). Richard.