[Bug fortran/33849] New: Fix misleading error message "GENERIC non-INTRINSIC procedure not allowed as an actual argument"

[Bug fortran/33849] New: Fix misleading error message "GENERIC non-INTRINSIC procedure not allowed as an actual argument"

[burnus at gcc dot gnu dot org]

The following error message is misleading:

"Error: GENERIC non-INTRINSIC procedure '%s' is not allowed as an actual
argument"

The problem is that any GENERIC procedure - intrinsic or not - is not allowed
as actual argument. (For "a dummy procedure[...], the associated actual
argument shall be the specific name".)
However, this problem never occurs for intrinsic procedures as all intrinsic
procedures which are allowed as actual argument (cf. 13.6) are also specific
functions. (And then applies: "If the specific name is also a generic name,
only the specific procedure is associated with the dummy argument.")

See also PR 33162 and PR 33847.

>From the Fortran 2003 standard:

"12.4.1.3 Actual arguments associated with dummy procedure entities"
[...]
"If a dummy argument is a dummy procedure without the POINTER attribute, the
associated actual argument shall be the specific name of an external, module,
dummy, or intrinsic procedure, an associated procedure pointer, or a reference
to a function that returns an associated procedure pointer. The only intrinsic
procedures permitted are those listed in 13.6 and not marked with a bullet (*).
If the specific name is also a generic name, only the specific procedure is
associated with the dummy argument."


-- 
           Summary: Fix misleading error message "GENERIC non-INTRINSIC
                    procedure not allowed as an actual argument"
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33849

[Bug fortran/33849] Fix misleading error message "GENERIC non-INTRINSIC procedure not allowed as an actual argument"

[jvdelisle at gcc dot gnu dot org]

------- Comment #1 from jvdelisle at gcc dot gnu dot org  2007-10-21 22:56 -------
Is the issue here only the wording of the error message or is the checking
incorrect as well?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33849

[Bug fortran/33849] Fix misleading error message "GENERIC non-INTRINSIC procedure not allowed as an actual argument"

[burnus at gcc dot gnu dot org]

------- Comment #2 from burnus at gcc dot gnu dot org  2007-10-22 06:22 -------
> Is the issue here only the wording of the error message
Yes, only the message text.
  "Error: GENERIC non-INTRINSIC procedure '%s' is not allowed as an actual
argument"
should be
  "Error: GENERIC procedure '%s' is not allowed as an actual argument"


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33849

Re: [Bug fortran/33849] Fix misleading error message "GENERIC non-INTRINSIC procedure not allowed as an actual argument"

[Jerry DeLisle]

burnus at gcc dot gnu dot org wrote:
> ------- Comment #2 from burnus at gcc dot gnu dot org  2007-10-22 06:22 -------
>> Is the issue here only the wording of the error message
> Yes, only the message text.
>   "Error: GENERIC non-INTRINSIC procedure '%s' is not allowed as an actual
> argument"
> should be
>   "Error: GENERIC procedure '%s' is not allowed as an actual argument"
> 
> 
I will take care of it.

[Bug fortran/33849] Fix misleading error message "GENERIC non-INTRINSIC procedure not allowed as an actual argument"

[jvdelisle at verizon dot net]

------- Comment #3 from jvdelisle at verizon dot net  2007-10-22 14:25 -------
Subject: Re:  Fix misleading error message
 "GENERIC non-INTRINSIC procedure not allowed as an actual argument"

burnus at gcc dot gnu dot org wrote:
> ------- Comment #2 from burnus at gcc dot gnu dot org  2007-10-22 06:22 -------
>> Is the issue here only the wording of the error message
> Yes, only the message text.
>   "Error: GENERIC non-INTRINSIC procedure '%s' is not allowed as an actual
> argument"
> should be
>   "Error: GENERIC procedure '%s' is not allowed as an actual argument"
> 
> 
I will take care of it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33849

[Bug fortran/33849] Fix misleading error message "GENERIC non-INTRINSIC procedure not allowed as an actual argument"

[jvdelisle at gcc dot gnu dot org]

------- Comment #4 from jvdelisle at gcc dot gnu dot org  2007-10-22 23:08 -------
Subject: Bug 33849

Author: jvdelisle
Date: Mon Oct 22 23:08:16 2007
New Revision: 129564

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129564
Log:
2007-10-22  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/33849
        * resolve.c (resolve_actual_arglist): Fix error message text.

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/resolve.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33849

[Bug fortran/33849] Fix misleading error message "GENERIC non-INTRINSIC procedure not allowed as an actual argument"

[jvdelisle at gcc dot gnu dot org]

------- Comment #5 from jvdelisle at gcc dot gnu dot org  2007-10-22 23:09 -------
Fixed


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33849

[Bug fortran/33849] Fix misleading error message "GENERIC non-INTRINSIC procedure not allowed as an actual argument"

[dominiq at lps dot ens dot fr]

------- Comment #6 from dominiq at lps dot ens dot fr  2007-10-23 17:42 -------
The test case generic_actual_arg.f90 fails because the "dg-error" has not been
adjusted:

/opt/gcc/_gcc-clean/gcc/testsuite/gfortran.dg/generic_actual_arg.f90:21.7:

CALL F(CALCULATION) ! { dg-error "GENERIC non-INTRINSIC procedure" } 
      1
Error: GENERIC procedure 'calculation' is not allowed as an actual argument at
(1)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33849

[Bug fortran/33849] Fix misleading error message "GENERIC non-INTRINSIC procedure not allowed as an actual argument"

[burnus at gcc dot gnu dot org]

------- Comment #7 from burnus at gcc dot gnu dot org  2007-10-23 21:57 -------
(In reply to comment #6)
> The test case generic_actual_arg.f90 fails because the "dg-error" has not been
> adjusted:
> /opt/gcc/_gcc-clean/gcc/testsuite/gfortran.dg/generic_actual_arg.f90:21.7:
> CALL F(CALCULATION) ! { dg-error "GENERIC non-INTRINSIC procedure" } 
>       1
> Error: GENERIC procedure 'calculation' is not allowed as an actual argument at
> (1)

Regression testing sometimes helps ;-)

I will fix this unless Jerry beats me.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33849

[Bug fortran/33849] Fix misleading error message "GENERIC non-INTRINSIC procedure not allowed as an actual argument"

[jvdelisle at gcc dot gnu dot org]

------- Comment #8 from jvdelisle at gcc dot gnu dot org  2007-10-24 03:29 -------
Yes, regression tests help, I forgot to fix the testcase


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33849

[Bug fortran/33849] Fix misleading error message "GENERIC non-INTRINSIC procedure not allowed as an actual argument"

[jvdelisle at gcc dot gnu dot org]

------- Comment #9 from jvdelisle at gcc dot gnu dot org  2007-10-24 03:39 -------
Subject: Bug 33849

Author: jvdelisle
Date: Wed Oct 24 03:39:03 2007
New Revision: 129595

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129595
Log:
2007-10-23  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR forrtran/33849
        gfortran.dg/generic_actual_arg.f90: Fix dg-error message.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/generic_actual_arg.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33849