[Bug fortran/34186] New: dump-parse-tree: ICE for ts->cl->length, if ts->cl == NULL

[Bug fortran/34186] New: dump-parse-tree: ICE for ts->cl->length, if ts->cl == NULL

[burnus at gcc dot gnu dot org]

gfortran -fdump-parse-tree crashes for the following program as
ts->cl == NULL for dump-parse-tree.c's gfc_show_typespec

    case BT_CHARACTER:
      gfc_show_expr (ts->cl->length);
      break;

After disabling the gfc_show_expr if ts->cl == NULL, there is an internal error
shown unless one adds:

--- misc.c      (revision 130347)
+++ misc.c      (working copy)
@@ -141,0 +142,3 @@ gfc_basic_typename (bt type)
+    case BT_VOID:
+      p = "VOID";
+      break;

Additionally, we need to check for missing attributes etc. in the dumps, which
were not added for BIND(C); e.g. the following is missing:

--- dump-parse-tree.c   (revision 130347)
+++ dump-parse-tree.c   (working copy)
@@ -584,0 +588,2 @@ gfc_show_attr (symbol_attribute *attr)
+  if (attr->is_bind_c)
+    gfc_status (" BIND(C)");


Test case:

function func0(x) result(result_func0) bind(c)
  use, intrinsic :: iso_c_binding
  real(c_double) :: result_func0
  real(c_double), value, intent(in) :: x
  result_func0 = 1.0_c_double
end function func0


-- 
           Summary: dump-parse-tree: ICE for ts->cl->length, if ts->cl ==
                    NULL
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34186

[Bug fortran/34186] dump-parse-tree: ICE for ts->cl->length, if ts->cl == NULL

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-11-29 11:24:43
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34186

[Bug fortran/34186] dump-parse-tree: ICE for ts->cl->length, if ts->cl == NULL

[burnus at gcc dot gnu dot org]

------- Comment #2 from burnus at gcc dot gnu dot org  2007-11-30 09:32 -------
Subject: Bug 34186

Author: burnus
Date: Fri Nov 30 09:31:56 2007
New Revision: 130534

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=130534
Log:
2007-11-30  Tobias Burnus  <burnus@net-b.de>

        PR fortran/34186
        * symbol.c (generate_isocbinding_symbol): Set string length.
        * dump-parse-tree.c (gfc_show_attr): Show BIND(C) attribute.
        * misc.c (gfc_basic_typename): Handle BT_VOID.


Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/dump-parse-tree.c
    trunk/gcc/fortran/misc.c
    trunk/gcc/fortran/symbol.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34186

[Bug fortran/34186] dump-parse-tree: ICE for ts->cl->length, if ts->cl == NULL

[burnus at gcc dot gnu dot org]

------- Comment #1 from burnus at gcc dot gnu dot org  2007-11-30 09:32 -------
FIXED on the trunk (4.3.0); 4.2.x and 4.1.x should be unaffected as the crash
seems to be due to C Binding changes.


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34186

[Bug fortran/34186] dump-parse-tree: ICE for ts->cl->length, if ts->cl == NULL

[burnus at gcc dot gnu dot org]

------- Comment #3 from burnus at gcc dot gnu dot org  2007-12-02 14:24 -------
Subject: Bug 34186

Author: burnus
Date: Sun Dec  2 14:23:48 2007
New Revision: 130569

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=130569
Log:
2007-12-02  Tobias Burnus  <burnus@net-b.de>

        PR fortran/34186
        * symbol.c (generate_isocbinding_symbol): Fix setting string
        length.


Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/symbol.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34186