public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/34265] Missed optimizations
Date: Sun, 22 May 2011 12:33:00 -0000	[thread overview]
Message-ID: <bug-34265-4-f8UcYWdme4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-34265-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34265

--- Comment #34 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2011-05-22 12:06:20 UTC ---
Created attachment 24325
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24325
reduced tests

The attached bzipped tar contains the files induct_red.f90 with the all the
infrastructure to provide a realistic framework to run a reduced version of
the subroutine mutual_ind_quad_cir_coil contained in induct_qc_x.F90
(reduced to only one critical nested loops).

When the macro XPA is defined the original rotate code

          rot_q_vector(1) = dot_product(rotate_quad(1,:),q_vector(:))
          rot_q_vector(2) = dot_product(rotate_quad(2,:),q_vector(:))
          rot_q_vector(3) = dot_product(rotate_quad(3,:),q_vector(:))

is unrolled as (q_vector(2)==0) if the macro FLD is not defined

          rot_q_vector(1) = rotate_quad(1,1) * q_vector(1) + &
                    rotate_quad(1,2) * q_vector(2)
          rot_q_vector(2) = rotate_quad(2,1) * q_vector(1) + &
                    rotate_quad(2,2) * q_vector(2)
          rot_q_vector(3) = rotate_quad(3,1) * q_vector(1) + &
                    rotate_quad(3,2) * q_vector(2)

Otherwise it is folded as

          rot_q_vector(:) = rotate_quad(:,1) * q_vector(1) + &
                    rotate_quad(:,2) * q_vector(2)

When the macro XPB is defined the original numerator

          numerator = w1gauss(j) * w2gauss(k) *               &
                  dot_product(coil_current_vec,current_vector)

is unrolled as

          numerator = w1gauss(j) * w2gauss(k) *               &
                 (coil_current_vec(1)*current_vector(1) + &
                  coil_current_vec(2)*current_vector(2) + &
                  coil_current_vec(3)*current_vector(3))

When the macro XPC is defined the original denominator

          denominator = sqrt(dot_product(rot_c_vector-rot_q_vector, &
                         rot_c_vector-rot_q_vector))

is unrolled as
          denominator = sqrt((rot_c_vector(1)-rot_q_vector(1))**2 + &
                     (rot_c_vector(2)-rot_q_vector(2))**2 + &
                     (rot_c_vector(3)-rot_q_vector(3))**2)


It contains also a script to run the twelve cases and one case with
graphite and the raw results for revisions 167530, 167531, and 173917
(original, with r167531 reverted: 173917r1, and with /* NEXT_PASS
(pass_complete_unrolli); */ : 173917n since I think this is related to
revision 134730).

See also pr49006.


       reply	other threads:[~2011-05-22 12:23 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-34265-4@http.gcc.gnu.org/bugzilla/>
2011-05-22 12:33 ` dominiq at lps dot ens.fr [this message]
2011-09-16 15:53 ` dominiq at lps dot ens.fr
2011-09-17 17:53 ` dominiq at lps dot ens.fr
2011-09-26  9:02 ` rguenth at gcc dot gnu.org
2007-11-28 15:27 [Bug tree-optimization/34265] New: " dominiq at lps dot ens dot fr
2007-11-28 15:30 ` [Bug tree-optimization/34265] " dominiq at lps dot ens dot fr
2007-11-28 16:06 ` rguenth at gcc dot gnu dot org
2007-11-28 16:14 ` dominiq at lps dot ens dot fr
2007-11-28 16:18 ` rguenth at gcc dot gnu dot org
2007-11-28 16:34 ` rguenth at gcc dot gnu dot org
2007-11-28 18:18 ` dominiq at lps dot ens dot fr
2007-11-28 18:49 ` dominiq at lps dot ens dot fr
2007-11-28 20:48 ` jb at gcc dot gnu dot org
2007-11-28 21:27 ` burnus at gcc dot gnu dot org
2007-11-28 22:05 ` rguenth at gcc dot gnu dot org
2007-11-28 22:36 ` dominiq at lps dot ens dot fr
2007-11-28 22:49 ` steven at gcc dot gnu dot org
2007-11-28 23:07 ` kargl at gcc dot gnu dot org
2007-11-28 23:18 ` steven at gcc dot gnu dot org
2007-11-28 23:57 ` dominiq at lps dot ens dot fr
2007-11-29  8:06 ` dominiq at lps dot ens dot fr
2007-11-29 10:12 ` rguenth at gcc dot gnu dot org
2007-11-29 10:22 ` dominiq at lps dot ens dot fr
2007-11-29 10:40 ` dominiq at lps dot ens dot fr
2007-11-29 11:01 ` dominiq at lps dot ens dot fr
2007-11-29 11:13 ` rguenther at suse dot de
2007-11-29 11:16 ` dominiq at lps dot ens dot fr
2007-11-29 12:25 ` dominiq at lps dot ens dot fr
2007-11-29 15:49 ` dominiq at lps dot ens dot fr
2007-11-30 21:38 ` ubizjak at gmail dot com
2007-12-03 14:08 ` dominiq at lps dot ens dot fr
2007-12-03 14:32 ` dominiq at lps dot ens dot fr
2007-12-03 14:34 ` dominiq at lps dot ens dot fr
2007-12-03 14:34 ` dominiq at lps dot ens dot fr
2007-12-03 16:30 ` ubizjak at gmail dot com
2007-12-03 18:59 ` dominiq at lps dot ens dot fr
2007-12-04  6:57 ` irar at il dot ibm dot com
2008-04-23 21:27 ` dominiq at lps dot ens dot fr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-34265-4-f8UcYWdme4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).