[Bug libfortran/34323] New: formatted stream ignores advance="no"

[Bug libfortran/34323] New: formatted stream ignores advance="no"

[tkoenig at gcc dot gnu dot org]

program main
  open(99,form="formatted",access="stream")
  write (99,'(A)',advance="no") 'a'
  write (99,'(A)',advance="no") 'b'
  close (99)
end program main

should write a single line to file 99, with
the contents
ab

Right now, it writes
a
b


-- 
           Summary: formatted stream ignores advance="no"
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tkoenig at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34323

[Bug libfortran/34323] formatted stream ignores advance="no"

[tkoenig at gcc dot gnu dot org]

-- 

tkoenig at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tkoenig at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-12-03 07:29:54
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34323

[Bug libfortran/34323] formatted stream ignores advance="no"

[jvdelisle at gcc dot gnu dot org]

------- Comment #1 from jvdelisle at gcc dot gnu dot org  2007-12-04 07:30 -------
hint: I think bytes_written needs to be calculated slightly differently so that
the CR/LF is added at the end when the file is closed in close.c (close_unit_1)

stream POS specifiers are base 1 and RECL is base 0.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34323

[Bug libfortran/34323] formatted stream ignores advance="no"

[tkoenig at gcc dot gnu dot org]

------- Comment #2 from tkoenig at gcc dot gnu dot org  2007-12-13 19:35 -------
Subject: Bug 34323

Author: tkoenig
Date: Thu Dec 13 19:35:09 2007
New Revision: 130912

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=130912
Log:
2007-12-13  Thomas Koenig  <tkoenig@gcc.gnu.org>

        PR libfortran/34370
        PR libfortran/34323
        PR libfortran/34405
        * io/io.h:  Add previous_nonadvancing_write to gfc_unit.
        Add prototype for finish_last_advance_record.
        * io/file_pos.c (st_backspace):  Generate error if backspace is
        attempted for direct access or unformatted stream.
        If there are bytes left from a previous ADVANCE="no", write
        them out before performing the backspace.
        (st_endfile):  Generate error if endfile is attempted for
        direct access.
        If there are bytes left from a previous ADVANCE="no", write
        them out before performing the endfile.
        (st_rewind):  Generate error if rewind is attempted for
        direct access.
        * unit.c (close_unit_1):  Move functionality to write
        previously written bytes to...
        (finish_last_advance_record):  ... here.
        * transfer.c (data_transfer_init):  If reading, reset
        previous_nonadvancing_write.
        (finalize_transfer):  Set the previous_noadvancing_write
        flag if we are writing and ADVANCE="no" was specified.
        Only call next_record() if advance="no" wasn't specified.

2007-12-13  Thomas Koenig  <tkoenig@gcc.gnu.org>

        PR libfortran/34370
        PR libfortran/34323
        PR libfortran/34405
        * gfortran.dg/advance_6.f90:  New test case.
        * gfortran.dg/direct_io_7.f90:  New test case.
        * gfortran.dg/streamio_13.f90:  New test case.


Added:
    trunk/gcc/testsuite/gfortran.dg/advance_6.f90
    trunk/gcc/testsuite/gfortran.dg/direct_io_7.f90
    trunk/gcc/testsuite/gfortran.dg/streamio_13.f90
Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/file_pos.c
    trunk/libgfortran/io/io.h
    trunk/libgfortran/io/transfer.c
    trunk/libgfortran/io/unit.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34323

[Bug libfortran/34323] formatted stream ignores advance="no"

[tkoenig at gcc dot gnu dot org]

------- Comment #3 from tkoenig at gcc dot gnu dot org  2007-12-13 19:40 -------
Fixed on trunk.   Closing.


-- 

tkoenig at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34323