public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug middle-end/34548] GCC generates too many alignment adds for alloca [not found] <bug-34548-4@http.gcc.gnu.org/bugzilla/> @ 2012-07-27 18:14 ` rth at gcc dot gnu.org 2012-07-30 9:34 ` ebotcazou at gcc dot gnu.org ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: rth at gcc dot gnu.org @ 2012-07-27 18:14 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34548 Richard Henderson <rth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED Last reconfirmed| |2012-07-27 CC| |rth at gcc dot gnu.org AssignedTo|unassigned at gcc dot |rth at gcc dot gnu.org |gnu.org | Ever Confirmed|0 |1 --- Comment #2 from Richard Henderson <rth at gcc dot gnu.org> 2012-07-27 18:14:12 UTC --- I'll take a stab. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug middle-end/34548] GCC generates too many alignment adds for alloca [not found] <bug-34548-4@http.gcc.gnu.org/bugzilla/> 2012-07-27 18:14 ` [Bug middle-end/34548] GCC generates too many alignment adds for alloca rth at gcc dot gnu.org @ 2012-07-30 9:34 ` ebotcazou at gcc dot gnu.org 2012-07-30 9:35 ` ebotcazou at gcc dot gnu.org ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: ebotcazou at gcc dot gnu.org @ 2012-07-30 9:34 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34548 Eric Botcazou <ebotcazou at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ebotcazou at gcc dot | |gnu.org --- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-07-30 09:33:36 UTC --- *** Bug 47353 has been marked as a duplicate of this bug. *** ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug middle-end/34548] GCC generates too many alignment adds for alloca [not found] <bug-34548-4@http.gcc.gnu.org/bugzilla/> 2012-07-27 18:14 ` [Bug middle-end/34548] GCC generates too many alignment adds for alloca rth at gcc dot gnu.org 2012-07-30 9:34 ` ebotcazou at gcc dot gnu.org @ 2012-07-30 9:35 ` ebotcazou at gcc dot gnu.org 2012-08-01 20:41 ` rth at gcc dot gnu.org 2012-11-29 21:21 ` rth at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: ebotcazou at gcc dot gnu.org @ 2012-07-30 9:35 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34548 Eric Botcazou <ebotcazou at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ebotcazou at gcc dot | |gnu.org --- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-07-30 09:33:36 UTC --- *** Bug 47353 has been marked as a duplicate of this bug. *** --- Comment #4 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-07-30 09:35:16 UTC --- Possibly useful link: http://gcc.gnu.org/ml/gcc-patches/2011-01/msg00842.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug middle-end/34548] GCC generates too many alignment adds for alloca [not found] <bug-34548-4@http.gcc.gnu.org/bugzilla/> ` (2 preceding siblings ...) 2012-07-30 9:35 ` ebotcazou at gcc dot gnu.org @ 2012-08-01 20:41 ` rth at gcc dot gnu.org 2012-11-29 21:21 ` rth at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: rth at gcc dot gnu.org @ 2012-08-01 20:41 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34548 --- Comment #5 from Richard Henderson <rth at gcc dot gnu.org> 2012-08-01 20:41:25 UTC --- Author: rth Date: Wed Aug 1 20:41:16 2012 New Revision: 190051 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190051 Log: PR 34548 * function.h (struct rtl_data): Add max_dynamic_stack_alignment. * cfgexpand.c (gimple_expand_cfg): Initialise it. * explow.c (allocate_dynamic_stack_space): Set it. Simplify alignment requirements given the known alignment of dynamic_offset. * function.c (instantiate_virtual_regs): Align dtnamic_offset. Modified: trunk/gcc/ChangeLog trunk/gcc/cfgexpand.c trunk/gcc/explow.c trunk/gcc/function.c trunk/gcc/function.h ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug middle-end/34548] GCC generates too many alignment adds for alloca [not found] <bug-34548-4@http.gcc.gnu.org/bugzilla/> ` (3 preceding siblings ...) 2012-08-01 20:41 ` rth at gcc dot gnu.org @ 2012-11-29 21:21 ` rth at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: rth at gcc dot gnu.org @ 2012-11-29 21:21 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34548 Richard Henderson <rth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #6 from Richard Henderson <rth at gcc dot gnu.org> 2012-11-29 21:20:23 UTC --- Fixed. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug regression/34548] New: GCC generates too many alignment adds for alloca
@ 2007-12-21 17:20 aoliva at gcc dot gnu dot org
2008-07-04 23:54 ` [Bug middle-end/34548] " jsm28 at gcc dot gnu dot org
0 siblings, 1 reply; 6+ messages in thread
From: aoliva at gcc dot gnu dot org @ 2007-12-21 17:20 UTC (permalink / raw)
To: gcc-bugs
WRT http://gbenson.livejournal.com/2007/12/21/
GCC is being overzealous because of a default that was local to one file was
made global on 2003-10-07, and this changed the behavior of the #if statement
in explow.c's allocate_dynamic_stack_space():
#if defined (STACK_DYNAMIC_OFFSET) || defined (STACK_POINTER_OFFSET)
#define MUST_ALIGN 1
#else
#define MUST_ALIGN (PREFERRED_STACK_BOUNDARY < BIGGEST_ALIGNMENT)
#endif
Unfortunately, STACK_POINTER_OFFSET isn't a preprocessor constant on all ports.
We could change the above to:
#if defined (STACK_DYNAMIC_OFFSET)
#define MUST_ALIGN 1
#else
#define MUST_ALIGN (STACK_POINTER_OFFSET || PREFERRED_STACK_BOUNDARY <
BIGGEST_ALIGNMENT)
#endif
but on at least one port (pa), STACK_POINTER_OFFSET depends on the size of the
outgoing arguments of a function, which we don't necessarily know yet at the
point we expand alloca builtins. For pa, it's never zero, but for other ports
it might be, and then this would break.
BTW, function.c still provides a no-longer-necessary default for
STACK_POINTER_OFFSET.
--
Summary: GCC generates too many alignment adds for alloca
Product: gcc
Version: 4.3.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: regression
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: aoliva at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34548
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug middle-end/34548] GCC generates too many alignment adds for alloca 2007-12-21 17:20 [Bug regression/34548] New: " aoliva at gcc dot gnu dot org @ 2008-07-04 23:54 ` jsm28 at gcc dot gnu dot org 0 siblings, 0 replies; 6+ messages in thread From: jsm28 at gcc dot gnu dot org @ 2008-07-04 23:54 UTC (permalink / raw) To: gcc-bugs ------- Comment #1 from jsm28 at gcc dot gnu dot org 2008-07-04 23:53 ------- If this is a regression, please mark it as such in the summary and milestone. "regression" component is for automatic reports of testsuite regressions from automatic testers (to be classified manually afterwards). -- jsm28 at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Component|regression |middle-end http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34548 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-11-29 21:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-34548-4@http.gcc.gnu.org/bugzilla/>
2012-07-27 18:14 ` [Bug middle-end/34548] GCC generates too many alignment adds for alloca rth at gcc dot gnu.org
2012-07-30 9:34 ` ebotcazou at gcc dot gnu.org
2012-07-30 9:35 ` ebotcazou at gcc dot gnu.org
2012-08-01 20:41 ` rth at gcc dot gnu.org
2012-11-29 21:21 ` rth at gcc dot gnu.org
2007-12-21 17:20 [Bug regression/34548] New: " aoliva at gcc dot gnu dot org
2008-07-04 23:54 ` [Bug middle-end/34548] " jsm28 at gcc dot gnu dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).