public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/34566] New: 4.3 Regression: Matmul of logical values
@ 2007-12-23 11:40 burnus at gcc dot gnu dot org
2007-12-23 13:06 ` [Bug fortran/34566] " tkoenig at gcc dot gnu dot org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-12-23 11:40 UTC (permalink / raw)
To: gcc-bugs
And another bug found via the test suite. It works with 4.1.3 and 4.2.2, but
with gfortran the result array is .FALSE.; however, result(1,3) shall be .TRUE.
program m
implicit none
logical, dimension (3, 3) :: &
p = &
reshape ( (/.false.,.false.,.false., &
.true., .false.,.false., &
.false.,.true., .false. /), &
(/ 3, 3/) )
logical, dimension(3,3) :: result
result = matmul(p,p)
write(*,*) matmul(p,p)
if(any(result(2:3,:))) stop 'ERROR 1'
if(any(result(1,1:2))) stop 'ERROR 2'
if(.not.result(1,3)) stop 'ERROR 3'
end program m
--
Summary: 4.3 Regression: Matmul of logical values
Product: gcc
Version: 4.3.0
Status: UNCONFIRMED
Keywords: wrong-code
Severity: normal
Priority: P3
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: burnus at gcc dot gnu dot org
OtherBugsDependingO 32834
nThis:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34566
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug fortran/34566] 4.3 Regression: Matmul of logical values
2007-12-23 11:40 [Bug fortran/34566] New: 4.3 Regression: Matmul of logical values burnus at gcc dot gnu dot org
@ 2007-12-23 13:06 ` tkoenig at gcc dot gnu dot org
2007-12-23 13:08 ` tkoenig at gcc dot gnu dot org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-12-23 13:06 UTC (permalink / raw)
To: gcc-bugs
--
tkoenig at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2007-12-23 13:06:24
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34566
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug fortran/34566] 4.3 Regression: Matmul of logical values
2007-12-23 11:40 [Bug fortran/34566] New: 4.3 Regression: Matmul of logical values burnus at gcc dot gnu dot org
2007-12-23 13:06 ` [Bug fortran/34566] " tkoenig at gcc dot gnu dot org
@ 2007-12-23 13:08 ` tkoenig at gcc dot gnu dot org
2007-12-23 13:26 ` tkoenig at gcc dot gnu dot org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-12-23 13:08 UTC (permalink / raw)
To: gcc-bugs
--
tkoenig at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |critical
Priority|P3 |P2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34566
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug fortran/34566] 4.3 Regression: Matmul of logical values
2007-12-23 11:40 [Bug fortran/34566] New: 4.3 Regression: Matmul of logical values burnus at gcc dot gnu dot org
2007-12-23 13:06 ` [Bug fortran/34566] " tkoenig at gcc dot gnu dot org
2007-12-23 13:08 ` tkoenig at gcc dot gnu dot org
@ 2007-12-23 13:26 ` tkoenig at gcc dot gnu dot org
2007-12-23 17:56 ` [Bug fortran/34566] [4.3 Regression] " pinskia at gcc dot gnu dot org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-12-23 13:26 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from tkoenig at gcc dot gnu dot org 2007-12-23 13:25 -------
I probably broke this, and I think I know how to
put this right.
--
tkoenig at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |tkoenig at gcc dot gnu dot
|dot org |org
Status|NEW |ASSIGNED
Last reconfirmed|2007-12-23 13:06:24 |2007-12-23 13:25:54
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34566
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug fortran/34566] [4.3 Regression] Matmul of logical values
2007-12-23 11:40 [Bug fortran/34566] New: 4.3 Regression: Matmul of logical values burnus at gcc dot gnu dot org
` (2 preceding siblings ...)
2007-12-23 13:26 ` tkoenig at gcc dot gnu dot org
@ 2007-12-23 17:56 ` pinskia at gcc dot gnu dot org
2007-12-23 21:48 ` tkoenig at gcc dot gnu dot org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-12-23 17:56 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from pinskia at gcc dot gnu dot org 2007-12-23 17:56 -------
Only the RM can change the priority.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pinskia at gcc dot gnu dot
| |org
Priority|P2 |P3
Summary|4.3 Regression: Matmul of |[4.3 Regression] Matmul of
|logical values |logical values
Target Milestone|--- |4.3.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34566
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug fortran/34566] [4.3 Regression] Matmul of logical values
2007-12-23 11:40 [Bug fortran/34566] New: 4.3 Regression: Matmul of logical values burnus at gcc dot gnu dot org
` (3 preceding siblings ...)
2007-12-23 17:56 ` [Bug fortran/34566] [4.3 Regression] " pinskia at gcc dot gnu dot org
@ 2007-12-23 21:48 ` tkoenig at gcc dot gnu dot org
2007-12-25 10:13 ` tkoenig at gcc dot gnu dot org
2007-12-25 10:14 ` tkoenig at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-12-23 21:48 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from tkoenig at gcc dot gnu dot org 2007-12-23 21:48 -------
Here's a patch.
$ svn diff
Index: matmull.m4
===================================================================
--- matmull.m4 (revision 131146)
+++ matmull.m4 (working copy)
@@ -154,7 +154,7 @@ sinclude(`matmul_asm_'rtype_code`.m4')dn
{
astride = a->dim[1].stride * a_kind;
count = a->dim[1].ubound + 1 - a->dim[1].lbound;
- xstride = a->dim[0].stride;
+ xstride = a->dim[0].stride * a_kind;
xcount = a->dim[0].ubound + 1 - a->dim[0].lbound;
}
if (GFC_DESCRIPTOR_RANK (b) == 1)
@@ -169,7 +169,7 @@ sinclude(`matmul_asm_'rtype_code`.m4')dn
{
bstride = b->dim[0].stride * b_kind;
assert(count == b->dim[0].ubound + 1 - b->dim[0].lbound);
- ystride = b->dim[1].stride;
+ ystride = b->dim[1].stride * b_kind;
ycount = b->dim[1].ubound + 1 - b->dim[1].lbound;
}
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34566
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug fortran/34566] [4.3 Regression] Matmul of logical values
2007-12-23 11:40 [Bug fortran/34566] New: 4.3 Regression: Matmul of logical values burnus at gcc dot gnu dot org
` (4 preceding siblings ...)
2007-12-23 21:48 ` tkoenig at gcc dot gnu dot org
@ 2007-12-25 10:13 ` tkoenig at gcc dot gnu dot org
2007-12-25 10:14 ` tkoenig at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-12-25 10:13 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from tkoenig at gcc dot gnu dot org 2007-12-25 10:13 -------
Subject: Bug 34566
Author: tkoenig
Date: Tue Dec 25 10:12:41 2007
New Revision: 131167
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131167
Log:
2007-12-25 Thomas Koenig <tkoenig@gcc.gnu.org>
PR libfortran/34566
* m4/matmull.m4: Multiply xstride and ystride by correct kind.
* generated/matmul_l4.c: Regenerated.
* generated/matmul_l8.c: Regenerated.
* generated/matmul_l16.c: Regenerated.
2007-12-25 Thomas Koenig <tkoenig@gcc.gnu.org>
PR libfortran/34566
* gfortran.dg/matmul_6.f90: New test.
Added:
trunk/gcc/testsuite/gfortran.dg/matmul_6.f90
Modified:
trunk/gcc/testsuite/ChangeLog
trunk/libgfortran/ChangeLog
trunk/libgfortran/generated/matmul_l16.c
trunk/libgfortran/generated/matmul_l4.c
trunk/libgfortran/generated/matmul_l8.c
trunk/libgfortran/m4/matmull.m4
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34566
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug fortran/34566] [4.3 Regression] Matmul of logical values
2007-12-23 11:40 [Bug fortran/34566] New: 4.3 Regression: Matmul of logical values burnus at gcc dot gnu dot org
` (5 preceding siblings ...)
2007-12-25 10:13 ` tkoenig at gcc dot gnu dot org
@ 2007-12-25 10:14 ` tkoenig at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-12-25 10:14 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from tkoenig at gcc dot gnu dot org 2007-12-25 10:13 -------
Fixed.
--
tkoenig at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34566
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2007-12-25 10:14 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-23 11:40 [Bug fortran/34566] New: 4.3 Regression: Matmul of logical values burnus at gcc dot gnu dot org
2007-12-23 13:06 ` [Bug fortran/34566] " tkoenig at gcc dot gnu dot org
2007-12-23 13:08 ` tkoenig at gcc dot gnu dot org
2007-12-23 13:26 ` tkoenig at gcc dot gnu dot org
2007-12-23 17:56 ` [Bug fortran/34566] [4.3 Regression] " pinskia at gcc dot gnu dot org
2007-12-23 21:48 ` tkoenig at gcc dot gnu dot org
2007-12-25 10:13 ` tkoenig at gcc dot gnu dot org
2007-12-25 10:14 ` tkoenig at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).