[Bug target/34571] [4.3 Regression] Segfault in alpha_expand_mov at -O3

[Bug target/34571] [4.3 Regression] Segfault in alpha_expand_mov at -O3

[tbm at cyrius dot com]

------- Comment #1 from tbm at cyrius dot com  2007-12-24 12:53 -------
Program received signal SIGSEGV, Segmentation fault.
alpha_expand_mov (mode=DImode, operands=0x11f427310)
    at gcc/config/alpha/alpha.c:2158
2158          emit_move_insn (operands[0], XEXP (operands[1], 0));
(gdb) where
#0  alpha_expand_mov (mode=DImode, operands=0x11f427310)
    at gcc/config/alpha/alpha.c:2158
#1  0x00000001205deb18 in gen_movdi (operand0=0x20000a3d660,
operand1=0x20000982910)
    at gcc/config/alpha/alpha.md:5704
#2  0x00000001201b0084 in emit_move_insn_1 (x=0x20000a3d660, y=0x20000982910)
    at gcc/expr.c:3316
#3  0x00000001202a17a0 in gen_move_insn (x=0x20000a3d660, y=0x20000982910)
    at gcc/optabs.c:4996
#4  0x00000001202fea94 in gen_reload (out=0x20000a3d660, in=0x20000982910,
opnum=1,
    type=RELOAD_FOR_OPERAND_ADDRESS) at gcc/reload1.c:8048
#5  0x00000001203015ec in emit_reload_insns (chain=0x120b3c470)
    at gcc/reload1.c:6995
#6  0x0000000120309da0 in reload (first=0x20000575300, global=1)
    at gcc/reload1.c:4137
#7  0x000000012064ecb0 in rest_of_handle_global_alloc () at gcc/global.c:631
#8  0x00000001202b35b0 in execute_one_pass (pass=0x12083bf78)
    at gcc/passes.c:1118
#9  0x00000001202b3858 in execute_pass_list (pass=0x12083bf78)
    at gcc/passes.c:1171
#10 0x00000001202b386c in execute_pass_list (pass=0x1208386d8)
    at gcc/passes.c:1172
#11 0x00000001203b9b94 in tree_rest_of_compilation (fndecl=0x200007c0750)
    at gcc/tree-optimize.c:404
#12 0x000000012058551c in cgraph_expand_function (node=0x20000796a00)
    at gcc/cgraphunit.c:1151
#13 0x0000000120588b38 in cgraph_optimize () at gcc/cgraphunit.c:1214
#14 0x000000012001a8f4 in c_write_global_declarations () at gcc/c-decl.c:8077
#15 0x000000012034bb9c in toplev_main (argc=<value optimized out>, argv=<value
optimized out>)
    at gcc/toplev.c:1055
#16 0x00000001200a2898 in main (argc=9971984, argv=0x20000982910)
    at gcc/main.c:35
(gdb)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] New: [4.3 Regression] Segfault in alpha_expand_mov at -O3

[tbm at cyrius dot com]

With 4.3 I get:

(sid)tbm@lima:~$ /usr/lib/gcc-snapshot/bin/gcc -O3 r-base-deriv.i
deriv.c: In function 'simplify':
deriv.c:258: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.


-- 
           Summary: [4.3 Regression] Segfault in alpha_expand_mov at -O3
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tbm at cyrius dot com
GCC target triplet: alpha-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3 Regression] Segfault in alpha_expand_mov at -O3

[tbm at cyrius dot com]

------- Comment #2 from tbm at cyrius dot com  2007-12-24 12:54 -------
Created an attachment (id=14818)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14818&action=view)
preprocessed source


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3 Regression] Segfault in alpha_expand_mov at -O3

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
           Keywords|                            |ice-on-valid-code
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3 Regression] Segfault in alpha_expand_mov at -O3

[rask at gcc dot gnu dot org]

------- Comment #3 from rask at gcc dot gnu dot org  2007-12-26 17:25 -------
Created an attachment (id=14832)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14832&action=view)
patch v1

(gdb) frame 1
#1  0x000000000096e248 in gen_movdi (operand0=0x2ac241e195e0,
operand1=0x2ac241de1a10) at /n/12/rask/src/all/gcc/config/alpha/alpha.md:5704
(gdb) call debug_rtx(operand0)
(reg:DI 2 $2)
(gdb) call debug_rtx(operand1)
(const:DI (plus:DI (label_ref:DI 70)
        (const_int 24 [0x18])))

In alpha_expand_mov(), we end up calling force_const_mem() because this is not
a valid symbolic operand, but alpha_cannot_force_const_mem() thinks it is, so
we end up with NULL_RTX and a segfault. Additionally there is a subtle little
bug in varasm.c.
Martin, please try this patch. Also please bootstrap and test it for
regressions if you have the time, because I don't have any Alpha hardware to do
so myself.


-- 

rask at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rask at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3 Regression] Segfault in alpha_expand_mov at -O3

[tbm at cyrius dot com]

------- Comment #4 from tbm at cyrius dot com  2007-12-28 18:33 -------
Thanks, I started a bootstrap. This may take a few days.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3 Regression] Segfault in alpha_expand_mov at -O3

[tbm at cyrius dot com]

------- Comment #5 from tbm at cyrius dot com  2007-12-29 21:19 -------
Your patch works and there are no regressions.  Can you please submit it?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3 Regression] Segfault in alpha_expand_mov at -O3

[mmitchel at gcc dot gnu dot org]

------- Comment #6 from mmitchel at gcc dot gnu dot org  2008-01-02 23:06 -------
Alpha is not a primary or secondary platform.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3 Regression] Segfault in alpha_expand_mov at -O3

[steven at gcc dot gnu dot org]

------- Comment #7 from steven at gcc dot gnu dot org  2008-01-12 16:22 -------
Patch of comment #3 looks good to me.


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3 Regression] Segfault in alpha_expand_mov at -O3

[tbm at cyrius dot com]

------- Comment #8 from tbm at cyrius dot com  2008-01-23 12:11 -------
Rask, can you please submit the patch?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3/4.4 Regression] Segfault in alpha_expand_mov at -O3

[nightstrike at gmail dot com]

------- Comment #9 from nightstrike at gmail dot com  2008-02-19 22:23 -------
Was this patch ever submitted?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3/4.4 Regression] Segfault in alpha_expand_mov at -O3

[tbm at cyrius dot com]

------- Comment #10 from tbm at cyrius dot com  2008-02-29 12:23 -------
RTH, can you take the lead on submitting/applying this patch to fix
an Alpha bug?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3/4.4 Regression] Segfault in alpha_expand_mov at -O3

[jsm28 at gcc dot gnu dot org]

------- Comment #11 from jsm28 at gcc dot gnu dot org  2008-03-15 00:42 -------
Update milestone after 4.3.0 release.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.0                       |4.3.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3/4.4 Regression] Segfault in alpha_expand_mov at -O3

[rguenth at gcc dot gnu dot org]

------- Comment #12 from rguenth at gcc dot gnu dot org  2008-06-06 14:58 -------
4.3.1 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.1                       |4.3.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3/4.4 Regression] Segfault in alpha_expand_mov at -O3

[jsm28 at gcc dot gnu dot org]

------- Comment #13 from jsm28 at gcc dot gnu dot org  2008-08-27 22:03 -------
4.3.2 is released, changing milestones to 4.3.3.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.2                       |4.3.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3/4.4 Regression] Segfault in alpha_expand_mov at -O3

[steven at gcc dot gnu dot org]

------- Comment #14 from steven at gcc dot gnu dot org  2008-11-22 11:17 -------
Ping?
Patch exists, tested and all, and just needs a re-test and then submit...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3/4.4 Regression] Segfault in alpha_expand_mov at -O3

[ubizjak at gmail dot com]

------- Comment #15 from ubizjak at gmail dot com  2008-12-18 15:36 -------
(In reply to comment #14)
> Patch exists, tested and all, and just needs a re-test and then submit...

I will re-bootstrap/re-test this patch. Will take some days to retest.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|rask at gcc dot gnu dot org |ubizjak at gmail dot com
             Status|ASSIGNED                    |UNCONFIRMED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3/4.4 Regression] Segfault in alpha_expand_mov at -O3

[ubizjak at gmail dot com]

------- Comment #16 from ubizjak at gmail dot com  2008-12-18 19:53 -------
(In reply to comment #15)

> I will re-bootstrap/re-test this patch. Will take some days to retest.

It looks to me, that we need to fix this from the other side. According to the
comment above symbolic_operand predicate, we should also accept label_ref with
an offset, so:

Index: varasm.c
===================================================================
--- varasm.c    (revision 142326)
+++ varasm.c    (working copy)
@@ -3710,7 +3710,7 @@
       /* FALLTHRU  */

     case LABEL_REF:
-      tmp = XEXP (x, 0);
+      tmp = XEXP (tmp, 0);
       gcc_assert (!INSN_DELETED_P (tmp));
       gcc_assert (!NOTE_P (tmp)
                  || NOTE_KIND (tmp) != NOTE_INSN_DELETED);
Index: config/alpha/predicates.md
===================================================================
--- config/alpha/predicates.md  (revision 142326)
+++ config/alpha/predicates.md  (working copy)
@@ -390,7 +390,8 @@
   (ior (match_code "symbol_ref,label_ref")
        (and (match_code "const")
            (match_test "GET_CODE (XEXP (op,0)) == PLUS
-                        && GET_CODE (XEXP (XEXP (op,0), 0)) == SYMBOL_REF
+                        && (GET_CODE (XEXP (XEXP (op,0), 0)) == SYMBOL_REF
+                            || GET_CODE (XEXP (XEXP (op,0), 0)) == LABEL_REF)
                         && GET_CODE (XEXP (XEXP (op,0), 1)) == CONST_INT"))))

 ;; Return true if OP is valid for 16-bit DTP relative relocations.


BTW: The fix to varasm.c is already in mainline, need to backport

2008-03-31  James E. Wilson  <wilson@tuliptree.org>

        * varasm.c (output_constant_pool_1): In LABEL_REF check,
        use tmp consistently.

BTW: The test doesn't fail anymore neither on 4.4 and neither on 4.3 branch.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-12-18 19:53:11
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3/4.4 Regression] Segfault in alpha_expand_mov at -O3

[uros at gcc dot gnu dot org]

------- Comment #17 from uros at gcc dot gnu dot org  2008-12-22 17:51 -------
Subject: Bug 34571

Author: uros
Date: Mon Dec 22 17:49:52 2008
New Revision: 142885

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142885
Log:
        * config/alpha/alpha.h (ASM_OUTPUT_EXTERNAL): New macro.

        PR target/34571
        * config/alpha/predicates.md (symbolic_operand): Return 1 for a
        label_ref with an offset.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/alpha/elf.h
    trunk/gcc/config/alpha/predicates.md
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3 Regression] Segfault in alpha_expand_mov at -O3

[ubizjak at gmail dot com]

------- Comment #18 from ubizjak at gmail dot com  2008-12-22 17:53 -------
Patch [1] was committed to 4.4 mainline, needs to be backported to 4.3,
together with varasm.c change.

[1] http://gcc.gnu.org/ml/gcc-patches/2008-12/msg01127.html


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.3/4.4 Regression]        |[4.3 Regression] Segfault in
                   |Segfault in alpha_expand_mov|alpha_expand_mov at -O3
                   |at -O3                      |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3 Regression] Segfault in alpha_expand_mov at -O3

[uros at gcc dot gnu dot org]

------- Comment #19 from uros at gcc dot gnu dot org  2009-01-11 14:33 -------
Subject: Bug 34571

Author: uros
Date: Sun Jan 11 14:33:28 2009
New Revision: 143272

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143272
Log:
        Backport from mainline:
        2008-12-22  Uros Bizjak  <ubizjak@gmail.com>

        PR target/34571
        * config/alpha/predicates.md (symbolic_operand): Return 1 for a
        label_ref with an offset.

        2008-03-31  James E. Wilson  <wilson@tuliptree.org>

        * varasm.c (output_constant_pool_1): In LABEL_REF check,
        use tmp consistently.


Modified:
    branches/gcc-4_3-branch/gcc/ChangeLog
    branches/gcc-4_3-branch/gcc/config/alpha/predicates.md
    branches/gcc-4_3-branch/gcc/varasm.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571

[Bug target/34571] [4.3 Regression] Segfault in alpha_expand_mov at -O3

[ubizjak at gmail dot com]

------- Comment #20 from ubizjak at gmail dot com  2009-01-11 14:35 -------
Fixed.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34571