[Bug target/34711] New: g++.dg/tree-ssa/ivopts-1.C fails for power

[Bug target/34711] New: g++.dg/tree-ssa/ivopts-1.C fails for power

[janis at gcc dot gnu dot org]

There are already two other problem reports for failures of this test: PR
target/26726 for i?86 and x86_64, and PR target/27707 for hppa.  Those are not
regressions.  The test started failing for powerpc64-linux-gnu, both -m32 and
-m64, with this patch:

    http://gcc.gnu.org/viewcvs?view=rev&rev=128272

    r128272 | rakdver | 2007-09-08 13:18:49 +0000 (Sat, 08 Sep 2007)

Test results for other powerpc targets show that they start failing later; here
are the targets and the ranges in which they start failing, plus a couple of
arm targets:

  powerpc-ibm-aix5.3.0.0      2007-10-20 to 2007-10-30
  powerpc-apple-darwin8.5.0   2007-10-24 to 2007-11-01
  arm-none-eabi               2007-10-27 to 2007-10-29

  arm-none-linux-gnueabi      2007-12-25 to 2007-12-26

I'll find out which patches caused the test to start failing for these targets.


-- 
           Summary: g++.dg/tree-ssa/ivopts-1.C fails for power
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: janis at gcc dot gnu dot org
GCC target triplet: powerpc*-*-linux*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34711

[Bug target/34711] g++.dg/tree-ssa/ivopts-1.C fails for power and arm

[janis at gcc dot gnu dot org]

------- Comment #1 from janis at gcc dot gnu dot org  2008-01-09 18:20 -------
Despite what the archived test results show, regression hunts using cross
cc1plus on powerpc-linux show that the test starts failing for all tested
powerpc and arm targets (the four listed in the submitter's description) for
r128272.  During the range when archived test results show most of the targets
starting to fail the test, the search expression changed.


-- 

janis at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rakdver at gcc dot gnu dot
                   |                            |org
 GCC target triplet|powerpc*-*-linux*           |powerpc*
            Summary|g++.dg/tree-ssa/ivopts-1.C  |g++.dg/tree-ssa/ivopts-1.C
                   |fails for power             |fails for power and arm


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34711

[Bug target/34711] g++.dg/tree-ssa/ivopts-1.C fails for power and arm

[rakdver at gcc dot gnu dot org]

-- 

rakdver at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rakdver at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-01-21 17:41:07
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34711

[Bug target/34711] [4.3 Regression] g++.dg/tree-ssa/ivopts-1.C fails for power and arm

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2008-01-26 22:43 -------
So this (was) in fact a regression.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |missed-optimization
            Summary|g++.dg/tree-ssa/ivopts-1.C  |[4.3 Regression]
                   |fails for power and arm     |g++.dg/tree-ssa/ivopts-1.C
                   |                            |fails for power and arm
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34711

[Bug target/34711] [4.3 Regression] g++.dg/tree-ssa/ivopts-1.C fails for power and arm

[rakdver at gcc dot gnu dot org]

------- Comment #3 from rakdver at gcc dot gnu dot org  2008-01-26 22:45 -------
Subject: Bug 34711

Author: rakdver
Date: Sat Jan 26 22:44:19 2008
New Revision: 131877

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131877
Log:
        PR target/34711
        * tree-ssa-loop-ivopts.c (comp_cost): New type.
        (zero_cost, infinite_cost): New constants.
        (struct cost_pair): Change type of cost to comp_cost.
        (struct iv_ca): Change type of cand_use_cost and cost to comp_cost.
        (new_cost, add_costs, sub_costs, compare_costs, infinite_cost_p):
        New functions.
        (set_use_iv_cost, force_expr_to_var_cost, force_var_cost,
        split_address_cost, ptr_difference_cost, difference_cost,
        get_computation_cost_at, get_computation_cost,
        determine_use_iv_cost_generic, determine_use_iv_cost_address,
        determine_use_iv_cost_condition, determine_use_iv_costs,
        cheaper_cost_pair, iv_ca_recount_cost, iv_ca_set_no_cp,
        iv_ca_set_cp, iv_ca_cost, iv_ca_new, iv_ca_dump, iv_ca_extend,
        iv_ca_narrow, iv_ca_prune, try_improve_iv_set, find_optimal_iv_set):
        Change type of cost to comp_cost.
        (determine_iv_cost): Increase cost of non-original ivs, instead
        of decreasing the cost of original ones.
        (get_address_cost): Indicate the complexity of the addressing mode 
        in comp_cost.
        (try_add_cand_for): Prefer using ivs not specific to some object.
        * tree-flow.h (force_expr_to_var_cost): Declaration removed.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-flow.h
    trunk/gcc/tree-ssa-loop-ivopts.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34711

[Bug target/34711] [4.3 Regression] g++.dg/tree-ssa/ivopts-1.C fails for power and arm

[steven at gcc dot gnu dot org]

------- Comment #4 from steven at gcc dot gnu dot org  2008-01-27 15:05 -------
Fixed?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34711

[Bug target/34711] [4.3 Regression] g++.dg/tree-ssa/ivopts-1.C fails for power and arm

[rakdver at gcc dot gnu dot org]

------- Comment #5 from rakdver at gcc dot gnu dot org  2008-01-27 15:35 -------
The patch fixes the problem for me on ppc (tested in crosscompiler) and on
amd64, I did not check the other architectures (arm, hppa, mips)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34711

[Bug target/34711] [4.3 Regression] g++.dg/tree-ssa/ivopts-1.C fails for power and arm

[jakub at gcc dot gnu dot org]

------- Comment #6 from jakub at gcc dot gnu dot org  2008-02-04 15:33 -------
I think we can safely close this.
For hppa see http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132082
for arm I've tested with a cross.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34711