* [Bug target/34888] Stack patterns for AVR not optimal
[not found] <bug-34888-4@http.gcc.gnu.org/bugzilla/>
@ 2011-07-20 15:37 ` gjl at gcc dot gnu.org
2011-07-21 20:49 ` gjl at gcc dot gnu.org
` (5 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: gjl at gcc dot gnu.org @ 2011-07-20 15:37 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34888
Georg-Johann Lay <gjl at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |missed-optimization
Status|UNCONFIRMED |RESOLVED
CC| |gjl at gcc dot gnu.org
Resolution| |FIXED
Target Milestone|--- |4.5.3
--- Comment #1 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2011-07-20 15:36:44 UTC ---
Closed: This was fixed by Anatoly long ago:
http://gcc.gnu.org/viewcvs?view=revision&revision=124854
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug target/34888] Stack patterns for AVR not optimal
[not found] <bug-34888-4@http.gcc.gnu.org/bugzilla/>
2011-07-20 15:37 ` [Bug target/34888] Stack patterns for AVR not optimal gjl at gcc dot gnu.org
@ 2011-07-21 20:49 ` gjl at gcc dot gnu.org
2011-08-02 21:06 ` rth at gcc dot gnu.org
` (4 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: gjl at gcc dot gnu.org @ 2011-07-21 20:49 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34888
Georg-Johann Lay <gjl at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |NEW
Last reconfirmed| |2011.07.21 20:48:36
Resolution|FIXED |
Target Milestone|4.5.3 |4.7.0
Ever Confirmed|0 |1
--- Comment #2 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2011-07-21 20:48:36 UTC ---
Set to NEW again, I didn't read r124854 carefully enough :-/
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug target/34888] Stack patterns for AVR not optimal
[not found] <bug-34888-4@http.gcc.gnu.org/bugzilla/>
2011-07-20 15:37 ` [Bug target/34888] Stack patterns for AVR not optimal gjl at gcc dot gnu.org
2011-07-21 20:49 ` gjl at gcc dot gnu.org
@ 2011-08-02 21:06 ` rth at gcc dot gnu.org
2011-08-02 21:14 ` rth at gcc dot gnu.org
` (3 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: rth at gcc dot gnu.org @ 2011-08-02 21:06 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34888
Richard Henderson <rth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |rth at gcc dot gnu.org
Depends on| |49864
AssignedTo|unassigned at gcc dot |rth at gcc dot gnu.org
|gnu.org |
--- Comment #3 from Richard Henderson <rth at gcc dot gnu.org> 2011-08-02 21:04:52 UTC ---
(1) was fixed at r171295.
(2) is done.
(3) is done.
(4) is hopefully mostly irrelevant now, or shortly post PR49864.
As of r177196 (PR49881), we should be generating many more PUSH
insns than before, and queueing more stack space to be popped
all at once. For the testcase mentioned in that PR, we seem to
wait for ~40 bytes to get pushed, and pop them all at once.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug target/34888] Stack patterns for AVR not optimal
[not found] <bug-34888-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2011-08-02 21:06 ` rth at gcc dot gnu.org
@ 2011-08-02 21:14 ` rth at gcc dot gnu.org
2011-08-03 22:58 ` rth at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: rth at gcc dot gnu.org @ 2011-08-02 21:14 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34888
--- Comment #4 from Richard Henderson <rth at gcc dot gnu.org> 2011-08-02 21:10:51 UTC ---
Created attachment 24897
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24897
Optimize pop-all
The proposed patch for PR49864 introduces REG_ARGS_SIZE.
This records a (normally) non-negative number of bytes
that have been pushed for arguments.
Post-reload, if we see a (mov sp reg) insn that says that
it's resetting the stack height, under a (common) set of
conditions we can transform that to (mov sp fp) and let
the previous (mov reg sp) (add reg N) insns be deleted as
dead code.
This reduces that common case to 4 insns instead of 9.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug target/34888] Stack patterns for AVR not optimal
[not found] <bug-34888-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2011-08-02 21:14 ` rth at gcc dot gnu.org
@ 2011-08-03 22:58 ` rth at gcc dot gnu.org
2011-08-03 22:59 ` rth at gcc dot gnu.org
2011-10-07 15:38 ` rth at gcc dot gnu.org
6 siblings, 0 replies; 7+ messages in thread
From: rth at gcc dot gnu.org @ 2011-08-03 22:58 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34888
--- Comment #5 from Richard Henderson <rth at gcc dot gnu.org> 2011-08-03 22:57:25 UTC ---
Author: rth
Date: Wed Aug 3 22:57:22 2011
New Revision: 177300
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=177300
Log:
PR target/34888
* config/avr/avr.md: New splitter for REG_ARGS_SIZE 0.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/avr/avr.md
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug target/34888] Stack patterns for AVR not optimal
[not found] <bug-34888-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2011-08-03 22:58 ` rth at gcc dot gnu.org
@ 2011-08-03 22:59 ` rth at gcc dot gnu.org
2011-10-07 15:38 ` rth at gcc dot gnu.org
6 siblings, 0 replies; 7+ messages in thread
From: rth at gcc dot gnu.org @ 2011-08-03 22:59 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34888
Richard Henderson <rth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |WAITING
--- Comment #6 from Richard Henderson <rth at gcc dot gnu.org> 2011-08-03 22:58:20 UTC ---
Fixed?
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug target/34888] Stack patterns for AVR not optimal
[not found] <bug-34888-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2011-08-03 22:59 ` rth at gcc dot gnu.org
@ 2011-10-07 15:38 ` rth at gcc dot gnu.org
6 siblings, 0 replies; 7+ messages in thread
From: rth at gcc dot gnu.org @ 2011-10-07 15:38 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34888
Richard Henderson <rth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |RESOLVED
Resolution| |FIXED
--- Comment #7 from Richard Henderson <rth at gcc dot gnu.org> 2011-10-07 15:37:40 UTC ---
Re-open if you think there's still work to do.
^ permalink raw reply [flat|nested] 7+ messages in thread