[Bug c/34947] New: Clobbered float registers not popped

[Bug c/34947] New: Clobbered float registers not popped

[vincent dot riviere at freesbee dot fr]

This problem is about functions that push some float registers at the
beginning, but forget to pop them at the end. The stack pointer is not adjusted
as expected, so the function return to an invalid address.

It appears when the following is true:
- the file is compiled with -m68020-60 -O1 -fomit-frame-pointer
- the function uses floats
- the function is complicated enough to have some float registers backed up on
the stack
- there is an early return in the function

The problem appears in the following test case:
$ cat bug.c
volatile float g1;
float g2;

void f(void)
{
    float i;

    if (g2 >= 0)
        return;

    for (i = 0; i < 10; ++i)
        g1 = g2 + i;
}

$ gcc -S bug.c -o - -m68020-60 -O2 -fomit-frame-pointer
...
        .globl  f
        .type   f, @function
f:
        fmovm #0x4,-(%sp)
        fmove.s g2,%fp2
        fbnge .L9
.L5:
        rts
.L9:
...

We can see that some float registers are backuped at the beginning. Then (g2 >=
0) is checked. If it is the case, the function returns with a simple rts,
without restoring the registers, to an invalid address.

This happens in gcc 4.2.2 and gcc-4.2-20080116


-- 
           Summary: Clobbered float registers not popped
           Product: gcc
           Version: 4.2.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: vincent dot riviere at freesbee dot fr
GCC target triplet: m68k-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34947

[Bug c/34947] [4.2 Regression] Clobbered float registers not popped

[vincent dot riviere at freesbee dot fr]

------- Comment #1 from vincent dot riviere at freesbee dot fr  2008-02-02 19:14 -------
The bug is still here in the official 4.2.3


-- 

vincent dot riviere at freesbee dot fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
          Component|target                      |c
      Known to fail|                            |4.2.3
      Known to work|                            |4.1.2
            Summary|Clobbered float registers   |[4.2 Regression] Clobbered
                   |not popped                  |float registers not popped


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34947

[Bug c/34947] [4.2 Regression] Clobbered float registers not popped

[vincent dot riviere at freesbee dot fr]

------- Comment #2 from vincent dot riviere at freesbee dot fr  2008-02-21 07:34 -------
That patch fixes the problem:
http://gcc.gnu.org/ml/gcc-patches/2007-01/msg00790.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34947

[Bug target/34947] [4.2 Regression] Clobbered float registers not popped

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c                           |target
           Keywords|                            |wrong-code
      Known to work|4.1.2                       |4.1.2 4.3.0
   Target Milestone|---                         |4.2.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34947

[Bug target/34947] [4.2 Regression] Clobbered float registers not popped

[jsm28 at gcc dot gnu dot org]

------- Comment #3 from jsm28 at gcc dot gnu dot org  2008-05-19 20:24 -------
4.2.4 is being released, changing milestones to 4.2.5.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.2.4                       |4.2.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34947

[Bug target/34947] [4.2 Regression] Clobbered float registers not popped

[jsm28 at gcc dot gnu dot org]

------- Comment #4 from jsm28 at gcc dot gnu dot org  2009-03-31 15:03 -------
Closing 4.2 branch, fixed in 4.3.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Known to fail|4.2.3                       |4.2.3 4.2.5
         Resolution|                            |FIXED
   Target Milestone|4.2.5                       |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34947