[Bug other/35148] New: make pdf has missing file in 4.3-20080208

[Bug other/35148] New: make pdf has missing file in 4.3-20080208

[hal at oz dot net]

I built a copy of gcc-4.3-20080208.tar.bz2 on a powerbook g4, OS X 10.4.11,
xcode 2.5, with the only configure option being
--enable-languages=c,c++,fortran.  The build worked fine, but when I entered
make pdf after the build was done, it was ran into trouble with
gcc/doc/gcc.texi because of a missing file:

! I can't find file `../../gcc-4.3-20080208/gcc/../libiberty/at-file.texi'.
@includezzz ...#1}{@makevalueexpandable @input #1 
                                                  }@popthisfilestack 
l.1244 ...@value{srcdir}/../libiberty/at-file.texi

If I enter x, tex continues, but then this bug is encountered again on
subsequent documents.

I have been able to build the pdf files before on this same setup, but recently
I've only done this after a full build (i.e., configure with no options,
meaning that other things including java are built, and the full build takes
much longer).  I know I've been able to do a make pdf successfully in the past
after only building c,c++,fortran, but I haven't tried this on a gcc 4.3
snapshot for a while, so I can't say for sure if the difference in the
configure options contributes to the problem or not.


-- 
           Summary: make pdf has missing file in 4.3-20080208
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hal at oz dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[Ralf dot Wildenhues at gmx dot de]

------- Comment #1 from Ralf dot Wildenhues at gmx dot de  2008-02-09 18:36 -------
Confirmed the failure with
$ /usr/bin/texi2dvi --version
texi2dvi (GNU Texinfo 4.8) 1.34

It works fine however with current CVS texinfo.

Related: <http://gcc.gnu.org/ml/gcc-patches/2008-02/msg00125.html>


-- 

Ralf dot Wildenhues at gmx dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Ralf dot Wildenhues at gmx
                   |                            |dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[joseph at codesourcery dot com]

------- Comment #2 from joseph at codesourcery dot com  2008-02-09 19:29 -------
Subject: Re:   New: make pdf has missing file in 4.3-20080208

On Sat, 9 Feb 2008, hal at oz dot net wrote:

> ! I can't find file `../../gcc-4.3-20080208/gcc/../libiberty/at-file.texi'.

This looks like you are configuring with a relative path to the source 
directory.  Does configuring with an absolute path 
(/path/to/srcdir/configure) help?

If it does, I'd be inclined to make

        echo "@set srcdir $(srcdir)" >> $@T

(in the rule for gcc-vers.texi) use $(abs_srcdir) instead - see if that 
helps when using a relative path to the source directory.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[Ralf dot Wildenhues at gmx dot de]

------- Comment #3 from Ralf dot Wildenhues at gmx dot de  2008-02-09 22:13 -------
Subject: Re:  make pdf has missing file in 4.3-20080208

* joseph at codesourcery dot com wrote on Sat, Feb 09, 2008 at 08:29:27PM CET:
> On Sat, 9 Feb 2008, hal at oz dot net wrote:
> 
> > ! I can't find file `../../gcc-4.3-20080208/gcc/../libiberty/at-file.texi'.
> 
> This looks like you are configuring with a relative path to the source 
> directory.  Does configuring with an absolute path 
> (/path/to/srcdir/configure) help?

For me, putting an absolute srcdir path in gcc-vers.texi seems to do the
trick for texinfo 4.8.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[hal at oz dot net]

------- Comment #4 from hal at oz dot net  2008-02-10 17:18 -------
Yes, redoing the configure with an absolute path does solve the problem. (The
original was, indeed, configured with a relative path -- old habit, avoiding
absolute paths whenever I can.)

For the record, I've got this version of texi2dvi in /usr/bin:

texi2dvi --version
texi2dvi (GNU Texinfo 4.7) 1.3

I'd be glad to try changing the rule for gcc-vers.texi to see if that fixes the
original problem, but I'm not sure where to do this.  What file is this in?

Thanks


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[Ralf dot Wildenhues at gmx dot de]

------- Comment #5 from Ralf dot Wildenhues at gmx dot de  2008-02-10 17:21 -------
Subject: Re:  make pdf has missing file in 4.3-20080208

* hal at oz dot net wrote on Sun, Feb 10, 2008 at 06:18:02PM CET:
> 
> I'd be glad to try changing the rule for gcc-vers.texi to see if that fixes the
> original problem, but I'm not sure where to do this.  What file is this in?

diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 7553dcb..9c91fb5 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -3653,7 +3653,7 @@ gcc-vers.texi: $(BASEVER) $(DEVPHASE)
         then echo "@set DEVELOPMENT"; \
         else echo "@clear DEVELOPMENT"; \
         fi) > $@T
-       echo "@set srcdir $(srcdir)" >> $@T
+       echo "@set srcdir $(abs_srcdir)" >> $@T
        if [ -n "$(PKGVERSION)" ]; then \
          echo "@set VERSION_PACKAGE $(PKGVERSION)" >> $@T; \
        fi


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[joseph at codesourcery dot com]

------- Comment #6 from joseph at codesourcery dot com  2008-02-10 20:25 -------
Subject: Re:  make pdf has missing file in 4.3-20080208

On Sun, 10 Feb 2008, Ralf dot Wildenhues at gmx dot de wrote:

> --- a/gcc/Makefile.in
> +++ b/gcc/Makefile.in
> @@ -3653,7 +3653,7 @@ gcc-vers.texi: $(BASEVER) $(DEVPHASE)
>          then echo "@set DEVELOPMENT"; \
>          else echo "@clear DEVELOPMENT"; \
>          fi) > $@T
> -       echo "@set srcdir $(srcdir)" >> $@T
> +       echo "@set srcdir $(abs_srcdir)" >> $@T
>         if [ -n "$(PKGVERSION)" ]; then \
>           echo "@set VERSION_PACKAGE $(PKGVERSION)" >> $@T; \
>         fi

This patch is OK for trunk and 4.2 branch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[Ralf dot Wildenhues at gmx dot de]

------- Comment #7 from Ralf dot Wildenhues at gmx dot de  2008-02-10 20:30 -------
Subject: Re:  make pdf has missing file in 4.3-20080208

* joseph at codesourcery dot com wrote on Sun, Feb 10, 2008 at 09:25:09PM CET:
> On Sun, 10 Feb 2008, Ralf dot Wildenhues at gmx dot de wrote:
> > --- a/gcc/Makefile.in
> > +++ b/gcc/Makefile.in
> > @@ -3653,7 +3653,7 @@ gcc-vers.texi: $(BASEVER) $(DEVPHASE)
> >          then echo "@set DEVELOPMENT"; \
> >          else echo "@clear DEVELOPMENT"; \
> >          fi) > $@T
> > -       echo "@set srcdir $(srcdir)" >> $@T
> > +       echo "@set srcdir $(abs_srcdir)" >> $@T
> >         if [ -n "$(PKGVERSION)" ]; then \
> >           echo "@set VERSION_PACKAGE $(PKGVERSION)" >> $@T; \
> >         fi
> 
> This patch is OK for trunk and 4.2 branch.

Thanks.  Please note that I don't have write access yet (so if you want
to make sure it gets in please consider applying it).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |patch
   Last reconfirmed|0000-00-00 00:00:00         |2008-02-10 23:03:09
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[hal at oz dot net]

------- Comment #8 from hal at oz dot net  2008-02-11 00:46 -------
I checked, and that patch does fix the original problem on my machine.  Thanks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[joseph at codesourcery dot com]

------- Comment #9 from joseph at codesourcery dot com  2008-02-12 20:15 -------
Subject: Re:  make pdf has missing file in 4.3-20080208

On Sun, 10 Feb 2008, Ralf dot Wildenhues at gmx dot de wrote:

> Thanks.  Please note that I don't have write access yet (so if you want
> to make sure it gets in please consider applying it).

Write access requests should be processed quickly, may be worth pinging.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[rwild at gcc dot gnu dot org]

------- Comment #10 from rwild at gcc dot gnu dot org  2008-02-13 19:28 -------
Subject: Bug 35148

Author: rwild
Date: Wed Feb 13 19:27:34 2008
New Revision: 132295

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132295
Log:
PR other/35148
* Makefile.in (gcc-vers.texi): Use abs_srcdir for the value of
srcdir.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/Makefile.in


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[rwild at gcc dot gnu dot org]

------- Comment #12 from rwild at gcc dot gnu dot org  2008-02-13 20:27 -------
Fixed.


-- 

rwild at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[rwild at gcc dot gnu dot org]

------- Comment #11 from rwild at gcc dot gnu dot org  2008-02-13 20:26 -------
Subject: Bug 35148

Author: rwild
Date: Wed Feb 13 20:25:47 2008
New Revision: 132296

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132296
Log:
PR other/35148
* Makefile.in (gcc-vers.texi): Use abs_srcdir for the value of
srcdir.

Modified:
    branches/gcc-4_2-branch/gcc/ChangeLog
    branches/gcc-4_2-branch/gcc/Makefile.in


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[fxcoudert at gcc dot gnu dot org]

------- Comment #13 from fxcoudert at gcc dot gnu dot org  2008-02-17 11:58 -------
(In reply to comment #5)
> diff --git a/gcc/Makefile.in b/gcc/Makefile.in
> index 7553dcb..9c91fb5 100644
> --- a/gcc/Makefile.in
> +++ b/gcc/Makefile.in
> @@ -3653,7 +3653,7 @@ gcc-vers.texi: $(BASEVER) $(DEVPHASE)
>          then echo "@set DEVELOPMENT"; \
>          else echo "@clear DEVELOPMENT"; \
>          fi) > $@T
> -       echo "@set srcdir $(srcdir)" >> $@T
> +       echo "@set srcdir $(abs_srcdir)" >> $@T
>         if [ -n "$(PKGVERSION)" ]; then \
>           echo "@set VERSION_PACKAGE $(PKGVERSION)" >> $@T; \
>         fi

This patch breaks bootstrap on platforms where absolute path to the source dir
simply does not work (at least, no as argument to external tools), like mingw.
See PR35218.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fxcoudert at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[hal at oz dot net]

------- Comment #14 from hal at oz dot net  2008-02-17 17:28 -------
Two comments to add, now that it seems that this patch might have caused some
other problems:

1) In the original bug (make pdf doesn't work after building with a relative
path), the source and build directories were on the same disk, but it was a
second disk, not the primary one containing the OS X system and xcode tools. 
I'm rerunning the 20080208 build on the startup disk now to see whether
building on an external volume made any difference, but that will take a while
to finish.  I'll follow up once I find out what happens.

2) This bug only appeared in the 20080208 snapshot.  It did not exist with the
20080201 and earlier snapshots as best I can tell.  So what changed between
those two snapshots that either caused or exposed the original problem?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[rwild at gcc dot gnu dot org]

------- Comment #15 from rwild at gcc dot gnu dot org  2008-02-17 17:40 -------
(In reply to comment #14)
> 1) In the original bug (make pdf doesn't work after building with a relative
> path), the source and build directories were on the same disk, but it was a
> second disk, not the primary one containing the OS X system and xcode tools. 
> I'm rerunning the 20080208 build on the startup disk now to see whether
> building on an external volume made any difference, but that will take a while
> to finish.  I'll follow up once I find out what happens.

I have confirmed your issue on a system with only one disk, so no, it has
nothing to do with that.

> 2) This bug only appeared in the 20080208 snapshot.  It did not exist with the
> 20080201 and earlier snapshots as best I can tell.  So what changed between
> those two snapshots that either caused or exposed the original problem?

The texinfo.tex file was updated to fix a very similar bug with newer texinfo
(AFAIR; comment #2 has a pointer to the discussion)

I have since posted another patch, to hopefully fix the issue on MinGW
<http://gcc.gnu.org/ml/gcc-patches/2008-02/msg00654.html>.  It needs somebody
to test it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148

[Bug other/35148] make pdf has missing file in 4.3-20080208

[hal at oz dot net]

------- Comment #16 from hal at oz dot net  2008-02-17 17:46 -------
OK.  Thanks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35148