From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1561 invoked by alias); 14 Feb 2008 19:00:17 -0000 Received: (qmail 1167 invoked by uid 48); 14 Feb 2008 18:59:33 -0000 Date: Thu, 14 Feb 2008 19:00:00 -0000 Subject: [Bug other/35199] New: [PATCH] Check for valid value of BASEVER X-Bugzilla-Reason: CC Message-ID: Reply-To: gcc-bugzilla@gcc.gnu.org To: gcc-bugs@gcc.gnu.org From: "skunk at iskunk dot org" Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2008-02/txt/msg01554.txt.bz2 I was recently bootstrapping GCC4 on Tru64. One thing that tripped me up a couple times was an ICE resulting from an invalid version_string (""). I traced this back to the following fragment in gcc/Makefile, where BASEVER_c is assigned: BASEVER := $(srcdir)/BASE-VER # 4.x.y [...] BASEVER_c := $(shell cat $(BASEVER)) For some reason, the value of BASEVER_c was empty. I had the source tree on NFS, and figured that some transient error caused $(BASEVER) to either disappear momentarily, or briefly appear as an empty file. (It's difficult to say, because the rest of the build proceeded with no errors of this sort whatsoever.) Whatever the cause, the makefile as currently written does not check for an empty value of BASEVER_c, and the ICE that later results from this is magnitudes of order more difficult to diagnose for most users. I would like to submit a patch to the makefile, then, that immediately throws an error if BASEVER_c is empty. -- Summary: [PATCH] Check for valid value of BASEVER Product: gcc Version: 4.2.3 Status: UNCONFIRMED Severity: normal Priority: P3 Component: other AssignedTo: unassigned at gcc dot gnu dot org ReportedBy: skunk at iskunk dot org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35199