[Bug c/35330] [4.3/4.4/4.5/4.6/4.7 regression] ICE with invalid pragma weak

[Bug c/35330] [4.3/4.4/4.5/4.6/4.7 regression] ICE with invalid pragma weak

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35330

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.6                       |4.4.7

--- Comment #6 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-06-27 12:14:21 UTC ---
4.3 branch is being closed, moving to 4.4.7 target.

[Bug c/35330] [4.5/4.6/4.7/4.8 regression] ICE with invalid pragma weak

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35330

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.4.7                       |4.5.4

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-03-13 12:47:47 UTC ---
4.4 branch is being closed, moving to 4.5.4 target.

[Bug c/35330] [4.6/4.7/4.8 regression] ICE with invalid pragma weak

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35330

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.4                       |4.6.4

[Bug c/35330] [4.7/4.8/4.9 regression] ICE with invalid pragma weak

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35330

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.6.4                       |4.7.4

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-04-12 15:16:54 UTC ---
GCC 4.6.4 has been released and the branch has been closed.

[Bug c/35330] [4.7/4.8/4.9/4.10 regression] ICE with invalid pragma weak

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=35330

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.7.4                       |4.8.4

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
The 4.7 branch is being closed, moving target milestone to 4.8.4.

[Bug c/35330] [4.8/4.9/5 regression] ICE with invalid pragma weak

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=35330

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.4                       |4.8.5

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.4 has been released.

[Bug c/35330] [4.8/4.9/5 regression] ICE with invalid pragma weak

[ktietz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=35330

Kai Tietz <ktietz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktietz at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |ktietz at gcc dot gnu.org

--- Comment #11 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Mine.

[Bug c/35330] [4.8/4.9/5 regression] ICE with invalid pragma weak

[ktietz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=35330

--- Comment #12 from Kai Tietz <ktietz at gcc dot gnu.org> ---
issue seems to be that in declare_weak we don't check that DECL is actually
either a function, or a variable declaration.

Fix would be to add an error-message in declare_weak ().

Index: varasm.c
===================================================================
@@ -5398,6 +5399,12 @@ void
 declare_weak (tree decl)
 {
   gcc_assert (TREE_CODE (decl) != FUNCTION_DECL || !TREE_ASM_WRITTEN (decl));
+  if (TREE_CODE (decl) != FUNCTION_DECL && TREE_CODE (decl) != VAR_DECL)
+    {
+      error ("weak declaration of %q+D has to be either a function,"
+            " or a variable declaration", decl);
+      return;
+    }
   if (! TREE_PUBLIC (decl))
     error ("weak declaration of %q+D must be public", decl);
   else if (!TARGET_SUPPORTS_WEAK)

[Bug c/35330] [4.8/4.9/5 regression] ICE with invalid pragma weak

[ktietz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=35330

--- Comment #13 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Author: ktietz
Date: Fri Feb 27 10:44:43 2015
New Revision: 221053

URL: https://gcc.gnu.org/viewcvs?rev=221053&root=gcc&view=rev
Log:
2015-02-27  Kai Tietz  <ktietz@redhat.com>

    PR c/35330
    * c-pragma.c (handle_pragma_weak): Do not try to create
    weak/alias of declarations not being function, or variable
    declarations.

2015-02-27  Kai Tietz  <ktietz@redhat.com>

    PR c/35330
    * gcc.dg/weak/weak-17.c: New file.


Added:
    trunk/gcc/testsuite/gcc.dg/weak/weak-17.c
Modified:
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c-pragma.c
    trunk/gcc/testsuite/ChangeLog

[Bug c/35330] [4.8/4.9/5 regression] ICE with invalid pragma weak

[ktietz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=35330

Kai Tietz <ktietz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Kai Tietz <ktietz at gcc dot gnu.org> ---
I don't intend to backport this change.  therefore I close as fixed.