[Bug c/35634] [4.3/4.4/4.5/4.6 Regression] operand of pre-/postin-/decrement not promoted

[Bug c/35634] [4.3/4.4/4.5/4.6 Regression] operand of pre-/postin-/decrement not promoted

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |regehr at cs dot utah.edu

--- Comment #28 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-03-01 07:35:21 UTC ---
*** Bug 47937 has been marked as a duplicate of this bug. ***

[Bug c/35634] [4.3/4.4/4.5/4.6/4.7 Regression] operand of pre-/postin-/decrement not promoted

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.6                       |4.4.7

--- Comment #29 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-06-27 12:13:12 UTC ---
4.3 branch is being closed, moving to 4.4.7 target.

[Bug c/35634] [4.4/4.5/4.6/4.7 Regression] operand of pre-/postin-/decrement not promoted

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |
      Known to fail|                            |

--- Comment #30 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-07-15 18:55:41 UTC ---
Any news on this bug?

[Bug c/35634] [4.4/4.5/4.6/4.7 Regression] operand of pre-/postin-/decrement not promoted

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

--- Comment #31 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-07-18 08:16:58 UTC ---
Well, I'd still go for comment#14 ... we could teach VRP to shorten the
operations again, if possible, to avoid the optimization regressions.

[Bug c/35634] [4.5/4.6/4.7/4.8 Regression] operand of pre-/postin-/decrement not promoted

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.4.7                       |4.5.4

--- Comment #32 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-03-13 12:46:04 UTC ---
4.4 branch is being closed, moving to 4.5.4 target.

[Bug c/35634] [4.5/4.6/4.7/4.8 Regression] operand of pre-/postin-/decrement not promoted

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.4                       |4.6.4

--- Comment #33 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-07-02 11:54:55 UTC ---
The 4.5 branch is being closed, adjusting target milestone.

[Bug c/35634] [4.6/4.7/4.8 Regression] operand of pre-/postin-/decrement not promoted

[jaak at ristioja dot ee]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

Jaak Ristioja <jaak at ristioja dot ee> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jaak at ristioja dot ee

--- Comment #34 from Jaak Ristioja <jaak at ristioja dot ee> 2012-11-19 08:24:00 UTC ---
Bump! I don't want to be impolite, but quoting
http://blog.regehr.org/archives/482
  "In LLVM/Clang the bug was not known but was fixed in less than 24 hours."

Seriously...

[Bug c/35634] [4.6/4.7/4.8 Regression] operand of pre-/postin-/decrement not promoted

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|55481                       |
         AssignedTo|unassigned at gcc dot       |rguenth at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #35 from Richard Biener <rguenth at gcc dot gnu.org> 2012-11-27 12:25:02 UTC ---
Mine.

[Bug c/35634] [4.6/4.7/4.8 Regression] operand of pre-/postin-/decrement not promoted

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

--- Comment #36 from Richard Biener <rguenth at gcc dot gnu.org> 2012-11-27 14:56:56 UTC ---
Created attachment 28794
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=28794
first patch updated

With the first patch updated to apply again and to instead of promoting
doing arithmetic in an unsigned type still causes

+FAIL: gcc.dg/vect/pr18536.c scan-tree-dump-times vect "vectorized 1 loops" 1
+FAIL: gcc.dg/vect/vect-iv-8.c scan-tree-dump-times vect "vectorized 1 loops" 1
+FAIL: gcc.dg/vect/vect-iv-8a.c scan-tree-dump-times vect "vectorized 1 loops"
1
+FAIL: gcc.dg/vect/pr18536.c -flto  scan-tree-dump-times vect "vectorized 1
loop
s" 1
+FAIL: gcc.dg/vect/vect-iv-8.c -flto  scan-tree-dump-times vect "vectorized 1
lo
ops" 1
+FAIL: gcc.dg/vect/vect-iv-8a.c -flto  scan-tree-dump-times vect "vectorized 1
l
oops" 1

which is better compared to doing the promotion:

+FAIL: gcc.dg/vect/pr18536.c scan-tree-dump-times vect "vectorized 1 loops" 1
+FAIL: gcc.dg/vect/vect-iv-8.c scan-tree-dump-times vect "vectorized 1 loops" 1
+FAIL: gcc.dg/vect/vect-iv-8a.c scan-tree-dump-times vect "vectorized 1 loops"
1
+FAIL: gcc.dg/vect/vect-reduc-dot-u16a.c scan-tree-dump-times vect "vectorized
1
 loops" 2
+FAIL: gcc.dg/vect/slp-21.c scan-tree-dump-times vect "vectorized 4 loops" 1
+FAIL: gcc.dg/vect/slp-21.c scan-tree-dump-times vect "vectorizing stmts using
S
LP" 2
+FAIL: gcc.dg/vect/slp-perm-9.c scan-tree-dump-times vect "vectorized 1 loops"
1
+FAIL: gcc.dg/vect/slp-reduc-3.c scan-tree-dump-times vect "vectorized 1 loops" 
2
+FAIL: gcc.dg/vect/pr18536.c -flto  scan-tree-dump-times vect "vectorized 1
loop
s" 1
+FAIL: gcc.dg/vect/vect-iv-8.c -flto  scan-tree-dump-times vect "vectorized 1
lo
ops" 1
+FAIL: gcc.dg/vect/vect-iv-8a.c -flto  scan-tree-dump-times vect "vectorized 1
l
oops" 1
+FAIL: gcc.dg/vect/vect-reduc-dot-u16a.c -flto  scan-tree-dump-times vect
"vecto
rized 1 loops" 2
+FAIL: gcc.dg/vect/slp-21.c -flto  scan-tree-dump-times vect "vectorized 4
loops
" 1
+FAIL: gcc.dg/vect/slp-21.c -flto  scan-tree-dump-times vect "vectorizing stmts 
using SLP" 2
+FAIL: gcc.dg/vect/slp-perm-9.c -flto  scan-tree-dump-times vect "vectorized 1
l
oops" 1
+FAIL: gcc.dg/vect/slp-reduc-3.c -flto  scan-tree-dump-times vect "vectorized 1 
loops" 2
+FAIL: gcc.dg/vect/no-scevccp-outer-19.c scan-tree-dump-times vect "OUTER LOOP
V
ECTORIZED." 1

note that the gimple semantics change patch will play foul with
decltype / sizeof ( char += char ) where it likely will result in
the promoted type rather than char.

[Bug c/35634] [4.6/4.7/4.8 Regression] operand of pre-/postin-/decrement not promoted

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

--- Comment #37 from Richard Biener <rguenth at gcc dot gnu.org> 2012-11-28 09:27:14 UTC ---
Author: rguenth
Date: Wed Nov 28 09:27:10 2012
New Revision: 193882

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=193882
Log:
2012-11-28  Richard Biener  <rguenther@suse.de>

    PR c/35634
    * gimple.h (gimplify_self_mod_expr): Declare.
    * gimplify.c (gimplify_self_mod_expr): Export.  Take a different
    type for performing the arithmetic in.
    (gimplify_expr): Adjust.
    * tree-vect-loop-manip.c (vect_can_advance_ivs_p): Strip
    sign conversions we can re-apply after adjusting the IV.

    c-family/
    * c-gimplify.c (c_gimplify_expr): Gimplify self-modify expressions
    here and use a type with proper overflow behavior for types that would
    need to be promoted for the arithmetic.

    * gcc.dg/torture/pr35634.c: New testcase.
    * g++.dg/torture/pr35634.C: Likewise.
    * gcc.dg/vect/pr18536.c: Mark worker function noinline.

Added:
    trunk/gcc/testsuite/g++.dg/torture/pr35634.C
    trunk/gcc/testsuite/gcc.dg/torture/pr35634.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c-gimplify.c
    trunk/gcc/gimple.h
    trunk/gcc/gimplify.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/vect/pr18536.c
    trunk/gcc/tree-vect-loop-manip.c

[Bug c/35634] [4.6/4.7 Regression] operand of pre-/postin-/decrement not promoted

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.8.0
            Summary|[4.6/4.7/4.8 Regression]    |[4.6/4.7 Regression]
                   |operand of                  |operand of
                   |pre-/postin-/decrement not  |pre-/postin-/decrement not
                   |promoted                    |promoted
      Known to fail|                            |4.6.3, 4.7.2

--- Comment #38 from Richard Biener <rguenth at gcc dot gnu.org> 2012-11-28 09:28:17 UTC ---
Fixed for 4.8.0.  Unlikely going to be backported.

[Bug c/35634] [4.7 Regression] operand of pre-/postin-/decrement not promoted

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.6.4                       |4.7.4

--- Comment #39 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-04-12 15:16:15 UTC ---
GCC 4.6.4 has been released and the branch has been closed.

[Bug c/35634] [4.7 Regression] operand of pre-/postin-/decrement not promoted

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |su at cs dot ucdavis.edu

--- Comment #40 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 59162 has been marked as a duplicate of this bug. ***

[Bug c/35634] [4.7 Regression] operand of pre-/postin-/decrement not promoted

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

--- Comment #41 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 60229 has been marked as a duplicate of this bug. ***

[Bug c/35634] [4.7 Regression] operand of pre-/postin-/decrement not promoted

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|rguenth at gcc dot gnu.org         |unassigned at gcc dot gnu.org

--- Comment #42 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will not backport this.

[Bug c/35634] [4.7 Regression] operand of pre-/postin-/decrement not promoted

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |mpolacek at gcc dot gnu.org
         Resolution|---                         |FIXED

--- Comment #43 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Let's close it then.

[Bug c/35634] [4.7 Regression] operand of pre-/postin-/decrement not promoted

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35634

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.7.4                       |4.8.0
      Known to fail|                            |4.7.4