[Bug testsuite/35710] FAIL: gcc.dg/vect/section-anchors-pr27770.c (test for excess errors)

[Bug testsuite/35710] FAIL: gcc.dg/vect/section-anchors-pr27770.c (test for excess errors)

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35710

--- Comment #8 from Iain Sandoe <iains at gcc dot gnu.org> 2010-11-29 14:58:25 UTC ---
Author: iains
Date: Mon Nov 29 14:58:16 2010
New Revision: 167242

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=167242
Log:

    PR target/26427
    PR target/33120
    PR testsuite/35710

gcc:
    * config/i386/darwin.h (ASM_OUTPUT_COMMON): Remove
    (ASM_OUTPUT_LOCAL): Likewise.
    * config/darwin-protos.h (darwin_asm_declare_object_name): New.
    (darwin_output_aligned_bss): Likewise.
    (darwin_asm_output_aligned_decl_local): Likewise.
    (darwin_asm_output_aligned_decl_common): Likewise.
    (darwin_use_anchors_for_symbol_p): Likewise.
    * config/rs6000/darwin.h (ASM_OUTPUT_COMMON): Remove.
    (TARGET_ASM_OUTPUT_ANCHOR): Define.
    (TARGET_USE_ANCHORS_FOR_SYMBOL_P): Define.
    (DARWIN_SECTION_ANCHORS): Set to 1.
    * config/darwin.c (emit_aligned_common): New var.
    (darwin_init_sections): Check that the Darwin private zero-size section
    marker is in range.
    (darwin_text_section): Check for zero-sized objects.
    (darwin_mergeable_string_section): Likewise.
    (darwin_mergeable_constant_section): Likewise.
    (machopic_select_section): Adjust to check for zero-sized objects.
    Assert that OBJC meta data are non-zero sized.
    (darwin_asm_declare_object_name): New.
    (darwin_asm_declare_constant_name): Adjust for zero-sized
    object sections.
    (BYTES_ZFILL): Define.
    (darwin_emit_weak_or_comdat): New.
    (darwin_emit_local_bss): New.
    (darwin_emit_common): New.
    (darwin_output_aligned_bss): New.
    (darwin_asm_output_aligned_decl_common): New.
    (darwin_asm_output_aligned_decl_local): New.
    (darwin_file_end): Disable subsections_via_symbols when section
    anchoring is active.
    (darwin_asm_output_anchor): Re-enable.
    (darwin_use_anchors_for_symbol_p): New.
    (darwin_override_options): Check for versions that can emit
    aligned common.  Update usage of flags to current.
    * config/darwin-sections.def: Update comments and flags for
    non-anchor sections.  zobj_const_section, zobj_data_section,
    zobj_bss_section, zobj_const_data_section: New.
    * config/darwin.h (ASM_DECLARE_OBJECT_NAME): Redefine.
    (ASM_OUTPUT_ALIGN): Make whitespace output consistent.
    (L2_MAX_OFILE_ALIGNMENT): Define.
    (ASM_OUTPUT_ALIGNED_BSS): Define.
    (ASM_OUTPUT_ALIGNED_DECL_LOCAL): Define.
    (ASM_OUTPUT_ALIGNED_DECL_COMMON): Define.
    (SECTION_NO_ANCHOR): Define.
    (TARGET_ASM_OUTPUT_ANCHOR) Define with a default of NULL.
    (DARWIN_SECTION_ANCHORS): Define with a default of 0.

boehm-gc:
    * dyn_load.c (GC_register_dynamic_libraries/DARWIN):  Add new writable
    data section names.
    (GC_dyld_name_for_hdr): Adjust layout.
    (GC_dyld_image_add): Adjust layout, add new Darwin sections, adjust
    debug to name the sections.
    (GC_dyld_image_remove): Adjust layout, remove new Darwin sections,
    adjust debug to name the sections.
    (GC_register_dynamic_libraries): Adjust layout.
    (GC_init_dyld): Likewise.
    (GC_register_main_static_data): Likewise.

gcc/testsuite:
    * gcc.target/powerpc/darwin-abi-12.c: Adjust for new allocators.
    * gcc.dg/pr26427.c: Remove redundant warning for powerpc.
    * gcc.dg/darwin-comm.c: Adjust for new allocators.
    * gcc.dg/darwin-sections.c: New test.
    * g++.dg/ext/instantiate2.C: Adjust for new allocators.


Added:
    trunk/gcc/testsuite/gcc.dg/darwin-sections.c
Modified:
    trunk/boehm-gc/ChangeLog
    trunk/boehm-gc/dyn_load.c
    trunk/gcc/ChangeLog
    trunk/gcc/config/darwin-protos.h
    trunk/gcc/config/darwin-sections.def
    trunk/gcc/config/darwin.c
    trunk/gcc/config/darwin.h
    trunk/gcc/config/i386/darwin.h
    trunk/gcc/config/rs6000/darwin.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/ext/instantiate2.C
    trunk/gcc/testsuite/gcc.dg/darwin-comm.c
    trunk/gcc/testsuite/gcc.dg/pr26427.c
    trunk/gcc/testsuite/gcc.target/powerpc/darwin-abi-12.c

[Bug testsuite/35710] FAIL: gcc.dg/vect/section-anchors-pr27770.c (test for excess errors)

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35710

--- Comment #9 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2010-12-06 14:24:15 UTC ---
Iain,

This pr is fixed in trunk. Do you plan to backport it to 4.5 or should I close
it as fixed?

[Bug testsuite/35710] FAIL: gcc.dg/vect/section-anchors-pr27770.c (test for excess errors)

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35710

--- Comment #10 from Iain Sandoe <iains at gcc dot gnu.org> 2010-12-10 12:54:19 UTC ---
(In reply to comment #9)

> This pr is fixed in trunk. Do you plan to backport it to 4.5 or should I close
> it as fixed?

As things stand, I suspect that it's better to concentrate our efforts on
making 4.6 fully functional on Darwin.

However, if 
   (a) all the changes are eligible (i.e. covered by 4.5-regression or
pre-existing bugs) and
   (b) someone wants to do the back-port merge, 

I will be happy to review/test and commit it to 4.5 ...

[Bug testsuite/35710] FAIL: gcc.dg/vect/section-anchors-pr27770.c (test for excess errors)

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35710

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2010-12-16 21:13:57 UTC ---
>From pr35710, comment #24:

> Yeah, I don't think it is too important to back port.  The next release is
> coming out soon, and I don't think its a big issue and has always been there. 
> I'd propose to not back port.

Then closing as fixed. Thanks for the patch.

[Bug testsuite/35710] FAIL: gcc.dg/vect/section-anchors-pr27770.c (test for excess errors)

[iains at gcc dot gnu dot org]

------- Comment #7 from iains at gcc dot gnu dot org  2010-04-14 15:03 -------
see http://gcc.gnu.org/ml/gcc-patches/2010-04/msg00563.html and its follow up.

section anchors are assumed for powerpc-*-* in target supports - so the
"require-effective-target" won't clear the problem unless we exclude darwin
there.

This seems wrong since the target should be able to support these (subject to
people having time to resolve problems).

In order to XFAIL someone would have to go through the dg-final { cleanup-****
and make it possible to XFAIl those too .. 

so, reluctantly, I guess a SKIP is the best current work-around.

http://gcc.gnu.org/ml/gcc-patches/2010-04/msg00783.html


-- 

iains at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |iains at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35710

[Bug testsuite/35710] FAIL: gcc.dg/vect/section-anchors-pr27770.c (test for excess errors)

[dominiq at lps dot ens dot fr]

------- Comment #6 from dominiq at lps dot ens dot fr  2009-06-23 20:49 -------
BTW the problem is still there, see
http://gcc.gnu.org/ml/gcc-testresults/2009-06/msg01902.html

FAIL: gcc.dg/vect/section-anchors-pr27770.c (test for excess errors)
FAIL: gcc.dg/vect/section-anchors-vect-69.c (test for excess errors)
FAIL: gcc.dg/vect/section-anchors-vect-69.c scan-tree-dump-times vect
"Alignment of access forced using peeling" 4


-- 

dominiq at lps dot ens dot fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janis at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35710

[Bug testsuite/35710] FAIL: gcc.dg/vect/section-anchors-pr27770.c (test for excess errors)

[dominiq at lps dot ens dot fr]

------- Comment #5 from dominiq at lps dot ens dot fr  2009-06-23 20:46 -------
> Dominique, to ignore a particular warning you can use dg-prune-output.

Yes I know that, but it is not a general solution.

Could someone make the call for this pr, either with the patch in comment #0 or
by XFAIL powerpc-apple-darwin*, and close it?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35710

[Bug testsuite/35710] FAIL: gcc.dg/vect/section-anchors-pr27770.c (test for excess errors)

[janis at gcc dot gnu dot org]

------- Comment #4 from janis at gcc dot gnu dot org  2008-05-15 21:35 -------
Dominique, to ignore a particular warning you can use dg-prune-output.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35710

[Bug testsuite/35710] FAIL: gcc.dg/vect/section-anchors-pr27770.c (test for excess errors)

[janis at gcc dot gnu dot org]

------- Comment #3 from janis at gcc dot gnu dot org  2008-05-15 21:34 -------
Dorit, are the checks in this test appropriate for powerpc-apple-darwin*?


-- 

janis at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dorit at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35710

[Bug testsuite/35710] FAIL: gcc.dg/vect/section-anchors-pr27770.c (test for excess errors)

[dominiq at lps dot ens dot fr]

------- Comment #2 from dominiq at lps dot ens dot fr  2008-03-27 00:35 -------
(In reply to comment #1)
> Perhaps a better fix would be to exclude darwin from the list of supported
> targets in procedure check_effective_target_section_anchors in
> testsuite/lib/target-supports.exp?

I don't know. The tests pass all the other checks excepted:

FAIL: gcc.dg/vect/section-anchors-vect-69.c scan-tree-dump-times vect
"Alignment of access forced using peeling" 4

(I kept it for another PR), so I don't see why the tests should be excluded for
darwin. The patch just prevents a warning to give a failure for "(test for
excess errors)".


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35710

[Bug testsuite/35710] FAIL: gcc.dg/vect/section-anchors-pr27770.c (test for excess errors)

[ubizjak at gmail dot com]

------- Comment #1 from ubizjak at gmail dot com  2008-03-26 22:55 -------
(In reply to comment #0)
> On powerpc-apple-darwin* we have the following failures (among others):
> 
> FAIL: gcc.dg/vect/section-anchors-pr27770.c (test for excess errors)
> FAIL: gcc.dg/vect/section-anchors-vect-69.c (test for excess errors)
> 
> This can be fixed by the following patch (borrowed from
> gcc/testsuite/gcc.dg/pr26427.c):

>  /* { dg-require-effective-target section_anchors } */ 

Perhaps a better fix would be to exclude darwin from the list of supported
targets in procedure check_effective_target_section_anchors in
testsuite/lib/target-supports.exp?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35710