[Bug fortran/35743] New: allocate negative memory for zero-sized WHERE construct

[Bug fortran/35743] New: allocate negative memory for zero-sized WHERE construct

[dick dot hendrickson at gmail dot com]

The following program fails when rg0025 attempts to allocate a negative
amount of memory under windows XP.  It doesn't abort when the array
subscripts are explicit constants instead of variables.

Dick Hendrickson
      program try_rg0025
! fails on Windows XP
! gcc version 4.4.0 20080312 (experimental) [trunk revision 133139]


      logical lda(5)
      lda = (/ (i/2*2 .ne. I, i=1,5) /)

      call       xx0025(lda,  1,  2,  3,  5,  6, -1, -2)   !works
      call       rg0025(lda,  1,  2,  3,  5,  6, -1, -2)   !fails

      end program

      SUBROUTINE XX0025(LDA,nf1,nf2,nf3,nf5,nf6,mf1,mf2)
      type unseq
            real  r
      end type unseq
      TYPE(UNSEQ) TDA1L(6)
      LOGICAL LDA(NF5)

      TDA1L(1:6)%r = 1.0

      WHERE (LDA(6:3))
        TDA1L(-1:5:-1) = TDA1L(6:2)
      ENDWHERE

      print *, 'end of xx0025'
      END SUBROUTINE

      SUBROUTINE RG0025(LDA,nf1,nf2,nf3,nf5,nf6,mf1,mf2)
      type unseq
            real  r
      end type unseq
      TYPE(UNSEQ) TDA1L(6)
      LOGICAL LDA(NF5)

      TDA1L(1:6)%r = 1.0

      WHERE (LDA(NF6:NF3))
        TDA1L(MF1:NF5:MF1) = TDA1L(NF6:NF2)
      ENDWHERE

      END SUBROUTINE

C:\g_experiments\gfortran>gfortran rg0025.f

C:g_experiments\gfortran>a
 end of xx0025
Fortran runtime error: Attempt to allocate a negative amount of memory.


-- 
           Summary: allocate negative memory for zero-sized WHERE construct
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dick dot hendrickson at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35743

[Bug fortran/35743] allocate negative memory for zero-sized WHERE construct

[dfranke at gcc dot gnu dot org]

------- Comment #1 from dfranke at gcc dot gnu dot org  2008-03-28 23:59 -------
Confirmed. Somewhat simplified testcase:

  logical lda(5)
  lda = (/ (i/2*2 .ne. I, i=1,5) /)

  call rg0025(lda,  1,  2,  3,  5,  6, -1, -2)
end program

SUBROUTINE RG0025(LDA,nf1,nf2,nf3,nf5,nf6,mf1,mf2)
  REAL TDA1L(6)
  LOGICAL LDA(NF5)

  TDA1L(1:6) = 1.0
  WHERE (LDA(NF6:NF3)) TDA1L(MF1:NF5:MF1) = TDA1L(NF6:NF2)
END SUBROUTINE


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dfranke at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
      Known to fail|                            |4.2.3 4.3.0 4.4.0
   Last reconfirmed|0000-00-00 00:00:00         |2008-03-28 23:59:40
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35743

[Bug fortran/35743] allocate negative memory for zero-sized WHERE construct

[dominiq at lps dot ens dot fr]

------- Comment #2 from dominiq at lps dot ens dot fr  2008-03-31 15:14 -------
The dump shows:

rg0025 (lda, nf1, nf2, nf3, nf5, nf6, mf1, mf2)
{
  integer(kind=4) ubound.9;
...
    D.979 = *nf6;
    D.980 = *nf3;
    D.981 = *nf6;
    D.982 = *nf3;
    D.983 = (1 - D.979) + *nf3;
    num.12 = D.983;
    D.986 = num.12;
    if (D.986 < 0)
      {
        _gfortran_runtime_error (&"Attempt to allocate a negative amount of
memory."[1]{lb: 1 sz: 1});
      }
...
      D.999 = *nf6;
      D.1000 = *nf2;
      D.1001 = *mf1;
      D.1002 = *nf5;
      D.1003 = *mf1;
      atmp.19.dtype = 297;
      atmp.19.dim[0].stride = 1;
      atmp.19.dim[0].lbound = 0;
      atmp.19.dim[0].ubound = *nf2 - D.999;
      D.1014 = (*nf2 - D.999) + 1 <= 0;
      D.1015 = (*nf2 - D.999) + 1;
      D.1016 = D.1014 ? 0 : D.1015 * 4;
      if (D.1016 < 0)
        {
          _gfortran_runtime_error (&"Attempt to allocate a negative amount of
memory."[1]{lb: 1 sz: 1});
        }
...
}

The size

    D.986 = num.12;

should have a check similar to

      D.1016 = D.1014 ? 0 : D.1015 * 4;

in order to avoid the runtime error.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35743

[Bug fortran/35743] allocate negative memory for zero-sized WHERE construct

[pault at gcc dot gnu dot org]

-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pault at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-03-28 23:59:40         |2008-04-01 07:24:05
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35743

[Bug fortran/35743] allocate negative memory for zero-sized WHERE construct

[pault at gcc dot gnu dot org]

------- Comment #3 from pault at gcc dot gnu dot org  2008-05-16 21:12 -------
Subject: Bug 35743

Author: pault
Date: Fri May 16 21:12:04 2008
New Revision: 135443

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=135443
Log:
2008-05-16  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/35756
        PR fortran/35759
        * trans-stmt.c (gfc_trans_where): Tighten up the dependency
        check for calling gfc_trans_where_3.

        PR fortran/35743
        * trans-stmt.c (gfc_trans_where_2): Set the mask size to zero
        if it is calculated to be negative.

        PR fortran/35745
        * trans-stmt.c (gfc_trans_where_3, gfc_trans_where_assign): Set
        ss->where for scalar right hand sides.
        * trans-array.c (gfc_add_loop_ss_code): If ss->where is set do
        not evaluate scalars outside the loop.  Clean up whitespace.
        * trans.h : Add a bitfield 'where' to gfc_ss.

2008-05-16  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/35756
        PR fortran/35759
        * gfortran.dg/where_1.f90: New test.

        PR fortran/35743
        PR fortran/35745
        * gfortran.dg/where_2.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/where_1.f90
    trunk/gcc/testsuite/gfortran.dg/where_2.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-array.c
    trunk/gcc/fortran/trans-stmt.c
    trunk/gcc/fortran/trans.h
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35743

[Bug fortran/35743] allocate negative memory for zero-sized WHERE construct

[pault at gcc dot gnu dot org]

------- Comment #4 from pault at gcc dot gnu dot org  2008-05-17 07:11 -------
Subject: Bug 35743

Author: pault
Date: Sat May 17 07:10:13 2008
New Revision: 135461

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=135461
Log:
2008-05-17  Paul Thomas  <pault@gcc.gnu.org>

        Backport from mainline:
        PR fortran/35756
        PR fortran/35759
        * trans-stmt.c (gfc_trans_where): Tighten up the dependency
        check for calling gfc_trans_where_3.

        PR fortran/35743
        * trans-stmt.c (gfc_trans_where_2): Set the mask size to zero
        if it is calculated to be negative.

        PR fortran/35745
        * trans-stmt.c (gfc_trans_where_3, gfc_trans_where_assign): Set
        ss->where for scalar right hand sides.
        * trans-array.c (gfc_add_loop_ss_code): If ss->where is set do
        not evaluate scalars outside the loop.  Clean up whitespace.
        * trans.h : Add a bitfield 'where' to gfc_ss.

       PR fortran/36233
       * interface.c (compare_actual_formal): Do not check sizes if the
       actual is BT_PROCEDURE.

2008-05-17  Paul Thomas  <pault@gcc.gnu.org>

        Backport from mainline:
        PR fortran/35756
        PR fortran/35759
        * gfortran.dg/where_1.f90: New test.

        PR fortran/35743
        PR fortran/35745
        * gfortran.dg/where_2.f90: New test.

       PR fortran/36233
       * gfortran.dg/actual_procedure_1.f90: New test

Added:
    branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/actual_procedure_1.f90
    branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/where_1.f90
    branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/where_2.f90
Modified:
    branches/gcc-4_3-branch/gcc/fortran/ChangeLog
    branches/gcc-4_3-branch/gcc/fortran/interface.c
    branches/gcc-4_3-branch/gcc/fortran/trans-array.c
    branches/gcc-4_3-branch/gcc/fortran/trans-stmt.c
    branches/gcc-4_3-branch/gcc/fortran/trans.h
    branches/gcc-4_3-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35743

[Bug fortran/35743] allocate negative memory for zero-sized WHERE construct

[pault at gcc dot gnu dot org]

------- Comment #5 from pault at gcc dot gnu dot org  2008-05-17 07:17 -------
Fixed on trunk and 4.3.

Thanks for the report.

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35743