[Bug testsuite/36057] New: struct-layout-1_generate.c uses non-standard '%n$' operand number formats

[Bug testsuite/36057] New: struct-layout-1_generate.c uses non-standard '%n$' operand number formats

[dannysmith at users dot sourceforge dot net]

This commit 
2008-02-20  Uros Bizjak  <ubizjak@gmail.com>

        * g++.dg/compat/struct-layout-1_generate.c (DG_OPTIONS): New define.
        (switchfiles): Use DG_OPTIONS. Explicitly name arguments in fprintf
        templates to reduce number of passed arguments.

breaks the G++  struct-layout tests on MS Windows since the host printf family
does not support the '%n$' extension.  The dg-options in generated files 
look like 
 /* { dg-options "-w $s -I$s" } */

After reverting that patch all 150 tescase succeed.


-- 
           Summary: struct-layout-1_generate.c  uses non-standard  '%n$'
                    operand number formats
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dannysmith at users dot sourceforge dot net
 GCC build triplet: i686-pc-mingw32
  GCC host triplet: i686-pc-mingw32
GCC target triplet: i686-pc-mingw32


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36057

[Bug testsuite/36057] struct-layout-1_generate.c uses non-standard '%n$' operand number formats

[ubizjak at gmail dot com]

------- Comment #1 from ubizjak at gmail dot com  2008-04-27 05:49 -------
"IEEE Std 1003.1, 2004 Edition" [1] says:

Conversions can be applied to the nth argument after the format in the argument
list, rather than to the next unused argument. In this case, the conversion
specifier character % (see below) is replaced by the sequence "%n$", where n is
a decimal integer in the range [1,{NL_ARGMAX}], giving the position of the
argument in the argument list. This feature provides for the definition of
format strings that select arguments in an order appropriate to specific
languages (see the EXAMPLES section).

[1] http://www.opengroup.org/onlinepubs/009695399/functions/printf.html

Due to this, I would say that "%n$" is not non-standard.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|struct-layout-1_generate.c  |struct-layout-1_generate.c
                   |uses non-standard  '%n$'    |uses non-standard  '%n$'
                   |operand number formats      |operand number formats


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36057

[Bug testsuite/36057] struct-layout-1_generate.c uses non-ISO C '%n$' operand number formats

[dannysmith at users dot sourceforge dot net]

------- Comment #2 from dannysmith at users dot sourceforge dot net  2008-04-27 06:03 -------
Changed summary to be more precise about "non-standard".


-- 

dannysmith at users dot sourceforge dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|struct-layout-1_generate.c  |struct-layout-1_generate.c
                   |uses non-standard  '%n$'    |uses non-ISO C  '%n$'
                   |operand number formats      |operand number formats


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36057

[Bug testsuite/36057] [4.4 Regression] struct-layout-1_generate.c uses non-ISO C '%n$' operand number formats

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2008-05-12 20:41 -------
(In reply to comment #3)
> I saw this too.

On cygwin.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  GCC build triplet|i686-pc-mingw32             |
   GCC host triplet|i686-pc-mingw32             |
 GCC target triplet|i686-pc-mingw32             |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36057

[Bug testsuite/36057] [4.4 Regression] struct-layout-1_generate.c uses non-ISO C '%n$' operand number formats

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2008-05-12 20:41 -------
I saw this too.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-05-12 20:41:24
               date|                            |
            Summary|struct-layout-1_generate.c  |[4.4 Regression] struct-
                   |uses non-ISO C  '%n$'       |layout-1_generate.c  uses
                   |operand number formats      |non-ISO C  '%n$'  operand
                   |                            |number formats
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36057

[Bug testsuite/36057] [4.3/4.4 Regression] struct-layout-1_generate.c uses non-ISO C '%n$' operand number formats

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.4 Regression] struct-    |[4.3/4.4 Regression] struct-
                   |layout-1_generate.c  uses   |layout-1_generate.c  uses
                   |non-ISO C  '%n$'  operand   |non-ISO C  '%n$'  operand
                   |number formats              |number formats
   Target Milestone|4.4.0                       |4.3.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36057

[Bug testsuite/36057] [4.3/4.4 Regression] struct-layout-1_generate.c uses non-ISO C '%n$' operand number formats

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36057

[Bug testsuite/36057] [4.3/4.4 Regression] struct-layout-1_generate.c uses non-ISO C '%n$' operand number formats

[ubizjak at gmail dot com]

------- Comment #5 from ubizjak at gmail dot com  2008-05-17 13:10 -------
(In reply to comment #4)

> > I saw this too.
> On cygwin.

Sigh. Patch at http://gcc.gnu.org/ml/gcc-patches/2008-05/msg01019.html.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |ubizjak at gmail dot com
                   |dot org                     |
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2008-
                   |                            |05/msg01019.html
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-05-12 20:41:24         |2008-05-17 13:10:01
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36057

[Bug testsuite/36057] [4.3/4.4 Regression] struct-layout-1_generate.c uses non-ISO C '%n$' operand number formats

[uros at gcc dot gnu dot org]

------- Comment #6 from uros at gcc dot gnu dot org  2008-05-20 19:02 -------
Subject: Bug 36057

Author: uros
Date: Tue May 20 19:01:46 2008
New Revision: 135671

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=135671
Log:
        PR testsuite/36057
        * g++.dg/compat/struct-layout-1_generate.c (DG_OPTIONS): Remove.
        (const char *dg_options): New array.
        (switchfiles): Loop through dg_options array to generate dg-options
        directives.  Remove numbered arguments usage from fprintf
        format strings.


Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/compat/struct-layout-1_generate.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36057

[Bug testsuite/36057] [4.4 Regression] struct-layout-1_generate.c uses non-ISO C '%n$' operand number formats

[ubizjak at gmail dot com]

------- Comment #7 from ubizjak at gmail dot com  2008-05-20 19:06 -------
Fixed.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Summary|[4.3/4.4 Regression] struct-|[4.4 Regression] struct-
                   |layout-1_generate.c  uses   |layout-1_generate.c  uses
                   |non-ISO C  '%n$'  operand   |non-ISO C  '%n$'  operand
                   |number formats              |number formats
   Target Milestone|4.3.1                       |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36057