[Bug c++/36308] New: OpenMP privatized vars don't get dtors called if they are virtual

[Bug c++/36308] New: OpenMP privatized vars don't get dtors called if they are virtual

[jakub at gcc dot gnu dot org]

// { dg-do run }

#include <omp.h>
#include <assert.h>

#define N 10

struct B
{
  static int icount;
  static int ccount;
  static int dcount;
  static int xcount;

  B ();
  B (const B &);
  virtual ~B ();
  B& operator= (const B &);
  void doit ();
  static void clear () { icount = ccount = dcount = xcount = 0; }
};

int B::icount;
int B::ccount;
int B::dcount;
int B::xcount;

B::B ()
{
  #pragma omp atomic 
    icount++;
}

B::B (const B &)
{
  #pragma omp atomic
    ccount++;
}

B::~B ()
{
  #pragma omp atomic
    dcount++;
}

void
B::doit ()
{
  #pragma omp atomic
    xcount++;
}

static int nthreads;

void
test1 ()
{
  B b[N];
  #pragma omp parallel private (b)
    {
      #pragma omp master
        nthreads = omp_get_num_threads ();
      b[0].doit ();
    }
}

void
test2 ()
{
  B b;
  #pragma omp parallel firstprivate (b)
    {
      #pragma omp single
        nthreads = omp_get_num_threads ();
      b.doit ();
    }
}

int
main ()
{
  omp_set_dynamic (0);
  omp_set_num_threads (4);

  B::clear ();
  test1 ();
  assert (B::xcount == nthreads);
  assert (B::ccount == 0);
  assert (B::icount == (nthreads + 1) * N);
  assert (B::dcount == (nthreads + 1) * N);

  B::clear ();
  test2 ();
  assert (B::xcount == nthreads);
  assert (B::ccount == nthreads);
  assert (B::icount == 1);
  assert (B::dcount == nthreads + 1);
  return 0;
}

fails when the dtor is virtual, succeeds when it is not virtual.
finish_omp_clauses calls get_callee_fndecl, but in this case on CALL_EXPR
with OBJ_TYPE_REF inside and thus returns NULL.  We always know the type of the
var at compile time, so we just should use cp_fold_obj_type_ref in this case.


-- 
           Summary: OpenMP privatized vars don't get dtors called if they
                    are virtual
           Product: gcc
           Version: 4.3.1
            Status: UNCONFIRMED
          Keywords: openmp
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: jakub at gcc dot gnu dot org
        ReportedBy: jakub at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36308

[Bug c++/36308] OpenMP privatized vars don't get dtors called if they are virtual

[jakub at gcc dot gnu dot org]

------- Comment #1 from jakub at gcc dot gnu dot org  2008-05-23 11:53 -------
Subject: Bug 36308

Author: jakub
Date: Fri May 23 11:52:44 2008
New Revision: 135798

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=135798
Log:
        PR c++/36308
        * semantics.c (omp_clause_info_fndecl): New function.
        (finish_omp_clauses): Use it.

        * testsuite/libgomp.c++/ctor-11.C: New test.
        * testsuite/libgomp.c++/ctor-12.C: New test.

Added:
    trunk/libgomp/testsuite/libgomp.c++/ctor-11.C
    trunk/libgomp/testsuite/libgomp.c++/ctor-12.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/semantics.c
    trunk/libgomp/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36308

[Bug c++/36308] OpenMP privatized vars don't get dtors called if they are virtual

[jakub at gcc dot gnu dot org]

------- Comment #2 from jakub at gcc dot gnu dot org  2008-05-23 12:17 -------
Subject: Bug 36308

Author: jakub
Date: Fri May 23 12:16:41 2008
New Revision: 135800

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=135800
Log:
        PR c++/36308
        * semantics.c (omp_clause_info_fndecl): New function.
        (finish_omp_clauses): Use it.

        * testsuite/libgomp.c++/ctor-11.C: New test.
        * testsuite/libgomp.c++/ctor-12.C: New test.

Added:
    branches/gcc-4_3-branch/libgomp/testsuite/libgomp.c++/ctor-11.C
    branches/gcc-4_3-branch/libgomp/testsuite/libgomp.c++/ctor-12.C
Modified:
    branches/gcc-4_3-branch/gcc/cp/ChangeLog
    branches/gcc-4_3-branch/gcc/cp/semantics.c
    branches/gcc-4_3-branch/libgomp/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36308

[Bug c++/36308] OpenMP privatized vars don't get dtors called if they are virtual

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-05-23 13:31:56
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36308

[Bug c++/36308] OpenMP privatized vars don't get dtors called if they are virtual

[jakub at gcc dot gnu dot org]

------- Comment #3 from jakub at gcc dot gnu dot org  2008-05-23 13:34 -------
Fixed for 4.3/4.4.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36308