[Bug driver/36312] should refuse to overwrite input file with output file

["manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 8741 bytes --]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36312

--- Comment #8 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Author: manu
Date: Wed Nov  5 17:23:46 2014
New Revision: 217149

URL: https://gcc.gnu.org/viewcvs?rev=217149&root=gcc&view=rev
Log:

gcc/testsuite/ChangeLog:

2014-11-05  Anthony Brandon  <anthony.brandon@gmail.com>

    PR driver/36312
    * gcc.misc-tests/output.exp: New test case for identical input and
    output files.

include/ChangeLog:

2014-11-05  Anthony Brandon  <anthony.brandon@gmail.com>

    PR driver/36312
    * filenames.h: Add prototype for canonical_filename_eq.

gcc/ChangeLog:

2014-11-05  Anthony Brandon  <anthony.brandon@gmail.com>

    PR driver/36312
    * diagnostic-core.h: Add prototype for fatal_error.
    * diagnostic.c (fatal_error): New function fatal_error.
    * gcc.c (store_arg): Remove have_o_argbuf_index.
    (process_command): Check if input and output files are the same.
    * toplev.c (init_asm_output): Check if input and output files are
    the same.

libiberty/ChangeLog:

2014-11-05  Anthony Brandon  <anthony.brandon@gmail.com>

    PR driver/36312
    * filename_cmp.c (canonical_filename_eq): New function to check if
    file names are the same.
    * functions.texi: Updated with documentation for new function.

Added:
    trunk/gcc/testsuite/gcc.misc-tests/output.exp
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/diagnostic-core.h
    trunk/gcc/diagnostic.c
    trunk/gcc/gcc.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/toplev.c
    trunk/include/ChangeLog
    trunk/include/filenames.h
    trunk/libiberty/ChangeLog
    trunk/libiberty/filename_cmp.c
    trunk/libiberty/functions.texi
>From gcc-bugs-return-465821-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Nov 05 17:32:41 2014
Return-Path: <gcc-bugs-return-465821-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 9806 invoked by alias); 5 Nov 2014 17:32:41 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 9748 invoked by uid 48); 5 Nov 2014 17:32:34 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug driver/36312] should refuse to overwrite input file with output file
Date: Wed, 05 Nov 2014 17:32:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: driver
X-Bugzilla-Version: 4.1.2
X-Bugzilla-Keywords: diagnostic, patch
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-36312-4-p1RrkO1xnN@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-36312-4@http.gcc.gnu.org/bugzilla/>
References: <bug-36312-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg00293.txt.bz2
Content-length: 645

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36312

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Anthony Brandon updated my patch and added a testcase, so this is fixed in GCC
5.0. This was his second contribution to GCC, which shows that "Contributing to
GCC is hard" is a myth.
>From gcc-bugs-return-465822-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Nov 05 17:37:56 2014
Return-Path: <gcc-bugs-return-465822-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 16043 invoked by alias); 5 Nov 2014 17:37:56 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 16031 invoked by uid 89); 5 Nov 2014 17:37:53 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2
X-HELO: service87.mimecast.com
Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Nov 2014 17:37:51 +0000
Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 05 Nov 2014 17:37:49 +0000
Received: from e105689-lin.cambridge.arm.com ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959);	 Wed, 5 Nov 2014 17:37:48 +0000
Message-ID: <545A606C.8010103@arm.com>
Date: Wed, 05 Nov 2014 17:37:00 -0000
From: Richard Earnshaw <rearnsha@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Michael Felt <aixtools@gmail.com>, gcc-bugs@gcc.gnu.org
Subject: Re: Suggestions welcomed to get bootstrap to work
References: <CANvxniXPvdjBFxnmgusbxfHkmNniUQFgpDeu_vzhBL869LXUkw@mail.gmail.com> <CANvxniWM¶MbnFJCKW6x0RAmKmxA6xTCnE6ke8v8cZR7d4KYQ@mail.gmail.com>
In-Reply-To: <CANvxniWM¶MbnFJCKW6x0RAmKmxA6xTCnE6ke8v8cZR7d4KYQ@mail.gmail.com>
X-MC-Unique: 114110517374901401
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
X-SW-Source: 2014-11/txt/msg00294.txt.bz2
Content-length: 2345

You would probably be better of discussing this on gcc-help.  gcc-bugs
is rather full of bugzilla traffic and normal mails are easily missed.

Have you tried setting CONFIG_SHELL in the environment?  Also, when
running the build use something like

make SHELL=/bin/bash

R.

On 03/11/14 20:22, Michael Felt wrote:
> What I have not yet found is how to get the SHELL variable to not use
> /bin/sh because this is causing a failure immediately at the start of
> make:
> 
> root@x064:[/data/prj/gnu/gcc/objdir/gcc-4.7.4]make
> [ -f stage_final ] || echo stage3 > stage_final
> /bin/sh[3]: 0403-057 Syntax error at line 1 : `-qlanglvl=extc89' is
> not expected.
> make: *** [all] Error 2
> 
> Setting a link from /bin/sh to "bash" is just a way of breaking the
> host. I hope there is be a normal way to resolve this.
> 
> regards,
> Michael
> 
> p.s. 4.5.4 fails elsewhere - it does not come as far as 4.7.4 or 4.6.4
> 
> On Mon, Nov 3, 2014 at 9:19 PM, Michael Felt <aixtools@gmail.com> wrote:
>> I fear that after being set to "wontfix" an entry such as
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63714 will be completely
>> ignored.
>>
>>
>> That is not what I was expecting having spent nearly 8 hours yesterday
>> looking for something I may have missed.
>>
>> I do not understand how to move forward from: Don't bootstrap GCC with
>> IBM XLC. - considering that is the compiler I have.
>>
>> As I commented in the "bug" above, there are issues I have run into
>> with gcc from other sources. If it turns out there is no other way,
>> then that shall be the path forced upon me - but I prefer to research
>> and package my own so that the demands on the host finally get
>> documented - rather than libraries that step on each other and damage
>> existing programs.
>>
>> That my submission is on the "bug-list" is because that is what seemed
>> to be the correct path to submit a question. That gcc decides to never
>> include any result in the source tree is of course your choice.
>>
>> I merely wish to express my hope for some sort of assistance in moving
>> forward versus a stonewall of "don't care".
>>
>> FYI: I am trying 4.5.4 now as well, but I fear the same result.
>>
>> Maybe it is just a shell thing (e.g. needs a specific bash behavior)
>>
>> I shall continue to post, suggestions welcome.
>>
>> Michael