[Bug libfortran/36657] New: Namelist reading bug with string constant immediately followed by comment

[Bug libfortran/36657] New: Namelist reading bug with string constant immediately followed by comment

[anlauf at gmx dot de]

Hi,

the following program shows a runtime bug with gfortran 4.3.x:

% cat gfcbug79.f90 
program gfcbug79
  implicit none

  integer, parameter :: nnml = 10

  character(len=8)  :: model = ""
  namelist /NML/       model

  open (nnml, file='gfcbug79.nml')
  write(nnml,*) "&nml"
  write(nnml,*) "  model='foo'! This is a just comment"
  write(nnml,*) "/"
  rewind(nnml)
  read (nnml, nml=NML)
  close(nnml)
  write (*,nml=NML)
end program gfcbug79
% gfc gfcbug79.f90 && ./a.out 
At line 14 of file gfcbug79.f90 (unit = 10, file = 'gfcbug79.nml')
Fortran runtime error: Invalid string input in item 0
%

Inserting a blank before the comment character ("!")
is a workaround, but gfortran should nevertheless be fixed.

Cheers,
-ha


-- 
           Summary: Namelist reading bug with string constant immediately
                    followed by comment
           Product: gcc
           Version: 4.3.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: anlauf at gmx dot de
  GCC host triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36657

[Bug libfortran/36657] Namelist reading bug with string constant immediately followed by comment

[jvdelisle at gcc dot gnu dot org]

------- Comment #1 from jvdelisle at gcc dot gnu dot org  2008-06-28 01:34 -------
I will investigate this.  i have another namelist patch I am working as well.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jvdelisle at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-06-28 01:34:59
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36657

[Bug libfortran/36657] Namelist reading bug with string constant immediately followed by comment

[jvdelisle at gcc dot gnu dot org]

------- Comment #2 from jvdelisle at gcc dot gnu dot org  2008-06-28 21:47 -------
Subject: Bug 36657

Author: jvdelisle
Date: Sat Jun 28 21:46:53 2008
New Revision: 137236

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=137236
Log:
2008-06-28  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/36657
        * io/list_read.c (read_character): Check for '!' along with separators.
        (find_nml_name): Likewise and eat the comment if found.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/list_read.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36657

[Bug libfortran/36657] Namelist reading bug with string constant immediately followed by comment

[jvdelisle at gcc dot gnu dot org]

------- Comment #3 from jvdelisle at gcc dot gnu dot org  2008-06-28 21:56 -------
I plan to backport this one to 4.3.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36657

[Bug libfortran/36657] Namelist reading bug with string constant immediately followed by comment

[jvdelisle at gcc dot gnu dot org]

------- Comment #4 from jvdelisle at gcc dot gnu dot org  2008-07-02 04:45 -------
Subject: Bug 36657

Author: jvdelisle
Date: Wed Jul  2 04:44:21 2008
New Revision: 137336

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=137336
Log:
2008-07-01  Jerry DeLisle  <jvdelisle@gcc.gnu.org

        PR fortran/36676
        PR fortran/36657
        PR fortran/36546
        Backport from trunk.
        * io/list_read.c (find_nml_name): Use unget_char before eat_separator.
        (read_character): Check for '!' along with separators.
        (eat_separator): Add tab character to condition for looping past
        whitespace.

Modified:
    branches/gcc-4_3-branch/libgfortran/ChangeLog
    branches/gcc-4_3-branch/libgfortran/io/list_read.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36657

[Bug libfortran/36657] Namelist reading bug with string constant immediately followed by comment

[jvdelisle at gcc dot gnu dot org]

------- Comment #5 from jvdelisle at gcc dot gnu dot org  2008-07-02 04:53 -------
Subject: Bug 36657

Author: jvdelisle
Date: Wed Jul  2 04:52:47 2008
New Revision: 137337

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=137337
Log:
2008-07-01  Jerry DeLisle  <jvdelisle@gcc.gnu.org

        PR fortran/36676
        PR fortran/36657
        PR fortran/36546
        PR fortran/36538
        * gfortran.dg/namelist_50.f90
        * gfortran.dg/namelist_51.f90
        * gfortran.dg/namelist_48.f90
        * gfortran.dg/namelist_49.f90

Added:
    branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/namelist_48.f90
    branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/namelist_49.f90
    branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/namelist_50.f90
    branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/namelist_51.f90
Modified:
    branches/gcc-4_3-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36657

[Bug libfortran/36657] Namelist reading bug with string constant immediately followed by comment

[jvdelisle at gcc dot gnu dot org]

------- Comment #6 from jvdelisle at gcc dot gnu dot org  2008-07-02 05:18 -------
Fixed on Trunk and 4.3


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.3.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36657

[Bug libfortran/36657] Namelist reading bug with string constant immediately followed by comment

[cnstar9988 at gmail dot com]

------- Comment #7 from cnstar9988 at gmail dot com  2008-07-16 14:24 -------
Target Milestone is 4.3.3?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36657

[Bug libfortran/36657] Namelist reading bug with string constant immediately followed by comment

[aldot at gcc dot gnu dot org]

------- Comment #8 from aldot at gcc dot gnu dot org  2008-07-16 14:35 -------
The target milestone does not matter in this case.
The fix will be in the next 4.3.x release which will be 4.3.2, from the looks.


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.3                       |4.3.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36657