[Bug debug/37033] New: [4.4 Regression] Revision 138733 breaks PCH

[Bug debug/37033] New: [4.4 Regression] Revision 138733 breaks PCH

[hjl dot tools at gmail dot com]

Revision 138733 has:

  if (flag_dwarf2_cfi_asm && dwarf2out_do_frame ()) 
    cpp_define (pfile, "__GCC_HAVE_DWARF2_CFI_ASM");

It doesn't work with PCH:

/export/gnu/import/svn/gcc-test/src/gcc/testsuite/gcc.dg/pch/valid-1b.c:3:
warning: ./valid-1b.h.gch: not used because `__GCC_HAVE_DWARF2_CFI_ASM' not
defined
/export/gnu/import/svn/gcc-test/src/gcc/testsuite/gcc.dg/pch/valid-1b.c:3:
error: valid-1b.h: No such file or directory
/export/gnu/import/svn/gcc-test/src/gcc/testsuite/gcc.dg/pch/valid-1b.c:3:
error: one or more PCH files were found, but they were invalid


-- 
           Summary: [4.4 Regression] Revision 138733 breaks PCH
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: debug
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl dot tools at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033

[Bug debug/37033] [4.4 Regression] Revision 138733 breaks PCH

[hjl dot tools at gmail dot com]

------- Comment #1 from hjl dot tools at gmail dot com  2008-08-07 18:58 -------
Created an attachment (id=16037)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16037&action=view)
A testcase

/export/build/gnu/gcc-work/build-x86_64-linux/gcc/xgcc
-B/export/build/gnu/gcc-work/build-x86_64-linux/gcc/ -S  -m32 -O0 -g -I.
-save-temps -Winvalid-pch -o save-temps-1.s save-temps-1.c
save-temps-1.c:2:26: warning: save-temps-1.h.gch: not used because
`__GCC_HAVE_DWARF2_CFI_ASM' not defined
save-temps-1.c:2:26: warning: ./save-temps-1.h.gch: not used because
`__GCC_HAVE_DWARF2_CFI_ASM' not defined
save-temps-1.c:2:26: error: save-temps-1.h: No such file or directory
save-temps-1.c:2:26: error: one or more PCH files were found, but they were
invalid
save-temps-1.c:4:2: error: #error T not defined
make: *** [save-temps-1.s] Error 1
[hjl@gnu-6 pch-1]$ 

The key here is -save-temps. Without it, it works.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033

[Bug debug/37033] [4.4 Regression] Revision 138733 breaks PCH

[hjl dot tools at gmail dot com]

------- Comment #2 from hjl dot tools at gmail dot com  2008-08-07 19:09 -------
The problem is -E never generates any debug info. So __GCC_HAVE_DWARF2_CFI_ASM
won't be defined for -E and PCH gets a mismatch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033

[Bug debug/37033] [4.4 Regression] Revision 138733 breaks PCH

[rth at gcc dot gnu dot org]

------- Comment #3 from rth at gcc dot gnu dot org  2008-08-07 20:07 -------
Subject: Bug 37033

Author: rth
Date: Thu Aug  7 20:06:36 2008
New Revision: 138850

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=138850
Log:
        PR debug/37033
        * gcc.c (cpp_options): Pass along -g*.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gcc.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033

[Bug debug/37033] [4.4 Regression] Revision 138733 breaks PCH

[rth at gcc dot gnu dot org]

------- Comment #4 from rth at gcc dot gnu dot org  2008-08-07 20:11 -------
Fixed.


-- 

rth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033

[Bug debug/37033] [4.4 Regression] Revision 138733 breaks PCH

[hjl dot tools at gmail dot com]

------- Comment #5 from hjl dot tools at gmail dot com  2008-08-09 15:15 -------
It doesn't work on gcc.dg/pch/valid-1b.c since it explicitly tests -g vs -g0:

[hjl@gnu-6 testsuite]$ cat gcc.dg/pch/valid-1b.c
/* { dg-options "-I. -Winvalid-pch -g0" } */

#include "valid-1b.h"

int x;
[hjl@gnu-6 testsuite]$


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033

[Bug debug/37033] [4.4 Regression] Revision 138733 breaks PCH

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2008-08-10 07:28 -------
>It doesn't work on gcc.dg/pch/valid-1b.c since it explicitly tests -g vs -g0:

I don't think valid-1b.c is valid any more in general,  You have to supply -g
to get a valid PCH now that works with -g.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033

[Bug debug/37033] [4.4 Regression] Revision 138733 breaks PCH

[hjl dot tools at gmail dot com]

------- Comment #7 from hjl dot tools at gmail dot com  2008-08-10 16:56 -------
(In reply to comment #6)
> >It doesn't work on gcc.dg/pch/valid-1b.c since it explicitly tests -g vs -g0:
> 
> I don't think valid-1b.c is valid any more in general,  You have to supply -g
> to get a valid PCH now that works with -g.
> 

Should it be removed or updated?


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |geoffk at apple dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033

[Bug debug/37033] [4.4 Regression] Revision 138733 breaks PCH

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033

[Bug debug/37033] [4.4 Regression] Revision 138733 breaks -g vs -g0 for PCH

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033

[Bug debug/37033] [4.4 Regression] Revision 138733 breaks -g vs -g0 for PCH

[janis at gcc dot gnu dot org]

------- Comment #8 from janis at gcc dot gnu dot org  2008-09-09 21:25 -------
Geoff, is test valid-1b.c still valid, given that it uses -g0 with PCH?  If not
I'll remove it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033

[Bug target/37033] [4.4 Regression] Revision 138733 breaks -g vs -g0 for PCH

[ubizjak at gmail dot com]

------- Comment #9 from ubizjak at gmail dot com  2008-11-17 12:27 -------
We can add -fno-dwarf2-cfi-asm to gcc.dg/pch/valid-1b.hs to suppress
definition of __GCC_HAVE_DWARF2_CFI_ASM in -g case.

Patch at http://gcc.gnu.org/ml/gcc-patches/2008-11/msg00807.html


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2008-
                   |                            |11/msg00807.html
             Status|UNCONFIRMED                 |NEW
          Component|debug                       |target
     Ever Confirmed|0                           |1
           Keywords|                            |patch
   Last reconfirmed|0000-00-00 00:00:00         |2008-11-17 12:27:05
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033

[Bug target/37033] [4.4 Regression] Revision 138733 breaks -g vs -g0 for PCH

[geoffk at gcc dot gnu dot org]

------- Comment #10 from geoffk at gcc dot gnu dot org  2008-11-28 07:34 -------
Yes, the test is still valid.  It is reporting a real problem.  I will suggest
a change to __GCC_HAVE_DWARF2_CFI_ASM that permits the testcase to continue
working.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033

[Bug target/37033] [4.4 Regression] Revision 138733 breaks -g vs -g0 for PCH

[aoliva at gcc dot gnu dot org]

------- Comment #11 from aoliva at gcc dot gnu dot org  2008-12-05 06:56 -------
Subject: Bug 37033

Author: aoliva
Date: Fri Dec  5 06:55:12 2008
New Revision: 142459

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142459
Log:
ChangeLog.vta:
PR target/37033
* libcpp/pch.c (cpp_valid_state): Improve message for poisoned
symbols.  Allow for differences in __GCC_HAVE_DWARF2_CFI_ASM.
gcc/ChangeLog.vta:
PR target/37033
* dwarf2out.c (saved_do_cfi_asm): New.
(dwarf2out_do_frame): Take it into account.
(dwarf2out_d_cfi_asm): Likewise.  Set it when appropriate.

Modified:
    branches/var-tracking-assignments-branch/ChangeLog.vta
    branches/var-tracking-assignments-branch/gcc/ChangeLog.vta
    branches/var-tracking-assignments-branch/gcc/dwarf2out.c
    branches/var-tracking-assignments-branch/libcpp/pch.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033

[Bug target/37033] [4.4 Regression] Revision 138733 breaks -g vs -g0 for PCH

[aoliva at gcc dot gnu dot org]

------- Comment #13 from aoliva at gcc dot gnu dot org  2008-12-10 17:32 -------
Subject: Bug 37033

Author: aoliva
Date: Wed Dec 10 17:31:07 2008
New Revision: 142652

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142652
Log:
gcc/ChangeLog:
PR target/37033
* dwarf2out.c (saved_do_cfi_asm): New.
(dwarf2out_do_frame): Take it into account.
(dwarf2out_d_cfi_asm): Likewise.  Set it when appropriate.
libcpp/ChangeLog:
PR target/37033
* pch.c (cpp_valid_state): Improve message for poisoned symbols.
Allow for differences in __GCC_HAVE_DWARF2_CFI_ASM.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/dwarf2out.c
    trunk/libcpp/ChangeLog
    trunk/libcpp/pch.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033

[Bug target/37033] [4.4 Regression] Revision 138733 breaks -g vs -g0 for PCH

[aoliva at gcc dot gnu dot org]

------- Comment #12 from aoliva at gcc dot gnu dot org  2008-12-10 17:31 -------
Fixed.


-- 

aoliva at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aoliva at gcc dot gnu dot
                   |                            |org
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37033