[Bug c/37107] New: Incorrect code generated after function inlining

[Bug c/37107] New: Incorrect code generated after function inlining

[oakad at yahoo dot com]

In the attached file (cfi_flash.c), the function flash_detect_cfi is inlined
into the function flash_get_size. flash_detect_cfi accepts (arg 2) a pointer to
structure defined on stack in flash_get_size. Upon completion, some fields from
the structure in question are referenced (lines 1731 - 1734).

The generated code for the function (flash_get_size.asm, lines 63-70) does none
of these, introducing a nasty runtime bug.

Build parameters:

powerpc-linux-gnuspe-gcc -g  -Os   -fPIC -ffixed-r14 -meabi -D__KERNEL__
-DTEXT_BASE=0xfffc0000 -I/root/u-boot-1.3.3/include -fno-builtin
-ffreestanding -nostdinc
-isystem /usr/local/powerpc/lib/gcc/powerpc-linux-gnuspe/4.3.1/include
-pipe  -DCONFIG_PPC -D__powerpc__ -DCONFIG_MPC85xx -DCONFIG_E500 -ffixed-r2
-Wa,-me500 -msoft-float -mno-string -mno-spe -DCONFIG_E500=1
-DCONFIG_MPC85xx=1 -DCONFIG_MPC8548=1 -Wall -Wstrict-prototypes
-c -o cfi_flash.o cfi_flash.c


-- 
           Summary: Incorrect code generated after function inlining
           Product: gcc
           Version: 4.3.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: oakad at yahoo dot com
 GCC build triplet: x86_64-pc-linux-gnu
  GCC host triplet: x86_64-pc-linux-gnu
GCC target triplet: powerpc-linux-gnuspe


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37107

[Bug c/37107] Incorrect code generated after function inlining

[oakad at yahoo dot com]

------- Comment #1 from oakad at yahoo dot com  2008-08-13 08:10 -------
Created an attachment (id=16063)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16063&action=view)
Original source file


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37107

[Bug c/37107] Incorrect code generated after function inlining

[oakad at yahoo dot com]

------- Comment #2 from oakad at yahoo dot com  2008-08-13 08:10 -------
Created an attachment (id=16064)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16064&action=view)
Assembly of the problematic function


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37107

[Bug middle-end/37107] Incorrect code generated after function inlining

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2008-08-16 22:14 -------
Can you provide the preprocessed source which you can get via the -save-temps
option.  Also does using -fno-strict-aliasing fix the issue?  


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37107

[Bug middle-end/37107] Incorrect code generated after function inlining

[oakad at yahoo dot com]

------- Comment #4 from oakad at yahoo dot com  2008-08-20 06:32 -------
(In reply to comment #3)
> Can you provide the preprocessed source which you can get via the -save-temps
> option.  Also does using -fno-strict-aliasing fix the issue?  
> 

-fno-strict-aliasing appears to have no effect on issue.
Different optimization level (-O2) still generates problematic code.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37107

[Bug middle-end/37107] Incorrect code generated after function inlining

[oakad at yahoo dot com]

------- Comment #5 from oakad at yahoo dot com  2008-08-20 06:33 -------
Created an attachment (id=16103)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16103&action=view)
Preprocessed cfi_flash.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37107

[Bug middle-end/37107] Incorrect code generated after function inlining

[oakad at yahoo dot com]

------- Comment #6 from oakad at yahoo dot com  2008-08-20 06:34 -------
Created an attachment (id=16104)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16104&action=view)
Full assembler output of cfi_flash.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37107

[Bug middle-end/37107] Incorrect code generated after function inlining

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2008-12-27 06:22 -------
How about -fno-delete-null-pointer-checks -O2?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37107