[Bug fortran/37173] Check whether intrinsic assignment between character kind=1 / 4 is allowed

[Bug fortran/37173] Check whether intrinsic assignment between character kind=1 / 4 is allowed

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37173

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |fxcoudert at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |fxcoudert at gcc dot gnu.org

--- Comment #2 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Long overdue, though it's not particularly bad (and it appears noöne uses
non-default character kinds anyway). I'll take care of it.
>From gcc-bugs-return-462711-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Sep 27 15:16:36 2014
Return-Path: <gcc-bugs-return-462711-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 2182 invoked by alias); 27 Sep 2014 15:16:36 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 2145 invoked by uid 48); 27 Sep 2014 15:16:33 -0000
From: "danglin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/63376] [5.0 Regression] ICE: in operator[], at vec.h:736 compiling team.c
Date: Sat, 27 Sep 2014 15:16:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: danglin at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63376-4-sr0HTrk2GD@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63376-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63376-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-09/txt/msg02545.txt.bz2
Content-length: 584

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc376

--- Comment #2 from John David Anglin <danglin at gcc dot gnu.org> ---
This was bug was introduced by r214422:

Author: marxin
Date: Mon Aug 25 13:01:47 2014
New Revision: 214422

URL: https://gcc.gnu.org/viewcvs?rev!4422&root=gcc&view=rev
Log:
IPA C++ refactoring 4/N

    * cgraph.h (symtab_node):
    (bool needed_p (void)): created from decide_is_symbol_needed
    (bool referred_to_p (void)): created from referred_to_p
    (static cgraph_node *get_for_asmname (tree asmname)): created from
symtab_node_for_asm
        ....

[Bug fortran/37173] Check whether intrinsic assignment between character kind=1 / 4 is allowed

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37173

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Francois-Xavier Coudert from comment #2)
> Long overdue

But now changed as the current wording (seemingly as of F2008):

"For an intrinsic assignment statement where the variable is of type character,
if expr has a different kind type parameter, each character c in expr is
converted to the kind type parameterof the variable by ACHAR(IACHAR(c),
KIND(variable))"


See http://j3-fortran.org/doc/year/14/14-007r2.pdf, "7.2.1.3 Interpretation of
intrinsic assignments", paragraph 11.


We still might add a -std=f2008 check there.

[Bug fortran/37173] Check whether intrinsic assignment between character kind=1 / 4 is allowed

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37173

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
In the same document I also see

7.2.1.2 Intrinsic assignment statement

1 An intrinsic assignment statement is an assignment statement that is not a
defined assignment statement (7.2.1.4).

In an intrinsic assignment statement,
...
(5) if the variable is of type character and of ISO 10646, ASCII, or default
character kind, expr shall be of ISO 10646, ASCII, or default character kind,
(6) otherwise if the variable is of type character expr shall have the same
kind type parameter,
...

which seems to conflict with

"For an intrinsic assignment statement where the variable is of type character,
if expr has a different kind type parameter, each character c in expr is
converted to the kind type parameterof the variable by ACHAR(IACHAR(c),
KIND(variable))"

[Bug fortran/37173] Check whether intrinsic assignment between character kind=1 / 4 is allowed

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37173

--- Comment #5 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
(In reply to Tobias Burnus from comment #3)
> We still might add a -std=f2008 check there.

I find the same wording in my local copy of F2003, actually:

"If variable and expr have different kind type parameters, each character c in
expr is converted to the kind type parameter of variable by
ACHAR(IACHAR(c),KIND(variable))."

(ISO/IEC JTC1/SC22/WG5 N1578 dated 2003-10-8)


(In reply to Dominique d'Humieres from comment #4)
> (5) if the variable is of type character and of ISO 10646, ASCII, or default
> character kind, expr shall be of ISO 10646, ASCII, or default character kind,
> (6) otherwise if the variable is of type character expr shall have the same
> kind type parameter,

I think there is a reasonable interpretation where it does not conflict: it
means ISO 10646 and ASCII and default interconvert, but not necessarily other
character kinds. It does not say, for example, "expr shall be of ISO 10646,
ASCII, or default character kind (*respectively*)".

[Bug fortran/37173] Check whether intrinsic assignment between character kind=1 / 4 is allowed

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37173

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |INVALID

--- Comment #6 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
So, given the clear change in wording since the 2008 interp, I close this
report as INVALID.

[Bug fortran/37173] Check whether intrinsic assignment between character kind=1 / 4 is allowed

[fxcoudert at gcc dot gnu dot org]

------- Comment #1 from fxcoudert at gcc dot gnu dot org  2009-03-29 08:52 -------
I think you're right.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|diagnostic                  |accepts-invalid
   Last reconfirmed|0000-00-00 00:00:00         |2009-03-29 08:52:07
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37173