public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "burnus at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/37614]  New: Change position of padding for aligned COMMONs
Date: Mon, 22 Sep 2008 13:29:00 -0000	[thread overview]
Message-ID: <bug-37614-13404@http.gcc.gnu.org/bugzilla/> (raw)

Follow up to PR 37486.
see also http://gcc.gnu.org/ml/fortran/2008-09/msg00366.html

The following program should print "5" but it prints "0" with default options
in gfortran. The problem is that in the program, the common object is padded as
   <4bytes padding> + i + r8
and then in the subroutine, only the first 4 bytes are read and assigned to the
local variable "i".

The program is valid as "Named common blocks of the same name shall be of the
same size in all scoping units of a program in which they appear, but blank
common blocks may be of different sizes."

As tests with NAG f95, Portland pgf95 and Pathscale pathf95 show, these
compilers use
  i + <4bytes padding> + r8
which allows this program to run correctly without sacrificing the alignment. 

(ifort, sunf95 and g95 - and "gfortran -fno-align-commons" work as no padding
is added.)

There are still used but not standard conform versions which fail (cf. examples
in PR 37486) but for those, gfortran has -fno-align-commons.


Test program:
----------------------------------------
subroutine one()
  integer :: i, j
  common i
  print *, i ! shall print "5", in gfortran it is "0"
!
! Testing alternative (invalid standard Fortran):
!  common i,j
!  print *, i,j
end subroutine one

program test
  integer :: i
  real*8 r8
  common i, r8
  i = 5
  r8 = 123457891234d88
  call one()
end program test
----------------------------------------

If one enables the "common  i, j" and runs the program with several compilers,
details about their implementation is revealed:

- gfortran and g77 print "0 5"
- ifort, sunf95 and g95 print "5 1267487353" (= gfortran -fno-align-commons)
- pathscale, pgi, and NAG f95 print "5 0" << expected result when PR is fixed


-- 
           Summary: Change position of padding for aligned COMMONs
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37614


             reply	other threads:[~2008-09-22 13:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-22 13:29 burnus at gcc dot gnu dot org [this message]
2008-10-25  8:28 ` [Bug fortran/37614] " tkoenig at gcc dot gnu dot org
2009-01-15  9:19 ` pault at gcc dot gnu dot org
2009-01-27 20:53 ` [Bug fortran/37614] [Fix pending] " pault at gcc dot gnu dot org
2009-04-04 16:42 ` [Bug fortran/37614] " pault at gcc dot gnu dot org
2009-04-04 16:48 ` pault at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-37614-13404@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).