public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/37710] When peeling an ordinary label off a case-table and making it a default label, strip from the end with identical labels.
Date: Sun, 29 Aug 2021 02:47:53 +0000	[thread overview]
Message-ID: <bug-37710-4-86W1iB6yXi@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-37710-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37710

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note we almost optimize out the testcase now to just:
  <bb 2> [local count: 1073741819]:
  typenum.0_1 = (unsigned int) typenum_4(D);
  _2 = typenum.0_1 + 34;
  if (_2 > 33)
    goto <bb 6>; [34.00%]
  else
    goto <bb 3>; [66.00%]

  <bb 3> [local count: 708669597]:
  _10 = (unsigned int) typenum_4(D);
  _5 = 4294967294 - _10;
  if (_5 <= 1)
    goto <bb 5>; [33.33%]
  else
    goto <bb 4>; [66.67%]

  <bb 4> [local count: 472446402]:

  <bb 5> [local count: 708669603]:
  # prephitmp_8 = PHI <105(4), 115(3)>

  <bb 6> [local count: 1073741824]:
  # _3 = PHI <0(2), prephitmp_8(5)>
  return _3;

Not the problem described here is fixed, just the testcase does not hit it any
more.
Note we currently produce much better code than even LLVM which still does:
        movl    $.L.str, %ecx
        cmpl    $32, %eax
        ja      .LBB0_3
# %bb.2:
        cltq
        movq    .Lswitch.table.main(,%rax,8), %rcx
.LBB0_3:
        movsbl  (%rcx), %eax

       reply	other threads:[~2021-08-29  2:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-37710-4@http.gcc.gnu.org/bugzilla/>
2021-08-29  2:47 ` pinskia at gcc dot gnu.org [this message]
2021-08-29  3:26 ` pinskia at gcc dot gnu.org
2021-08-29  3:30 ` pinskia at gcc dot gnu.org
2008-10-02  0:31 [Bug middle-end/37710] New: " hp at gcc dot gnu dot org
2008-10-02 11:09 ` [Bug middle-end/37710] " rguenth at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-37710-4-86W1iB6yXi@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).