[Bug libfortran/37753] New: [4.4 Regression] Convert="BIG_ENDIAN" reverses character

[Bug libfortran/37753] New: [4.4 Regression] Convert="BIG_ENDIAN" reverses character

[tkoenig at gcc dot gnu dot org]

>From http://gcc.gnu.org/ml/fortran/2008-10/msg00045.html :

$ cat foo.f90
 character(len=16) :: string, string2
  string='BIG_ENDIAN'

open(unit=13,form='unformatted',file='gftest.dat',convert='big_endian',status='UNKNOWN')
  write(13) string
  close(13)
end
$ gfortran foo.f90
$ ./a.out
$ od -t x1 -t a gftest.dat
0000000 00 00 00 10 20 20 20 20 20 20 4e 41 49 44 4e 45
        nul nul nul dle  sp  sp  sp  sp  sp  sp   N   A   I   D   N   E
0000020 5f 47 49 42 00 00 00 10
          _   G   I   B nul nul nul dle
0000030


-- 
           Summary: [4.4 Regression] Convert="BIG_ENDIAN" reverses character
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: major
          Priority: P3
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tkoenig at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37753

[Bug libfortran/37753] [4.4 Regression] Convert="BIG_ENDIAN" reverses character

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37753

[Bug libfortran/37753] [4.4 Regression] Convert="BIG_ENDIAN" reverses character

[jvdelisle at gcc dot gnu dot org]

------- Comment #1 from jvdelisle at gcc dot gnu dot org  2008-10-07 02:54 -------
Thomas, any ideas and do you have time to investigate this?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37753

[Bug libfortran/37753] [4.4 Regression] Convert="BIG_ENDIAN" reverses character

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37753

[Bug libfortran/37753] [4.4 Regression] Convert="BIG_ENDIAN" reverses character

[tkoenig at gcc dot gnu dot org]

------- Comment #2 from tkoenig at gcc dot gnu dot org  2008-10-07 20:41 -------
(In reply to comment #1)
> Thomas, any ideas and do you have time to investigate this?

The problem is right at the beginning of write_unformatted
and read_unformatted.  I think we need to select the normal
write/read on kind==1, not on size==1,  but I will need to do some
more thinking on this.


-- 

tkoenig at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tkoenig at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-10-07 20:41:02
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37753

[Bug libfortran/37753] [4.4 Regression] Convert="BIG_ENDIAN" reverses character

[tkoenig at gcc dot gnu dot org]

------- Comment #3 from tkoenig at gcc dot gnu dot org  2008-10-09 19:30 -------
Subject: Bug 37753

Author: tkoenig
Date: Thu Oct  9 19:28:58 2008
New Revision: 141008

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=141008
Log:
2008-10-09  Thomas Koenig  <tkoenig@gcc.gnu.org>

        PR libfortran/37753
        * io/transfer.c (unformatted_read):  CONVERT_NATIVE
        is the usual case.  Check for kind==1 for non-byte-reversing
        operation.
        (unformatted_write):  Likewise.

2008-10-09  Thomas Koenig  <tkoenig@gcc.gnu.org>

        PR libfortran/37753
        * gfortran.dg/convert_2.f90:  New test case.


Added:
    trunk/gcc/testsuite/gfortran.dg/convert_2.f90
Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/transfer.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37753

[Bug libfortran/37753] [4.4 Regression] Convert="BIG_ENDIAN" reverses character

[tkoenig at gcc dot gnu dot org]

------- Comment #4 from tkoenig at gcc dot gnu dot org  2008-10-09 21:57 -------
Fixed. Closing.


-- 

tkoenig at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37753