[Bug rtl-optimization/37782] New: [4.4 regression] Stage2 ada compiler miscompiled

[Bug rtl-optimization/37782] New: [4.4 regression] Stage2 ada compiler miscompiled

[schwab at suse dot de]

The patch for PR37451 causes the stage2 ada compiler to be miscompiled.

$ ../prev-gcc/xgcc -B../prev-gcc/ -B../root/powerpc64-suse-linux/bin/ -c -g -O2
 -gnatpg -gnata -gnatwns -nostdinc -I- -I. -Iada -I../../gcc/ada
-I../../gcc/ada/gcc-interface ../../gcc/ada/ada.ads -o ada/ada.o
fatal error: system.ads is incorrectly formatted
unrecognized or incorrect restrictions pragma: No_Implicit_Dynamic_Code
compilation abandoned


-- 
           Summary: [4.4 regression] Stage2 ada compiler miscompiled
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: schwab at suse dot de
GCC target triplet: powerpc64-*-*
OtherBugsDependingO 37451
             nThis:


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37782

[Bug rtl-optimization/37782] [4.4 regression] Stage2 ada compiler miscompiled

[doko at ubuntu dot com]

------- Comment #1 from doko at ubuntu dot com  2008-10-13 05:13 -------
seen as well with a powerpc biarch compiler, defaulting to powerpc-linux-gnu.
reverting this patch lets the build continue, but fails later with:

/build/buildd/gcc-snapshot-20081012/build/./prev-gcc/xgcc
-B/build/buildd/gcc-snapshot-20081012/build/./prev-gcc/
-B/usr/lib/gcc-snapshot/powerpc-linux-gnu/bin/ -c -g -O2  -gnatpg -gnata
-nostdinc -I- -I. -Iada -I../../src/gcc/ada -I../../src/gcc/ada/gcc-interface
../../src/gcc/ada/switch.adb -o ada/switch.o
+===========================GNAT BUG DETECTED==============================+
| 4.4.0 20081012 (experimental) [trunk revision 141079]
(powerpc-unknown-linux-gnu) GCC error:|
| in vt_add_function_parameters, at var-tracking.c:3176                    |
| Error detected around ../../src/gcc/ada/switch.adb:123                   |
| Please submit a bug report; see http://gcc.gnu.org/bugs.html.            |
| Use a subject line meaningful to you and us to track the bug.            |
| Include the entire contents of this bug box in the report.               |
| Include the exact gcc or gnatmake command that you entered.              |
| Also include sources listed below in gnatchop format                     |
| (concatenated together with no headers between files).                   |
+==========================================================================+

Please include these source files with error report
Note that list may not be accurate in some cases,
so please double check that the problem can still
be reproduced with the set of files listed.

../../src/gcc/ada/switch.adb
../../src/gcc/ada/switch.ads
../../src/gcc/ada/gnatvsn.ads
../../src/gcc/ada/types.ads
../../src/gcc/ada/osint.ads
../../src/gcc/ada/namet.ads
../../src/gcc/ada/alloc.ads
../../src/gcc/ada/table.ads
../../src/gcc/ada/hostparm.ads
../../src/gcc/ada/output.ads


raised TYPES.UNRECOVERABLE_ERROR : comperr.adb:424
make[5]: *** [ada/switch.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[5]: Leaving directory `/build/buildd/gcc-snapshot-20081012/build/gcc'
make[4]: *** [all-stage2-gcc] Error 2
make[4]: Leaving directory `/build/buildd/gcc-snapshot-20081012/build'
make[3]: *** [stage2-bubble] Error 2
make[3]: Leaving directory `/build/buildd/gcc-snapshot-20081012/build'
make[2]: *** [bootstrap-lean] Error 2


-- 

doko at ubuntu dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |doko at ubuntu dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37782

[Bug rtl-optimization/37782] [4.4 regression] Stage2 ada compiler miscompiled

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37782

[Bug rtl-optimization/37782] [4.4 regression] Stage2 ada compiler miscompiled

[jakub at gcc dot gnu dot org]

------- Comment #2 from jakub at gcc dot gnu dot org  2008-10-14 11:50 -------
I couldn't reproduce this on powerpc64-linux --with-cpu=default32
--enable-languages=ada, I can only reproduce the var-tracking.c ICE which is
already tracked in PR37815.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37782

[Bug rtl-optimization/37782] [4.4 regression] Stage2 ada compiler miscompiled

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37782

[Bug rtl-optimization/37782] [4.4 regression] Stage2 ada compiler miscompiled

[joel at gcc dot gnu dot org]

------- Comment #3 from joel at gcc dot gnu dot org  2008-10-22 15:13 -------
Occurs on powerpc-rtems4.10 as well.

+===========================GNAT BUG DETECTED==============================+
| 4.4.0 20081014 (experimental) [trunk revision 141108]
(powerpc-unknown-rtems4.10) GCC error:|
| in vt_add_function_parameters, at var-tracking.c:3176                    |
| Error detected around a-clrefi.adb:526                                   |
| Please submit a bug report; see http://gcc.gnu.org/bugs.html.            |
| Use a subject line meaningful to you and us to track the bug.            |
| Include the entire contents of this bug box in the report.               |
| Include the exact gcc or gnatmake command that you entered.              |
| Also include sources listed below in gnatchop format                     |
| (concatenated together with no headers between files).                   |
+==========================================================================+


-- 

joel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-10-22 15:13:42
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37782

[Bug rtl-optimization/37782] [4.4 regression] Stage2 ada compiler miscompiled

[schwab at suse dot de]

------- Comment #4 from schwab at suse dot de  2008-10-27 18:33 -------
It's the initialization function of the csets package (csets___elabb) that gets
miscompiled.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37782

[Bug rtl-optimization/37782] [4.4 regression] Stage2 ada compiler miscompiled

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2008-10-27 18:44 -------
Can you attach the RTL dumps, I don't have access to Ada on my PPC64 Linux
machine?  Also what options are you using to configure GCC with?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37782

[Bug rtl-optimization/37782] [4.4 regression] Stage2 ada compiler miscompiled

[schwab at suse dot de]

------- Comment #6 from schwab at suse dot de  2008-10-27 19:30 -------
This is the only difference, occuring in all dumps after this:

--- gcc-test-r141380/Build/gcc/csets.adb.147r.loop2_doloop      2008-10-27
20:21:09.000000000 +0100
+++ gcc-test-r141380.bad/Build/gcc/csets.adb.147r.loop2_doloop  2008-10-27
19:26:46.000000000 +0100
@@ -1488,7 +1488,7 @@
         (nil)))

 (insn 359 324 283 27 ../../gcc/ada/csets.adb:1151 (set (reg:SI 301)
-        (const_int 255 [0xff])) -1 (nil))
+        (const_int -1 [0xffffffffffffffff])) -1 (nil))

 (code_label 283 359 265 28 19 "" [0 uses])

@@ -23507,7 +23507,7 @@
         (const_int 32 [0x20])) 275 {*movqi_internal} (nil))

 (insn 6913 6692 6670 66 ../../gcc/ada/csets.adb:1023 (set (reg:SI 5057)
-        (const_int 132 [0x84])) -1 (nil))
+        (const_int -124 [0xffffffffffffff84])) -1 (nil))

 (note 6670 6913 6671 67 [bb 67] NOTE_INSN_BASIC_BLOCK)



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37782

[Bug rtl-optimization/37782] [4.4 regression] Stage2 ada compiler miscompiled

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2008-10-27 19:41 -------
Created an attachment (id=16570)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16570&action=view)
Patch which needs to be tested

Ok, I think I know what the issue is now, I actually fixed this locally in the
PS3 compiler.  The issue is we are doing the addition/zero extend in the wrong
mode.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37782

[Bug rtl-optimization/37782] [4.4 regression] Stage2 ada compiler miscompiled

[schwab at suse dot de]

------- Comment #8 from schwab at suse dot de  2008-10-27 22:06 -------
Bootstrap was successful.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37782

[Bug rtl-optimization/37782] [4.4 regression] Stage2 ada compiler miscompiled

[joel at gcc dot gnu dot org]

------- Comment #9 from joel at gcc dot gnu dot org  2008-10-29 16:30 -------
ACATS results for powerpc-rtems4.10 with the "maybefix"

http://gcc.gnu.org/ml/gcc-testresults/2008-10/msg02107.html

They look very good with 6 failure cases. 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37782

[Bug rtl-optimization/37782] [4.4 regression] Stage2 ada compiler miscompiled

[pinskia at gcc dot gnu dot org]

------- Comment #10 from pinskia at gcc dot gnu dot org  2008-10-31 01:40 -------
Mine.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37782

[Bug rtl-optimization/37782] [4.4 regression] Stage2 ada compiler miscompiled

[pinskia at gcc dot gnu dot org]

------- Comment #11 from pinskia at gcc dot gnu dot org  2008-11-03 20:01 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37782

[Bug rtl-optimization/37782] [4.4 regression] Stage2 ada compiler miscompiled

[pinskia at gcc dot gnu dot org]

------- Comment #12 from pinskia at gcc dot gnu dot org  2008-11-03 20:02 -------
Subject: Bug 37782

Author: pinskia
Date: Mon Nov  3 20:01:11 2008
New Revision: 141558

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=141558
Log:
2008-11-03  Andrew Pinski  <andrew_pinski@playstation.sony.com>

        PR rtl-opt/37782
        * loop-doloop.c (doloop_modify): Add from_mode argument that says what
        mode count is in.
        (doloop_optimize): Update call to doloop_modify.



Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/loop-doloop.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37782