[Bug fortran/38113] New: -Warray-temporaries output

[Bug fortran/38113] New: -Warray-temporaries output

[jv244 at cam dot ac dot uk]

The output of -Warray-temporaries could be enhanced:


      CALL fft_1dm ( fft_type, sign, .TRUE., n(2), mx2*mz2, abuf, bbuf, 1.0_lp
)
                                                                1
Warning: Creating array temporary at (1)


I.e. the (1) should maybe point to the variable instead of the ',' so that it
is clear if abuf or bbuf is the offender.


-- 
           Summary: -Warray-temporaries output
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jv244 at cam dot ac dot uk


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38113

[Bug fortran/38113] on warning/error: skip whitespaces, move position marker to actual variable name

[dfranke at gcc dot gnu dot org]

------- Comment #1 from dfranke at gcc dot gnu dot org  2008-11-28 21:13 -------
That's a general problem. Personally, I fully agree. I'd like to see the
whitespaces skipped and the marker moved to the actual variable name.

Thus, confirming (although it's likely that there is another PR somewhere
covering this).


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dfranke at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |diagnostic
   Last reconfirmed|0000-00-00 00:00:00         |2008-11-28 21:13:05
               date|                            |
            Summary|-Warray-temporaries output  |on warning/error: skip
                   |                            |whitespaces, move position
                   |                            |marker to actual variable
                   |                            |name


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38113

[Bug fortran/38113] on warning/error: skip whitespaces, move position marker to actual variable name

[mikael at gcc dot gnu dot org]

------- Comment #2 from mikael at gcc dot gnu dot org  2008-12-15 14:47 -------
Subject: Bug 38113

Author: mikael
Date: Mon Dec 15 14:46:22 2008
New Revision: 142763

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142763
Log:
2008-12-15  Mikael Morin  <mikael.morin@tele2.fr>

        PR fortran/38113
        * error.c (show_locus): Start counting columns at 0.
        * primary.c (match_actual_arg): Eat spaces
        before copying the current locus.
        (match_variable): Copy the locus before matching.


Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/error.c
    trunk/gcc/fortran/primary.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38113

[Bug fortran/38113] on warning/error: skip whitespaces, move position marker to actual variable name

[mikael at gcc dot gnu dot org]

------- Comment #3 from mikael at gcc dot gnu dot org  2008-12-21 15:47 -------
Subject: Bug 38113

Author: mikael
Date: Sun Dec 21 15:45:52 2008
New Revision: 142861

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142861
Log:
2008-12-21  Mikael Morin  <mikael.morin@tele2.fr>

        PR fortran/38113
        * error.c (show_locus): Start counting columns at 0.
        * primary.c (match_actual_arg): Eat spaces
        before copying the current locus.
        (match_variable): Copy the locus before matching.


Modified:
    branches/gcc-4_3-branch/gcc/fortran/ChangeLog
    branches/gcc-4_3-branch/gcc/fortran/error.c
    branches/gcc-4_3-branch/gcc/fortran/primary.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38113

[Bug fortran/38113] on warning/error: skip whitespaces, move position marker to actual variable name

[mikael at gcc dot gnu dot org]

------- Comment #4 from mikael at gcc dot gnu dot org  2008-12-27 18:12 -------
While the original problem is fixed on trunk and 4.3, some more marker problems
popped up as I expected.

from http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38536#c4



/opt/gcc/_gcc_clean/gcc/testsuite/gfortran.dg/pr32601.f03:22.19:

print *, c_null_ptr, t  ! { dg-error "has PRIVATE components" }
                  1
Error: Derived type 'c_ptr' at (1) has PRIVATE components
/opt/gcc/_gcc_clean/gcc/testsuite/gfortran.dg/pr32601.f03:22.24:

print *, c_null_ptr, t  ! { dg-error "has PRIVATE components" }
                       1
Error: Derived type 'c_ptr' at (1) has PRIVATE components
/opt/gcc/_gcc_clean/gcc/testsuite/gfortran.dg/pr32601.f03:23.11:

print *, t ! { dg-error "has PRIVATE components" }
          1
Error: Derived type 'c_ptr' at (1) has PRIVATE components
/opt/gcc/_gcc_clean/gcc/testsuite/gfortran.dg/pr32601.f03:25.25:

print *, c_loc(get_ptr()) ! { dg-error "has PRIVATE components" }
                        1
Error: Derived type 'c_ptr' at (1) has PRIVATE components


-- 

mikael at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |mikael at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-11-28 21:13:05         |2008-12-27 18:12:44
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38113

[Bug fortran/38113] on warning/error: skip whitespaces, move position marker to actual variable name

[mikael at gcc dot gnu dot org]

------- Comment #5 from mikael at gcc dot gnu dot org  2009-01-20 20:00 -------
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38822#c7

  real z(int(transfer(2.e0**2.e0, 1.e0)) + 1)
                                1
Error: Fortran 2003: Noninteger exponent in an initialization expression at (1)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38113

[Bug fortran/38113] on warning/error: skip whitespaces, move position marker to actual variable name

[kargl at gcc dot gnu dot org]

------- Comment #6 from kargl at gcc dot gnu dot org  2009-01-20 21:02 -------
(In reply to comment #5)
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38822#c7
> 
>   real z(int(transfer(2.e0**2.e0, 1.e0)) + 1)
>                                 1
> Error: Fortran 2003: Noninteger exponent in an initialization expression at (1)
> 

Mikael,

Note, this error is incorrect and will not be generated by gfortran when
my patch for pr38823 is accepted.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38113

[Bug fortran/38113] on warning/error: skip whitespaces, move position marker to actual variable name

[mikael at gcc dot gnu dot org]

------- Comment #7 from mikael at gcc dot gnu dot org  2009-01-20 22:37 -------
(In reply to comment #6)
> Note, this error is incorrect and will not be generated by gfortran when
> my patch for pr38823 is accepted.
> 
Your error may or may not eventually go to trunk. 
But the marker is at the wrong place.
That's what I wanted to track.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38113