[Bug bootstrap/38607] AIX error messages about TOC during build

[Bug bootstrap/38607] AIX error messages about TOC during build

[lukasz.filipkowski at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

Lukasz Filipkowski <lukasz.filipkowski at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lukasz.filipkowski at gmail
                   |                            |dot com

--- Comment #15 from Lukasz Filipkowski <lukasz.filipkowski at gmail dot com> 2011-09-23 10:10:58 UTC ---
Hello,

regarding ld: 0711-768 WARNING when compiling:

>   #include <string>
>   #include <map>
>   void foo()
>   {
>     std::map<std::string, std::string> bar;
>   }

into rtl-enabled shared library. Warning is caused by code construction similar
to the one presented in the following example:

   //g++ -save-temps -shared -Wl,-G -o libshare.so share.cc
   #include <iostream>
   #include <string>
   using namespace std;

   template<typename Key> class MyClass
   {
    public:
     typedef Key KeyType;
     MyClass(KeyType aNumber)
     {
         cout << aNumber << "! = " << factorial(aNumber) << endl;
     }
     ~MyClass(){}
    private:
     long factorial(KeyType __x);
     long factorialHelper(KeyType __x);
   };

   template<typename Key> long MyClass<Key>::factorial(KeyType __x)
   {
    if (__x <= 0) return 1;
    else return __x * factorial(__x-1);
    //else return __x * factorialHelper(__x-1);
   }

   template<typename Key> long MyClass<Key>::factorialHelper(KeyType __x)
   {
    return factorial(__x);
   }

   void foo()
   {
    MyClass<int> myClass(5);
   }


$ g++ -save-temps -shared -Wl,-G -o libshare.so share.cc
ld: 0711-768 WARNING: Object share.o, section 1, function
.MyClass<int>::factorial(int):
        The branch at address 0x36c is not followed by a recognized no-op
        or TOC-reload instruction. The unrecognized instruction is 0x7C691B78.


Example code is based on contents of stl_tree.h file in which class _Rb_tree is
defined. 
Warning is generated in case creation of shared libraries using TEMPLATE
CLASSES with RECURSIVE METHODS.
In the presented example "factorial" method is a recursive one.

When modifying:

   template<typename Key> long MyClass<Key>::factorial(KeyType __x)
   {
    if (__x <= 0) return 1;
    else return __x * factorial(__x-1);
    //else return __x * factorialHelper(__x-1);
   }

into:

   template<typename Key> long MyClass<Key>::factorial(KeyType __x)
   {
    if (__x <= 0) return 1;
    //else return __x * factorial(__x-1);
    else return __x * factorialHelper(__x-1);
   }

there is no linker warning.


The _Rb_tree class, defined in stl_tree.h, contains _M_erase and _M_copy
methods, both recursive.

Warning is present when using both GCC4.4.5 and GCC4.6.1 on AIX 5300-11-03-1013
(AIX5.3 TL11 SP03)
When using assembler program (as) from AIX 5300-08-02-0822 (AIX5.3 TL08 SP02)
there is no warning generated.

I'm not sure but problematic warning might be a result of fixes similar to
https://www-304.ibm.com/support/docview.wss?uid=isg1IZ24688

[Bug bootstrap/38607] AIX error messages about TOC during build

[sumamb at yahoo dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

sumamb <sumamb at yahoo dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sumamb at yahoo dot com

--- Comment #16 from sumamb <sumamb at yahoo dot com> 2012-06-20 11:25:30 UTC ---
This is a compiler problem. This issue is not generated due to the apar
IZ24688.

The g++ code is as below.
   #include 
   #include 
   using namespace std;

   template class MyClass
   {
    public:
     typedef Key KeyType;
     MyClass(KeyType aNumber)
     {
         cout << aNumber << "! = " << factorial(aNumber)
 << endl;
     }
     ~MyClass(){}
    private:
     long factorial(KeyType __x);
     long factorialHelper(KeyType __x);
   };

   template long MyClass::factorial
(KeyType __x)
   {
    if (__x <= 0) return 1;
    else return __x * factorial(__x-1);
    //else return __x * factorialHelper(__x-1);
   }

   template long MyClass::
factorialHelper(KeyType __x)
   {
    return factorial(__x);
   }

   void foo()
   {
    MyClass myClass(5);
   }




Compile with:
g++ -save-temps -shared -Wl,-G -o libshare.so share.cc


The error received will be:
ld: 0711-768 WARNING: Object share.o, section 1,
function .MyClass::factorial(int):
        The branch at address 0x36c is not followed
 by a recognized no-op
        or TOC-reload instruction. The unrecognized
instruction is 0x7C691B78.


Here is an explanation from the problem we see with a below example.


    .csect .foo[PR]
.x:    code for x...
.globl .x

.z:    nop
.y:    code for y...
.globl .y

    .csect .bar[PR]
    ...
    bl    .y

The "bl .y" and ".y:" are in different csects, so the "bl" requires an
RLD.  Note that the "bl .y" could also be written as:

    bl    .z + 4
or as
    bl    .foo[PR] + (.y - .x)

The generated code would look the same, but the corresponding RLDs
might refer to different symbols.  That is, "bl .y" would have an RLD
referring to .y, "bl .z+4" would have an RLD referring to .z, and
"bl .foo[PR] + (.y-.x)" would have an RLD referring to .foo[PR].

In the g++ example above, the -G linker flag causes glink code to be used
for all function calls to exported symobls.  These calls need to be
followed by a TOC reload instruction.  If .y were not exported, no
warning would occur.

There are a few possible compiler fixes:

1)    Use ".lglobl .y" instead of ".globl .y"  This will keep .y from
    being exported.
2)    Add another label at the same address and use .lglobl with the
    label.  (The assembler could do this, but it would change the
    behavior of the program, because .y would no longer be superceded by
    the runtime linker.

.y:    
    .globl .y
.y_local: .lglobl .y_local
    ...
    bl    .y_local

Since .y_local cannot be exported, no nop instruction is needed after "bl".

Finally, it is possible for the compiler source code to be:

    .csect .foo[PR]
    ...
.y:    
    ...
    .csect .bar[PR]
    ...
    bl    .y

In this case, .y is not in the output symbol table at all, so the RLD
must refer to the csect .foo[PR].  If this symbol is global and
exported, a warning will still be seen for the missing nop.
Regardless, if branch overflow occurs, this particular branch might
not be able to be fixed up.

[Bug bootstrap/38607] AIX error messages about TOC during build

[sumamb at yahoo dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

--- Comment #17 from sumamb <sumamb at yahoo dot com> 2012-06-20 12:01:51 UTC ---
(In reply to comment #16)

[Bug bootstrap/38607] AIX error messages about TOC during build

[fbissey at slingshot dot co.nz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

François Bissey <fbissey at slingshot dot co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fbissey at slingshot dot
                   |                            |co.nz

--- Comment #18 from François Bissey <fbissey at slingshot dot co.nz> 2012-06-21 00:54:06 UTC ---
I also got this on aix 6.1 with gcc-4.6.3 and 4.7.0. I also see it affecting
program compiled with g++ (gnu octave 3.6.1 in fact). I get the same kind of
TOC warning for octave and when I try to launch it misses two symbols that
should be in libstdc++ (or possibly liibsup++).

I tried to add -Wl,-brtl into configure.host while the warning did go away
while compiling gcc, octave still had the same problem so that's just hiding
the symptoms and not curing the disease.

[Bug bootstrap/38607] AIX error messages about TOC during build

[dje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

David Edelsohn <dje at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code
             Status|UNCONFIRMED                 |NEW
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2012-09/msg00532.htm
                   |                            |l
   Last reconfirmed|                            |2012-09-13
                 CC|                            |dje at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #19 from David Edelsohn <dje at gcc dot gnu.org> 2012-09-13 20:10:17 UTC ---
First, this is a warning from the AIX linker, not an error and not a failure. 
The warning technically is correct but slightly misleading and should not cause
problems.

When the libstdc++ shared library is created for AIX, all global symbols are
exported.  AIX does not understand "visibility" decorations, but GCC uses it to
determine if a function will be local to a translation unit, not requiring a
"nop" after the call. Because they symbols are global and exported, the linker
complains.

GCC -fpic/-fPIC (XLC -qpic) no longer means position independent code, but that
the code will be used in a shared library.  XLC defaults to -qpic, GCC does
not.  Changing GCC for AIX to the XLC default causes other problems, so the
best solution is to add -fPIC to the link line of shared libraries so that GCC
on AIX looks more like GCC on Linux, which is what the patch does.  This
removes all but one warning, which probably is due to a latent bug in G++
itself.

[Bug bootstrap/38607] AIX error messages about TOC during build

[dje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

--- Comment #20 from David Edelsohn <dje at gcc dot gnu.org> 2012-09-14 23:23:45 UTC ---
Author: dje
Date: Fri Sep 14 23:23:41 2012
New Revision: 191316

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=191316
Log:
        PR target/38607
        Merge upstream change.
        * libtool.m4 (_LT_COMPILER_PIC): Add -fPIC to GCC and GXX for AIX.

    * configure.ac: Add target-libquadmath to noconfigdirs for AIX.
        Add libgomp*.o to compare_exclusions for AIX.
        * configure: Regenerate.

Modified:
    trunk/ChangeLog
    trunk/configure.ac
    trunk/libtool.m4

[Bug bootstrap/38607] AIX error messages about TOC during build

[dje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

David Edelsohn <dje at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #21 from David Edelsohn <dje at gcc dot gnu.org> 2013-03-25 20:53:17 UTC ---
The change to libtool to invoke GCC with -fPIC fixes most of the issues.  The
remaining issue (tail recursion in libstdc++) is a incorrect warning from the
AIX linker because it does not recognize that the target of the call -- a
function declared weak because it could be overridden -- is itself.

[Bug bootstrap/38607] AIX error messages about TOC during build

[michael dot haubenwallner at salomon dot at]

------- Comment #14 from michael dot haubenwallner at salomon dot at  2010-06-18 13:44 -------
(In reply to comment #13)
>   #include <string>
>   #include <map>
>   void foo()
>   {
>     std::map<std::string, std::string> bar;
>   }

Simply compiling this source code into an rtl-enabled shared library leads to
that linker warning, with both vanilla gcc-4.5.0 and gcc-4.4.4, configured to
use native as and ld each, on AIX5.3 TL8.

$ g++ -shared -Wl,-G -o libshare.so test.cpp
ld: 0711-768 WARNING: Object /tmp//ccIju3gQ.o, section 1, function *SNIP*:
    The branch at address 0x618 is not followed by a recognized no-op
    or TOC-reload instruction. The unrecognized instruction is 0x801F007C.

The warning isn't shown with the '-bsymbolic' linker flag, as this one
relocation is finally resolved locally and the subsequent 'nop' isn't needed.
But doing symbolic linking doesn't fit as workaround.
Thank you!


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

[Bug bootstrap/38607] AIX error messages about TOC during build

[tammer at tammer dot net]

------- Comment #12 from tammer at tammer dot net  2009-01-12 07:13 -------
Hello,
any news ??
Bye
  Rainer


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

[Bug bootstrap/38607] AIX error messages about TOC during build

[tammer at tammer dot net]

------- Comment #11 from tammer at tammer dot net  2008-12-26 09:10 -------
Created an attachment (id=16988)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16988&action=view)
libstdc++.sum


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

[Bug bootstrap/38607] AIX error messages about TOC during build

[tammer at tammer dot net]

------- Comment #10 from tammer at tammer dot net  2008-12-26 09:07 -------
Created an attachment (id=16987)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16987&action=view)
gcc.sum


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

[Bug bootstrap/38607] AIX error messages about TOC during build

[tammer at tammer dot net]

------- Comment #9 from tammer at tammer dot net  2008-12-26 09:06 -------
Created an attachment (id=16986)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16986&action=view)
g++.sum


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

[Bug bootstrap/38607] AIX error messages about TOC during build

[tammer at tammer dot net]

------- Comment #8 from tammer at tammer dot net  2008-12-26 08:52 -------
Hello,
one small addition. I have tried to add -Wl,-brtl to the xgcc calls (which
produces the libstdc++.so.6) and as a result the ld errors are gone.

/powerpc-ibm-aix5.3.0.0/libstdc++-v3/src/Makefile

OPT_LDFLAGS = -Wl,-G -Wl,-brtl

Bye
  Rainer


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

[Bug bootstrap/38607] AIX error messages about TOC during build

[tammer at tammer dot net]

------- Comment #7 from tammer at tammer dot net  2008-12-26 08:37 -------
Hello,
this problem is present for every call to xgcc with the output of "-o
.libs/libstdc++.so.6".

The resulting library is not correct for AIX.

The error message (example):

ld: 0711-768 WARNING: Object ../libsupc++/.libs/libsupc++convenience.a[vec.o],
section 1, function .__cxa_vec_ctor:
        The branch at address 0xef4 is not followed by a recognized no-op
        or TOC-reload instruction. The unrecognized instruction is 0x801F0038.

says that a function is marked as local but instead resolves to a shared
library function.

See:
http://publib.boulder.ibm.com/infocenter/comphelp/v8v101/index.jsp?topic=/com.ibm.xlcpp8a.doc/compiler/ref/ruoptprc.htm

Bye
  Rainer


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

[Bug bootstrap/38607] AIX error messages about TOC during build

[tammer at tammer dot net]

------- Comment #6 from tammer at tammer dot net  2008-12-24 15:45 -------
Hello,
in addition to IBM XLC/C++ V9 I have tried gcc 4.2.4 (from www.perzl.org) to
bootstrap 4.2.4. The error is always the same. The build finishes but according
to the log the libstdc++.so.6 is not OK. 

I have used the unmodified source. With the following options:

export PATH=/opt/freeware/bin:$PATH
export CONFIG_SHELL=/opt/freeware/bin/bash
export CONFIGURE_ENV_ARGS=/opt/freeware/bin/bash
export CC=gcc
export BOOT_CFLAGS="-O2 -I/opt/freeware/include"
export CFLAGS="-O2 -I/opt/freeware/include"
export CXXFLAGS="-I/opt/freeware/include"
export LIBCFLAGS="-g -O2 -I/opt/freeware/include"
export LIBCXXFLAGS="-g -O2 -I/opt/freeware/include -fno-implicit-templates"
export LDFLAGS="-L/opt/freeware/lib"

./configure \
 --with-as=/usr/bin/as \
 --with-ld=/usr/bin/ld \
 --enable-languages="c,c++,fortran" \
 --prefix=/opt/freeware \
 --enable-threads \
 --enable-version-specific-runtime-libs \
 --disable-nls \
 --enable-decimal-float=dpd \
 --host=powerpc-ibm-aix5.3.0.0

ulimit -d unlimited
ulimit -s unlimited
gmake bootstrap-lean


I see two problems:

1. substitution problem in the linker call for libstdc++.so.6,libgfortran.so.2,
libgomp.so.1,  :

... -Wl,-bnoentry ${wl}-berok

Why is ${wl} not replaced with -Wl, as for -bnoentry ??

2. TOC problem for libstdc++.so.6

ld: 0711-768 WARNING: Object
../libsupc++/.libs/libsupc++convenience.a[eh_terminate.o], section 1
, function .__cxxabiv1::__terminate(void (*)()):
        The branch at address 0x310 is not followed by a recognized no-op
        or TOC-reload instruction. The unrecognized instruction is 0x0.
ld: 0711-768 WARNING: Object
../libsupc++/.libs/libsupc++convenience.a[eh_terminate.o], section 1
, function .std::terminate():
        The branch at address 0x370 is not followed by a recognized no-op
        or TOC-reload instruction. The unrecognized instruction is 0x0.
ld: 0711-768 WARNING: Object
../libsupc++/.libs/libsupc++convenience.a[tinfo.o], section 1, funct
ion .std::type_info::~type_info():
        The branch at address 0x12a0 is not followed by a recognized no-op
        or TOC-reload instruction. The unrecognized instruction is 0x38000000.
.... 

The resulting library is not OK. This is definitely a problem.

Bye
  Rainer


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

[Bug bootstrap/38607] AIX error messages about TOC during build

[tammer at tammer dot net]

------- Comment #5 from tammer at tammer dot net  2008-12-24 11:13 -------
Hello,
the patch did not affect this problem. 
I have started a new build without the patch and the problem is still the same.

I especially do not understand why the linker call for libstdc++.so.6 ends in
${wl}-berok and not in -Wl,-berok. It looks like something got not substituted.
Could this be related to libtool ?? The build machine has libtool 1.5.26
installed.

Bye
  Rainer


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

[Bug bootstrap/38607] AIX error messages about TOC during build

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2008-12-23 17:15 -------
First off, stop building with patches, that makes it harder to figure out what
is going on.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

[Bug bootstrap/38607] AIX error messages about TOC during build

[tammer at tammer dot net]

------- Comment #3 from tammer at tammer dot net  2008-12-23 07:28 -------
Created an attachment (id=16973)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16973&action=view)
gcc-4.2.4-1.spec


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

[Bug bootstrap/38607] AIX error messages about TOC during build

[tammer at tammer dot net]

------- Comment #2 from tammer at tammer dot net  2008-12-23 07:28 -------
Created an attachment (id=16972)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16972&action=view)
gcc-4.2.4-aix.patch


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607

[Bug bootstrap/38607] AIX error messages about TOC during build

[tammer at tammer dot net]

------- Comment #1 from tammer at tammer dot net  2008-12-23 07:28 -------
Created an attachment (id=16971)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16971&action=view)
build log


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38607