public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/38629] target-specific parameters for inline heuristics not defined for AVR
Date: Wed, 10 Nov 2010 20:52:00 -0000 [thread overview]
Message-ID: <bug-38629-4-TBYG4ANpOR@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-38629-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38629
--- Comment #6 from Jan Hubicka <hubicka at gcc dot gnu.org> 2010-11-10 20:52:18 UTC ---
OK, at -Os the issue is that function is called once so inlining is a win.
Making multiple copies of it leads to GCC making clone:
delay_wait_us_ms.constprop.0:
.LFB3:
movl $136, %edi
jmp delay_wait_us
.LFE3:
and then calling it
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
call delay_wait_us_ms.constprop.0
at -Os,that is
With -O2 it is different story, we end up inlining everything. We get:
Analyzing function body size: delay_wait_us
freq: 1000 size: 1 time: 1 __asm__ __volatile__("wdr");
freq: 1000 size: 1 time: 1 MEM[(volatile unsigned char *)82B] ={v}
timeout_2(D);
freq: 1000 size: 1 time: 1 D.2719_5 ={v} MEM[(volatile unsigned char
*)88B];
freq: 1000 size: 1 time: 1 D.2720_6 = D.2719_5 | 1;
freq: 1000 size: 1 time: 1 MEM[(volatile unsigned char *)88B] ={v}
D.2720_6;
freq: 11111 size: 1 time: 1 D.2721_8 ={v} MEM[(volatile unsigned char
*)88B];
freq: 11111 size: 0 time: 0 D.2722_9 = (int) D.2721_8;
freq: 11111 size: 1 time: 1 D.2723_10 = D.2722_9 & 1;
freq: 11111 size: 2 time: 2 if (D.2723_10 == 0)
freq: 1000 size: 1 time: 2 return;
Likely eliminated
Overall function body time: 51-2 size: 10-1
With function call overhead time: 51-13 size: 10-3
that fits in early-inlining-insns. With --param early-inlining-insns=0 we get
it right. GCC inliner is guessing here that inlining such a small leaf
function will result in enough optimization so it pays back. I am not sure what
we can do here, early-inlining-insns is being pushed up by C++ code...
It is not terribly bad tradeoff even at -O2. I will try to get some data how
much early inlining insns cost us at -O2 and if it is too much, I will disable
the allowed growth for functions not declared inline.
next prev parent reply other threads:[~2010-11-10 20:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-38629-4@http.gcc.gnu.org/bugzilla/>
2010-11-10 20:19 ` hubicka at gcc dot gnu.org
2010-11-10 20:52 ` hubicka at gcc dot gnu.org [this message]
2015-04-09 15:43 ` federico at fsfe dot org
2015-04-09 15:47 ` federico at fsfe dot org
2008-12-26 14:58 [Bug c/38629] New: gcc version 4.2.x, 4.3.x and 4.4.0 are doing (too much) automatic inlining with -O1, -O2 and -Os cbm at d81 dot de
2008-12-26 15:41 ` [Bug target/38629] target-specific parameters for inline heuristics not defined for AVR steven at gcc dot gnu dot org
2008-12-26 21:30 ` forwards dot from dot bugzilla at d81 dot de
2008-12-26 21:36 ` pinskia at gcc dot gnu dot org
2008-12-29 20:14 ` rguenth at gcc dot gnu dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-38629-4-TBYG4ANpOR@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).