[Bug libmudflap/38738] libmudflap could be enabled for Solaris when using GNU ld

[Bug libmudflap/38738] libmudflap could be enabled for Solaris when using GNU ld

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38738

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011.06.20 11:23:10
                 CC|                            |ro at gcc dot gnu.org
         AssignedTo|unassigned at gcc dot       |ro at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|---                         |4.7.0
     Ever Confirmed|0                           |1

--- Comment #5 from Rainer Orth <ro at gcc dot gnu.org> 2011-06-20 11:23:10 UTC ---
It doesn't even depend on GNU ld, though: newer versions of Sun ld support
--wrap (resp. -z wrap), too.

I'm working to get this fixed.

  Rainer

[Bug libmudflap/38738] libmudflap could be enabled for Solaris when using GNU ld

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38738

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2011-06/msg01446.htm
                   |                            |l

--- Comment #6 from Rainer Orth <ro at gcc dot gnu.org> 2011-06-20 11:47:05 UTC ---
Initial patch posted.

[Bug libmudflap/38738] libmudflap could be enabled for Solaris when using GNU ld

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38738

--- Comment #7 from Rainer Orth <ro at gcc dot gnu.org> 2011-06-27 16:21:02 UTC ---
Author: ro
Date: Mon Jun 27 16:20:47 2011
New Revision: 175537

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175537
Log:
    gcc:
    PR libmudflap/38738
    * config/sol2.h [!USE_GLD] (MFLIB_SPEC): Define.

    libmudflap:
    PR libmudflap/38738
    * configure.ac: Check for sys/mnttab.h.
    Check for library containing connect.
    * configure: Regenerate.
    * config.h.in: Regenerate.
    * mf-hooks2.c [HAVE_SYS_MNTTAB_H]: Include <sys/mnttab.h>.
    * testsuite/libmudflap.c/pass-stratcliff.c (main) [__sun__ &&
    __svr4__]: Disable rawmemchr, stpcpy, mempcpy tests.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/sol2.h
    trunk/libmudflap/ChangeLog
    trunk/libmudflap/config.h.in
    trunk/libmudflap/configure
    trunk/libmudflap/configure.ac
    trunk/libmudflap/mf-hooks2.c
    trunk/libmudflap/testsuite/libmudflap.c/pass-stratcliff.c

[Bug libmudflap/38738] libmudflap could be enabled for Solaris when using GNU ld

[rob1weld at aol dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38738

--- Comment #8 from Rob <rob1weld at aol dot com> 2011-06-28 06:18:04 UTC ---
Thanks for FIXing, every little bit helps.
Rob

[Bug libmudflap/38738] libmudflap could be enabled for Solaris when using GNU ld

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38738

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Rainer Orth <ro at gcc dot gnu.org> 2011-06-29 10:10:02 UTC ---
Initial fix installed, further improvements will be handled within separate
PRs.

[Bug libmudflap/38738] libmudflap could be enabled for Solaris when using GNU ld

[rob1weld at aol dot com]

------- Comment #4 from rob1weld at aol dot com  2009-03-10 04:27 -------
(In reply to comment #3)
> (In reply to comment #1)

MIRO: Mudflap Improved with Referent Objects - Works on OpenSolaris also.
http://gcc.gnu.org/wiki/MIRO

Results for gcc version 4.4.0 20080520 (experimental) [miro revision 144368]
(GCC) testsuite on i386-pc-solaris2.11
http://gcc.gnu.org/ml/gcc-testresults/2009-02/msg02215.html

Rob


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38738

[Bug libmudflap/38738] libmudflap could be enabled for Solaris when using GNU ld

[rob1weld at aol dot com]

------- Comment #3 from rob1weld at aol dot com  2009-01-18 12:52 -------
(In reply to comment #1)
> for the pass-stratcliff.c failure, change:
> #ifndef __FreeBSD__
> to
> #ifdef __gnu_linux__
> 
> And this should fix the issue there.
> 
> For pass47-frag.c failure, you need to either do a { dg-warning "__ctype" "" {
> target *-*-solaris* } or prune the output of the warning.
> 

I will add those to my next run.


I could not decide where or how to fix the Testsuite with a trivial
patch (that addressed a single issue) to provide the greatest benefit
so for myself I tried something like this:


# svn diff libmudflap/testsuite/mfconfig.exp.in
Index: libmudflap/testsuite/mfconfig.exp.in
===================================================================
--- libmudflap/testsuite/mfconfig.exp.in        (revision 143454)
+++ libmudflap/testsuite/mfconfig.exp.in        (working copy)
@@ -1,4 +1,13 @@
+# We need libsocket to link successfully on OpenSolaris, set
default-extra-flags
+proc solaris_libmudflap_need_lsocket {} {
+  if { [istarget "*-*-solaris*"] } {
+    lappend uselsocket "-lsocket"
+  }
+  return $uselsocket
+}
+
 global mfconfig_libs
-set mfconfig_libs "@LIBS@"
+set uselsocket [solaris_libmudflap_need_lsocket]
+set mfconfig_libs "@LIBS@ $uselsocket "
 global libmudflapth
 set libmudflapth "@build_libmudflapth@"



The code was derived by reading
"gcc_trunk/libjava/testsuite/libjava.jni/jni.exp"
(line 263). The file contains no copyright info whatsoever but it is yours.


That gives us this result:

                === libmudflap Summary ===

# of expected passes            1107
# of unexpected failures        317


Full results are here:

Results for 4.4.0 20090117 (experimental) [trunk revision 143454] (GCC)
testsuite on i386-pc-solaris2.11
http://gcc.gnu.org/ml/gcc-testresults/2009-01/msg01790.html

Rob


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38738

[Bug libmudflap/38738] libmudflap could be enabled for Solaris when using GNU ld

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
  GCC build triplet|i386-pc-solaris2.11         |
   GCC host triplet|i386-pc-solaris2.11         |
 GCC target triplet|i386-pc-solaris2.11         |*-*-solaris*
            Summary|gcc 4.4.0 20090104 -        |libmudflap could be enabled
                   |OpenSolaris can enable      |for Solaris when using GNU
                   |libmudflaps (if gcc is      |ld
                   |configured to use GNU ld)   |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38738