[Bug fortran/38852] New: UBOUND fails for negative stride triplets

[Bug fortran/38852] New: UBOUND fails for negative stride triplets

[dick dot hendrickson at gmail dot com]

The UBOUND function returns zero for subscript triplets that have a negative
stride, such as 5:4:-1.  Fails with both compile-time expressions and run-time
expressions.  LBOUND and SHAPE work correctly on the same triplets.

This might be related to 35685 since I think this started soon after 35685 was
closed.

Dick Hendrickson


      program try_je0031

! fails on Windows XP
! gcc version 4.4.0 20081219 (experimental) [trunk revision 142842] (GCC)

      integer ida(4)
      real dda(5,5,5,5,5)
      call JE0031(IDA,DDA,2,5,-2)

      end 

      SUBROUTINE JE0031(IDA,DDA,nf2,nf5,mf2)
      INTEGER IDA(4)
      REAL DLA(:,:,:,:)
      REAL DDA(5,5,5,5,5)
      POINTER DLA
      TARGET DDA

      DLA => DDA(2:3, 1:3:2, 5:4:-1, NF2, NF5:NF2:MF2)
      IDA = UBOUND(DLA)
      if (any(ida /= 2)) print *, '    run-time ubound', ida

      DLA => DDA(2:3, 1:3:2, 5:4:-1, 2, 5:2:-2)
      IDA = UBOUND(DLA)
      if (any(ida /= 2)) print *, 'compile-time ubound', ida

!these work
      DLA => DDA(2:3, 1:3:2, 5:4:-1, 2, 5:2:-2)
      IDA = shape(DLA)
      if (any(ida /= 2)) print *, ' compile-time shape', ida

      DLA => DDA(2:3, 1:3:2, 5:4:-1, 2, 5:2:-2)
      IDA = LBOUND(DLA)
      if (any(ida /= 1)) print *, 'compile-time lbound', ida

      END SUBROUTINE


C:\gfortran>gfortran try_je0031.f

C:\gfortran>a
     run-time ubound           2           2           0           0
 compile-time ubound           2           2           0           0


-- 
           Summary: UBOUND fails for negative stride triplets
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dick dot hendrickson at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] UBOUND fails for negative stride triplets

[dominiq at lps dot ens dot fr]

------- Comment #1 from dominiq at lps dot ens dot fr  2009-01-14 22:08 -------
Confirmed on i686-apple-darwin9/trunk, it also fails with gfortran 4.2.3 and
4.3.3.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] UBOUND fails for negative stride triplets

[jv244 at cam dot ac dot uk]

------- Comment #2 from jv244 at cam dot ac dot uk  2009-01-15 05:56 -------
looks like this always failed ?


-- 

jv244 at cam dot ac dot uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |32834
              nThis|                            |
           Keywords|                            |wrong-code
      Known to fail|                            |4.2.3 4.3.3 4.4.0 4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] UBOUND fails for negative stride triplets

[jv244 at cam dot ac dot uk]

-- 

jv244 at cam dot ac dot uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-01-15 05:57:57
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] UBOUND fails for negative stride triplets

[mikael at gcc dot gnu dot org]

------- Comment #3 from mikael at gcc dot gnu dot org  2009-01-19 18:48 -------
DLA => DDA(2:3, 1:3:2, 5:4:-1, NF2, NF5:NF2:MF2)

The descriptor built for DLA has negative strides for dimension >= 3. 
This makes ubound fail. 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] UBOUND fails for negative stride triplets

[mikael at gcc dot gnu dot org]

------- Comment #4 from mikael at gcc dot gnu dot org  2009-01-20 22:29 -------
(In reply to comment #3)
> DLA => DDA(2:3, 1:3:2, 5:4:-1, NF2, NF5:NF2:MF2)
> 
> The descriptor built for DLA has negative strides for dimension >= 3. 
> This makes ubound fail. 
> 
Forget this

DLA => DDA(2:3, 1:3:2, 5:4:-1, NF2, NF5:NF2:MF2)

    dla.dim[0].lbound = 1;
    dla.dim[0].ubound = 2;
    dla.dim[0].stride = 1;
    dla.dim[1].lbound = 1;
    dla.dim[1].ubound = 2;
    dla.dim[1].stride = 10;
    dla.dim[2].lbound = 1;
    dla.dim[2].ubound = 2;
    dla.dim[2].stride = -25;
    dla.dim[3].lbound = 1;
    dla.dim[3].ubound = D.1563 + 1;
    dla.dim[3].stride = D.1561 * 625;

There is a distinction to make between user-provided bounds and
front-end-generated bounds. 
   In the former case (original array) the array is non-empty if ubound >
lbound and stride > 0 or if ubound < lbound and stride < 0. 
   In the latter case, it is non-empty if ubound > lbound only. Comparing
ubound and lbound according to the stride to check for zero-sized arrays
doesn't make sense in this case (see dimension 2 of dla). 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] UBOUND fails for negative stride triplets

[pault at gcc dot gnu dot org]

------- Comment #5 from pault at gcc dot gnu dot org  2009-01-22 12:39 -------
(In reply to comment #4)
> (In reply to comment #3)

>    In the latter case, it is non-empty if ubound > lbound only. Comparing
> ubound and lbound according to the stride to check for zero-sized arrays
> doesn't make sense in this case (see dimension 2 of dla). 

Indeed - the fix can be done in gfc_conv_intrinsic_bound.  I will regtest
tonight and submit accordingly.

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pault at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2009-01-15 05:57:57         |2009-01-22 12:39:50
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] UBOUND fails for negative stride triplets

[pault at gcc dot gnu dot org]

------- Comment #6 from pault at gcc dot gnu dot org  2009-01-25 18:21 -------
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> 
> >    In the latter case, it is non-empty if ubound > lbound only. Comparing
> > ubound and lbound according to the stride to check for zero-sized arrays
> > doesn't make sense in this case (see dimension 2 of dla). 
> 
> Indeed - the fix can be done in gfc_conv_intrinsic_bound.  I will regtest
> tonight and submit accordingly.
> 
> Paul
> 

Wrong! - this patch causes several regressions.  I'll have to see how the code
in the pointer assignment should be changed.

Cheers

Paul


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] UBOUND fails for negative stride triplets

[pault at gcc dot gnu dot org]

------- Comment #7 from pault at gcc dot gnu dot org  2009-01-25 21:08 -------
Created an attachment (id=17182)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17182&action=view)
A provisional patch for the PR

It take back what I said previously:-)

The attached bootstraps and regtests OK.

I need to put some thought into the possibility that some fringe cases might
fail, where the lbound is unity.

Cheers

Paul


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] [Fix pending] UBOUND fails for negative stride triplets

[pault at gcc dot gnu dot org]

------- Comment #8 from pault at gcc dot gnu dot org  2009-01-27 12:16 -------
I have done most of the work on the corner cases and the fix below looks good. 
I am marking it as pending for temporary book-keeping purposes.

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|UBOUND fails for negative   |[Fix pending] UBOUND fails
                   |stride triplets             |for negative stride triplets


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] [Fix pending] UBOUND fails for negative stride triplets

[pault at gcc dot gnu dot org]

------- Comment #9 from pault at gcc dot gnu dot org  2009-01-28 17:31 -------
*** Bug 39006 has been marked as a duplicate of this bug. ***


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] [Fix pending] UBOUND fails for negative stride triplets

[pault at gcc dot gnu dot org]

------- Comment #10 from pault at gcc dot gnu dot org  2009-01-28 17:33 -------
Marked up the severity to that of PR39006.

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] [Fix pending] UBOUND fails for negative stride triplets

[pault at gcc dot gnu dot org]

------- Comment #11 from pault at gcc dot gnu dot org  2009-01-28 20:52 -------
Created an attachment (id=17204)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17204&action=view)
Updated patch

Following discussion on fortran list and #gfortran, a more restrictive test is
needed.


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17182|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] [Fix pending] UBOUND fails for negative stride triplets

[pault at gcc dot gnu dot org]

------- Comment #12 from pault at gcc dot gnu dot org  2009-01-28 21:49 -------
Subject: Bug 38852

Author: pault
Date: Wed Jan 28 21:48:53 2009
New Revision: 143743

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143743
Log:
2009-01-28  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/38852
        PR fortran/39006
        * trans-intrinsic.c (gfc_conv_intrinsic_bound): Use the array
        descriptor ubound for UBOUND, when the array lbound == 1.

2009-01-28  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/38852
        PR fortran/39006
        * gfortran.dg/bound_6.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/bound_6.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-intrinsic.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] [4.3] UBOUND fails for negative stride triplets

[pault at gcc dot gnu dot org]

------- Comment #13 from pault at gcc dot gnu dot org  2009-01-28 21:52 -------
Fixed on trunk.

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal
            Summary|[Fix pending] UBOUND fails  |[4.3] UBOUND fails for
                   |for negative stride triplets|negative stride triplets


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] [4.3] UBOUND fails for negative stride triplets

[pault at gcc dot gnu dot org]

------- Comment #15 from pault at gcc dot gnu dot org  2009-02-19 06:44 -------
Fixed on trunk and 4.3

Thanks for the report

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852

[Bug fortran/38852] [4.3] UBOUND fails for negative stride triplets

[pault at gcc dot gnu dot org]

------- Comment #14 from pault at gcc dot gnu dot org  2009-02-19 06:43 -------
Subject: Bug 38852

Author: pault
Date: Thu Feb 19 06:43:15 2009
New Revision: 144286

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=144286
Log:
2009-02-19  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/38852
        PR fortran/39006
        * trans-intrinsic.c (gfc_conv_intrinsic_bound): Use the array
        descriptor ubound for UBOUND, when the array lbound == 1.

2009-02-19  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/38852
        PR fortran/39006
        * gfortran.dg/bound_6.f90: New test.

Added:
    branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/bound_6.f90
Modified:
    branches/gcc-4_3-branch/gcc/fortran/ChangeLog
    branches/gcc-4_3-branch/gcc/fortran/trans-intrinsic.c
    branches/gcc-4_3-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38852