[Bug preprocessor/38987] Including a precompiled header from another header causes invalid assembly to be generated

[Bug preprocessor/38987] Including a precompiled header from another header causes invalid assembly to be generated

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38987

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gafunchal at gmail dot com

--- Comment #11 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-12-05 22:20:24 UTC ---
*** Bug 40272 has been marked as a duplicate of this bug. ***

[Bug preprocessor/38987] Including a precompiled header from another header causes invalid assembly to be generated

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38987

--- Comment #12 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-03-07 09:55:32 UTC ---
Author: rguenth
Date: Wed Mar  7 09:55:26 2012
New Revision: 185029

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=185029
Log:
2012-03-07  Richard Guenther  <rguenther@suse.de>

    PR pch/52518
    PR pch/38987
    * doc/invoke.texi (Precompiled Headers): Remove sentence that
    suggests you can include PCHs from inside another header.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/doc/invoke.texi

[Bug preprocessor/38987] Including a precompiled header from another header causes invalid assembly to be generated

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=38987

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jpyeron at pdinc dot us

--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
*** Bug 64414 has been marked as a duplicate of this bug. ***

[Bug preprocessor/38987] Including a precompiled header from another header causes invalid assembly to be generated

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=38987

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu.org

--- Comment #14 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 31872 has been marked as a duplicate of this bug. ***

[Bug preprocessor/38987] Including a precompiled header from another header causes invalid assembly to be generated

[rguenth at gcc dot gnu dot org]

------- Comment #9 from rguenth at gcc dot gnu dot org  2009-09-22 08:37 -------
Subject: Bug 38987

Author: rguenth
Date: Tue Sep 22 08:37:31 2009
New Revision: 151970

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=151970
Log:
2009-09-22  Richard Guenther  <rguenther@suse.de>

        PR pch/38987
        * files.c (pch_open_file): Disallow non-toplevel PCH inclusion.

Modified:
    trunk/libcpp/ChangeLog
    trunk/libcpp/files.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38987

[Bug preprocessor/38987] Including a precompiled header from another header causes invalid assembly to be generated

[rguenth at gcc dot gnu dot org]

------- Comment #10 from rguenth at gcc dot gnu dot org  2009-09-22 08:38 -------
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Known to work|                            |4.5.0
         Resolution|                            |FIXED
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38987

[Bug preprocessor/38987] Including a precompiled header from another header causes invalid assembly to be generated

[pinskia at gcc dot gnu dot org]

------- Comment #8 from pinskia at gcc dot gnu dot org  2009-04-23 00:11 -------
*** Bug 39854 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ryancacophony at gmail dot
                   |                            |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38987

[Bug preprocessor/38987] Including a precompiled header from another header causes invalid assembly to be generated

[rguenther at suse dot de]

------- Comment #7 from rguenther at suse dot de  2009-02-24 14:52 -------
Subject: Re:  Including a precompiled header from
 another header causes invalid assembly to be generated

On Tue, 24 Feb 2009, frank dot richter at gmail dot com wrote:

> ------- Comment #6 from frank dot richter at gmail dot com  2009-02-24 14:50 -------
> Arguably, that makes precompiled headers less useful - in scenarios where you
> have two big libraries with complicated headers you can at most only use PCHs
> for one of them. Anyhow, that issue is a separate matter.

Using more than one PCH was never possible.

Richard.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38987

[Bug preprocessor/38987] Including a precompiled header from another header causes invalid assembly to be generated

[frank dot richter at gmail dot com]

------- Comment #6 from frank dot richter at gmail dot com  2009-02-24 14:50 -------
Arguably, that makes precompiled headers less useful - in scenarios where you
have two big libraries with complicated headers you can at most only use PCHs
for one of them. Anyhow, that issue is a separate matter.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38987

[Bug preprocessor/38987] Including a precompiled header from another header causes invalid assembly to be generated

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2009-02-24 13:06 -------
This is a preprocessor bug.  We should not use PCHs when it is not the very
first preprocessing directive in the TU that opens it.  Thus, doc/invoke.texi

"
@item
A precompiled header can't be used once the first C token is seen.  You
can have preprocessor directives before a precompiled header; you can
even include a precompiled header from inside another header, so long as
there are no C tokens before the @code{#include}.
"

is very overly optimistic about conditions a PCH is valid.

Tom, do you have an idea where to best restrict the use of PCHs this way?


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at redhat dot com
             Status|UNCONFIRMED                 |NEW
          Component|c++                         |preprocessor
     Ever Confirmed|0                           |1
           Keywords|                            |wrong-code
   Last reconfirmed|0000-00-00 00:00:00         |2009-02-24 13:06:14
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38987