[Bug middle-end/39010] New: [LTO] Memory corruption on gcc.c-torture/compile/limits-fndefn.c

[Bug middle-end/39010] New: [LTO] Memory corruption on gcc.c-torture/compile/limits-fndefn.c

[hjl dot tools at gmail dot com]

On Linux/x86-64, revision 143741

# valgrind --tool=memcheck /export/gnu/import/svn/gcc-test/bld/gcc/cc1 -quiet
-v -imultilib 32 -iprefix
/export/gnu/import/svn/gcc-test/bld/gcc/../lib/gcc/x86_64-unknown-linux-gnu/4.4.0/
-isystem /export/gnu/import/svn/gcc-test/bld/gcc/include -isystem
/export/gnu/import/svn/gcc-test/bld/gcc/include-fixed
/export/gnu/import/svn/gcc-test/src-lto/gcc/testsuite/gcc.c-torture/compile/limits-fndefn.c
-quiet -dumpbase limits-fndefn.c -m32 -mtune=generic -auxbase limits-fndefn -w
-version -flto -o limits-fndefn.s
zsh: correct 'limits-fndefn.c' to 'limits-fndefn.s' [nyae]? 
==5452== Memcheck, a memory error detector.
==5452== Copyright (C) 2002-2007, and GNU GPL'd, by Julian Seward et al.
==5452== Using LibVEX rev 1804, a library for dynamic binary translation.
==5452== Copyright (C) 2004-2007, and GNU GPL'd, by OpenWorks LLP.
==5452== Using valgrind-3.3.0, a dynamic binary instrumentation framework.
==5452== Copyright (C) 2000-2007, and GNU GPL'd, by Julian Seward et al.
==5452== For more details, rerun with: -v
==5452== 
ignoring nonexistent directory
"/export/gnu/import/svn/gcc-test/bld/gcc/../lib/gcc/x86_64-unknown-linux-gnu/4.4.0/include"
ignoring nonexistent directory
"/export/gnu/import/svn/gcc-test/bld/gcc/../lib/gcc/x86_64-unknown-linux-gnu/4.4.0/include-fixed"
ignoring nonexistent directory
"/export/gnu/import/svn/gcc-test/bld/gcc/../lib/gcc/x86_64-unknown-linux-gnu/4.4.0/../../../../x86_64-unknown-linux-gnu/include"
ignoring nonexistent directory
"/usr/local/lib/gcc/x86_64-unknown-linux-gnu/4.4.0/include"
ignoring nonexistent directory
"/usr/local/lib/gcc/x86_64-unknown-linux-gnu/4.4.0/include-fixed"
ignoring nonexistent directory
"/usr/local/lib/../x86_64-unknown-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:
 /export/gnu/import/svn/gcc-test/bld/gcc/include
 /export/gnu/import/svn/gcc-test/bld/gcc/include-fixed
 /usr/local/include
 /usr/include
End of search list.
GNU C (lto merged with rev 143693) version 4.4.0 20090127 (experimental) [lto
revision 143741] (x86_64-unknown-linux-gnu)
        compiled by GNU C version 4.4.0 20090127 (experimental) [lto revision
143741], GMP version 4.2.2, MPFR version 2.3.2.
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
Compiler executable checksum: 422ba1b8d5a8cc825fd0dfb4279ac4e7
==5452== Invalid read of size 1
==5452==    at 0xB908AF: htab_hash_string (hashtab.c:812)
==5452==    by 0xB90F0B: htab_expand (hashtab.c:540)
==5452==    by 0xB91269: htab_find_slot_with_hash (hashtab.c:619)
==5452==    by 0xB23D54: output_string (lto-function-out.c:275)
==5452==    by 0xB242AE: output_tree_flags (lto-function-out.c:532)
==5452==    by 0xB27E9D: output_local_vars (lto-function-out.c:1283)
==5452==    by 0xB2D0A9: lto_output (lto-function-out.c:1968)
==5452==    by 0x667AC8: ipa_write_summaries_2 (passes.c:1403)
==5452==    by 0x66899C: ipa_write_summaries_1 (passes.c:1428)
==5452==    by 0x668A63: ipa_write_summaries (passes.c:1449)
==5452==    by 0x8E3A62: cgraph_optimize (cgraphunit.c:1266)
==5452==    by 0x416732: c_write_global_declarations (c-decl.c:8045)
==5452==  Address 0x4d2625e is 0 bytes after a block of size 6 alloc'd
==5452==    at 0x4A0739E: malloc (vg_replace_malloc.c:207)
==5452==    by 0xB928A7: xmalloc (xmalloc.c:147)
==5452==    by 0xB23DD9: output_string (lto-function-out.c:283)
==5452==    by 0xB27DCC: output_local_vars (lto-function-out.c:1241)
==5452==    by 0xB2D0A9: lto_output (lto-function-out.c:1968)
==5452==    by 0x667AC8: ipa_write_summaries_2 (passes.c:1403)
==5452==    by 0x66899C: ipa_write_summaries_1 (passes.c:1428)
==5452==    by 0x668A63: ipa_write_summaries (passes.c:1449)
==5452==    by 0x8E3A62: cgraph_optimize (cgraphunit.c:1266)
==5452==    by 0x416732: c_write_global_declarations (c-decl.c:8045)
==5452==    by 0x70FD6C: toplev_main (toplev.c:991)
==5452==    by 0x3A0D01E575: (below main) (in /lib64/libc-2.9.so)


-- 
           Summary: [LTO] Memory corruption on gcc.c-torture/compile/limits-
                    fndefn.c
           Product: gcc
           Version: lto
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: dnovillo at google dot com
        ReportedBy: hjl dot tools at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39010

[Bug lto/39010] [LTO] Memory corruption on gcc.c-torture/compile/limits-fndefn.c

[hjl dot tools at gmail dot com]

------- Comment #1 from hjl dot tools at gmail dot com  2009-01-30 21:08 -------
A patch is posted at

http://gcc.gnu.org/ml/gcc-patches/2009-01/msg01533.html


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2009-
                   |                            |01/msg01533.html


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39010

[Bug lto/39010] [LTO] Memory corruption on gcc.c-torture/compile/limits-fndefn.c

[hjl dot tools at gmail dot com]

------- Comment #2 from hjl dot tools at gmail dot com  2009-01-30 21:22 -------
The updated patch is at

http://gcc.gnu.org/ml/gcc-patches/2009-01/msg01534.html


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://gcc.gnu.org/ml/gcc-  |http://gcc.gnu.org/ml/gcc-
                   |patches/2009-               |patches/2009-
                   |01/msg01533.html            |01/msg01534.html


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39010

[Bug lto/39010] [LTO] Memory corruption on gcc.c-torture/compile/limits-fndefn.c

[hjl at gcc dot gnu dot org]

------- Comment #3 from hjl at gcc dot gnu dot org  2009-01-30 21:55 -------
Subject: Bug 39010

Author: hjl
Date: Fri Jan 30 21:55:30 2009
New Revision: 143806

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143806
Log:
2009-01-30  H.J. Lu  <hongjiu.lu@intel.com>

        PR lto/39010
        * lto-function-out.c (output_string): Properly handle the
        trailing '\0'.
        (output_tree_flags): Updated.

Modified:
    branches/lto/gcc/ChangeLog.lto
    branches/lto/gcc/lto-function-out.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39010

[Bug lto/39010] [LTO] Memory corruption on gcc.c-torture/compile/limits-fndefn.c

[hjl dot tools at gmail dot com]

------- Comment #4 from hjl dot tools at gmail dot com  2009-01-30 21:58 -------
Fixed.


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39010

[Bug lto/39010] [LTO] Memory corruption on gcc.c-torture/compile/limits-fndefn.c

[dnovillo at gcc dot gnu dot org]

------- Comment #5 from dnovillo at gcc dot gnu dot org  2009-01-31 18:49 -------
Subject: Bug 39010

Author: dnovillo
Date: Sat Jan 31 18:49:10 2009
New Revision: 143828

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143828
Log:

        Revert

        2009-01-30  H.J. Lu  <hongjiu.lu@intel.com>

                PR lto/39010
                * lto-function-out.c (output_string): Properly handle the
                trailing '\0'.
                (output_tree_flags): Updated.


Modified:
    branches/lto/gcc/ChangeLog.lto
    branches/lto/gcc/lto-function-out.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39010

[Bug lto/39010] [LTO] Memory corruption on gcc.c-torture/compile/limits-fndefn.c

[dnovillo at gcc dot gnu dot org]

------- Comment #6 from dnovillo at gcc dot gnu dot org  2009-01-31 18:51 -------

The patch 

        2009-01-30  H.J. Lu  <hongjiu.lu@intel.com>

                PR lto/39010
                * lto-function-out.c (output_string): Properly handle the
                trailing '\0'.
                (output_tree_flags): Updated.

caused 478 new regressions in the testsuite.  Reverted.


-- 

dnovillo at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39010

[Bug lto/39010] [LTO] Memory corruption on gcc.c-torture/compile/limits-fndefn.c

[espindola at gcc dot gnu dot org]

------- Comment #7 from espindola at gcc dot gnu dot org  2009-02-17 14:26 -------
Subject: Bug 39010

Author: espindola
Date: Tue Feb 17 14:25:46 2009
New Revision: 144231

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=144231
Log:
2009-02-16  Rafael Avila de Espindola  <espindola@google.com>

        PR 39010
        * lto-function-in.c (input_string): Rename to input_string_cst.
        Read loc.
        (input_identifier): New.
        (input_string): New.
        (input_line_info): Use input_string.
        (input_expr_operand): Use input_string_cst, input_identifier.
        (input_labels): Use input_identifier.
        (input_local_var_decl): Use input_identifier.
        (input_gimple_stmt): Use input_string_cst.
        (input_tree_operand): Use input_string_cst, input_identifier.
        * lto-function-out.c (output_string): Rename to
        output_string_with_length. Add trailing '\0'.
        (output_string): New.
        (output_string_cst): New.
        (output_identifier): New.
        (output_real): Update call to output_string.
        (output_tree_flags): Update call to output_string.
        (output_expr_operand): Use output_string_cst, output_identifier.
        (output_local_var_decl): Use output_identifier.
        (output_named_labels): Use output_identifier.
        (output_gimple_stmt): Update call to output_string.
        (output_tree_with_context): Use output_string_cst, output_identifier.


Modified:
    branches/lto/gcc/ChangeLog.lto
    branches/lto/gcc/lto-function-in.c
    branches/lto/gcc/lto-function-out.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39010

[Bug lto/39010] [LTO] Memory corruption on gcc.c-torture/compile/limits-fndefn.c

[bje at gcc dot gnu dot org]

------- Comment #8 from bje at gcc dot gnu dot org  2009-07-08 06:07 -------
All limits-fndefn.c tests now pass (lto revision 149354).


-- 

bje at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39010