public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug ada/39221]  New: Wrong code in gcc/ada/a-teioed.adb causing FAIL of ACATS cxf3a01 on mipsel and ia64
@ 2009-02-17 20:58 laurent at guerby dot net
  2009-03-08  9:05 ` [Bug ada/39221] buffer overflow in a-teioed.adb ebotcazou at gcc dot gnu dot org
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: laurent at guerby dot net @ 2009-02-17 20:58 UTC (permalink / raw)
  To: gcc-bugs

ACATS cxf3a01 fails on mipsel-linux where it is the only ACATS test to fail:

,.,. CXF3A01 ACATS 2.5 09-02-17 22:07:04
---- CXF3A01 Check that the Valid function from package
                Ada.Text_IO.Editing returns False for strings that fail 
                to comply with the composition constraints defined for
                picture strings. Check that the Valid function returns
                True for strings that conform to the composition
                constraints defined for picture strings.
   * CXF3A01 Incorrect result from Function Valid using Invalid_String =
                99999999999999999999999999999999999999999999999999999999
                999999999.
**** CXF3A01 FAILED ****************************.

http://gcc.gnu.org/ml/gcc-testresults/2009-02/msg01635.html

After investigation it looks like the code of Expand is wrong when
Picture'Length > MAX_PICSIZE since in this case memory after Result will be
overwritten (on all platform, but with effect FAIL on mipsel and ia64-linux).

Two obvious solutions: use Unsupress locally since there's already a others
handler or add explicit length checks.


-- 
           Summary: Wrong code in gcc/ada/a-teioed.adb causing FAIL of ACATS
                    cxf3a01 on mipsel and ia64
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: laurent at guerby dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39221


^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Bug ada/39221] buffer overflow in a-teioed.adb
  2009-02-17 20:58 [Bug ada/39221] New: Wrong code in gcc/ada/a-teioed.adb causing FAIL of ACATS cxf3a01 on mipsel and ia64 laurent at guerby dot net
@ 2009-03-08  9:05 ` ebotcazou at gcc dot gnu dot org
  2009-03-08  9:41 ` guerby at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: ebotcazou at gcc dot gnu dot org @ 2009-03-08  9:05 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #1 from ebotcazou at gcc dot gnu dot org  2009-03-08 09:04 -------
http://gcc.gnu.org/ml/gcc-cvs/2009-02/msg00594.html


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
            Summary|Wrong code in gcc/ada/a-    |buffer overflow in a-
                   |teioed.adb causing FAIL of  |teioed.adb
                   |ACATS cxf3a01 on mipsel and |
                   |ia64                        |
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39221


^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Bug ada/39221] buffer overflow in a-teioed.adb
  2009-02-17 20:58 [Bug ada/39221] New: Wrong code in gcc/ada/a-teioed.adb causing FAIL of ACATS cxf3a01 on mipsel and ia64 laurent at guerby dot net
  2009-03-08  9:05 ` [Bug ada/39221] buffer overflow in a-teioed.adb ebotcazou at gcc dot gnu dot org
  2009-03-08  9:41 ` guerby at gcc dot gnu dot org
@ 2009-03-08  9:41 ` laurent at guerby dot net
  2009-03-08 10:04 ` ebotcazou at gcc dot gnu dot org
  3 siblings, 0 replies; 5+ messages in thread
From: laurent at guerby dot net @ 2009-03-08  9:41 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from laurent at guerby dot net  2009-03-08 09:41 -------
I add the missing PR reference to gcc/ada/ChangeLog

2009-02-25  Laurent GUERBY  <laurent@guerby.net>

        PR ada/39221
        * a-teioed.adb (Expand): Fix Result overflow.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39221


^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Bug ada/39221] buffer overflow in a-teioed.adb
  2009-02-17 20:58 [Bug ada/39221] New: Wrong code in gcc/ada/a-teioed.adb causing FAIL of ACATS cxf3a01 on mipsel and ia64 laurent at guerby dot net
  2009-03-08  9:05 ` [Bug ada/39221] buffer overflow in a-teioed.adb ebotcazou at gcc dot gnu dot org
@ 2009-03-08  9:41 ` guerby at gcc dot gnu dot org
  2009-03-08  9:41 ` laurent at guerby dot net
  2009-03-08 10:04 ` ebotcazou at gcc dot gnu dot org
  3 siblings, 0 replies; 5+ messages in thread
From: guerby at gcc dot gnu dot org @ 2009-03-08  9:41 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #2 from guerby at gcc dot gnu dot org  2009-03-08 09:41 -------
Subject: Bug 39221

Author: guerby
Date: Sun Mar  8 09:41:17 2009
New Revision: 144708

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=144708
Log:
(Add missing PR reference)

2009-02-25  Laurent GUERBY  <laurent@guerby.net>

        PR ada/39221
        * a-teioed.adb (Expand): Fix Result overflow.


Modified:
    trunk/gcc/ada/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39221


^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Bug ada/39221] buffer overflow in a-teioed.adb
  2009-02-17 20:58 [Bug ada/39221] New: Wrong code in gcc/ada/a-teioed.adb causing FAIL of ACATS cxf3a01 on mipsel and ia64 laurent at guerby dot net
                   ` (2 preceding siblings ...)
  2009-03-08  9:41 ` laurent at guerby dot net
@ 2009-03-08 10:04 ` ebotcazou at gcc dot gnu dot org
  3 siblings, 0 replies; 5+ messages in thread
From: ebotcazou at gcc dot gnu dot org @ 2009-03-08 10:04 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #4 from ebotcazou at gcc dot gnu dot org  2009-03-08 10:03 -------
*** Bug 25819 has been marked as a duplicate of this bug. ***


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39221


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-03-08 10:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-17 20:58 [Bug ada/39221] New: Wrong code in gcc/ada/a-teioed.adb causing FAIL of ACATS cxf3a01 on mipsel and ia64 laurent at guerby dot net
2009-03-08  9:05 ` [Bug ada/39221] buffer overflow in a-teioed.adb ebotcazou at gcc dot gnu dot org
2009-03-08  9:41 ` guerby at gcc dot gnu dot org
2009-03-08  9:41 ` laurent at guerby dot net
2009-03-08 10:04 ` ebotcazou at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).