[Bug rtl-optimization/39762] New: [4.4/4.5 Regression] IRA ICE with -msoft-float

[Bug rtl-optimization/39762] New: [4.4/4.5 Regression] IRA ICE with -msoft-float

[jakub at gcc dot gnu dot org]

/* { dg-do compile } */
/* { dg-options "-Os" } */
/* { dg-options "-Os -msoft-float" { target { { i?86-* x86_64-* } && ilp32 } }
} */

extern void bar (void);

void
foo (unsigned int x, unsigned int y, unsigned int z)
{
  unsigned int a, b, d, e;
  unsigned int f = (8 << 12) + 0.000122 * 4096;
  b = (x << 12) + 0.000122 * 4096;
  e = (100 << 12) + 0.000122 * 4096;
  b = (unsigned long long) (((b << 13) / e) + 1) / 2;
  a = (y / 8);
  e = (a << 12) + 0.000122 * 4096;
  d = (unsigned long long) (b * e + 2048) >> 12;
  d = (unsigned long long) (d * f + 2048) >> 12;
  if (z >= d)
    bar ();
}

ICEs on i?86-linux (and x86_64-linux -m32) with -Os -msoft-float since r142892,
with -fno-ira it worked until that option has been removed.


-- 
           Summary: [4.4/4.5 Regression] IRA ICE with -msoft-float
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jakub at gcc dot gnu dot org
GCC target triplet: i?86-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39762

[Bug rtl-optimization/39762] [4.4/4.5 Regression] IRA ICE with -msoft-float

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39762

[Bug rtl-optimization/39762] [4.4/4.5 Regression] IRA ICE with -msoft-float

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39762

[Bug rtl-optimization/39762] [4.4/4.5 Regression] IRA ICE with -msoft-float

[vmakarov at redhat dot com]

------- Comment #1 from vmakarov at redhat dot com  2009-04-15 21:49 -------
The compiler is broken in IRA on this test because ira_register_move_cost is
not initialized for DFmode, AREG, GENERAL_REGS.

It is supposed that all necessary elements of this array are initialized in
ira-costs.c by ira_init_register_move_cost but it was not done for this mode
and reg classes for some reasons.  I think that the elements should be checked
for initialization every time when we need their values.  It would be a tiny
performance penalty but it will guarantee that such situation will be not
occurred anymore.

I'll send a patch soon.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39762

[Bug rtl-optimization/39762] [4.4/4.5 Regression] IRA ICE with -msoft-float

[vmakarov at gcc dot gnu dot org]

------- Comment #2 from vmakarov at gcc dot gnu dot org  2009-04-16 15:16 -------
Subject: Bug 39762

Author: vmakarov
Date: Thu Apr 16 15:15:48 2009
New Revision: 146198

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=146198
Log:
2009-04-16  Vladimir Makarov  <vmakarov@redhat.com>

        PR rtl-optimization/39762
        * ira-int.h (ira_register_move_cost, ira_may_move_in_cost,
        ira_may_move_out_cost): Add comments about way of their usage.
        (ira_get_register_move_cost, ira_get_may_move_cost): New
        functions.

        * ira-conflicts.c (process_regs_for_copy): Use function
        ira_get_register_move_cost instead of global
        ira_register_move_cost.

        * ira-color.c (update_copy_costs, calculate_allocno_spill_cost,
        color_pass, move_spill_restore, update_curr_costs): Ditto.

        * ira-lives.c (process_single_reg_class_operands): Ditto.

        * ira-emit.c (emit_move_list): Ditto.

        * ira-costs.c (copy_cost): Don't call ira_init_register_move_cost.
        (record_reg_classes): Ditto.  Use functions
        ira_get_register_move_cost and ira_get_may_move_cost instead of
        global vars ira_register_move_cost, ira_may_move_out_cost and
        ira_may_move_in_cost.
        (record_address_regs): Don't call ira_init_register_move_cost.
        Use function ira_get_may_move_cost instead of global
        ira_may_move_in_cost.
        (process_bb_node_for_hard_reg_moves): Use function
        ira_get_register_move_cost instead of global
        ira_register_move_cost.
        (ira_costs): Don't call ira_init_register_move_cost.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ira-color.c
    trunk/gcc/ira-conflicts.c
    trunk/gcc/ira-costs.c
    trunk/gcc/ira-emit.c
    trunk/gcc/ira-int.h
    trunk/gcc/ira-lives.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39762

[Bug rtl-optimization/39762] [4.4 Regression] IRA ICE with -msoft-float

[jakub at gcc dot gnu dot org]

------- Comment #3 from jakub at gcc dot gnu dot org  2009-04-16 16:55 -------
Vlad, do you plan to commit to 4.4 branch as well?


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.4/4.5 Regression] IRA ICE|[4.4 Regression] IRA ICE
                   |with -msoft-float           |with -msoft-float


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39762

[Bug rtl-optimization/39762] [4.4 Regression] IRA ICE with -msoft-float

[vmakarov at redhat dot com]

------- Comment #4 from vmakarov at redhat dot com  2009-04-16 17:35 -------
Yes, I do.  Although I feel it is a safe patch, I'd like to check it on trunk
first for a week.

Jakub, please let me know if you can not wait that for a week.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39762

[Bug rtl-optimization/39762] [4.4 Regression] IRA ICE with -msoft-float

[jakub at gcc dot gnu dot org]

------- Comment #5 from jakub at gcc dot gnu dot org  2009-04-16 18:00 -------
Ok, I can wait.  In that case please commit it after 4.4.0 has been released.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39762

[Bug rtl-optimization/39762] [4.4 Regression] IRA ICE with -msoft-float

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.4.0                       |4.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39762

[Bug rtl-optimization/39762] [4.4 Regression] IRA ICE with -msoft-float

[vmakarov at gcc dot gnu dot org]

------- Comment #6 from vmakarov at gcc dot gnu dot org  2009-04-22 20:16 -------
Subject: Bug 39762

Author: vmakarov
Date: Wed Apr 22 20:16:13 2009
New Revision: 146612

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=146612
Log:
2009-04-22  Vladimir Makarov  <vmakarov@redhat.com>

        PR rtl-optimization/39762
        * ira-int.h (ira_register_move_cost, ira_may_move_in_cost,
        ira_may_move_out_cost): Add comments about way of their usage.
        (ira_get_register_move_cost, ira_get_may_move_cost): New functions.

        * ira-conflicts.c (process_regs_for_copy): Use function
        ira_get_register_move_cost instead of global
        ira_register_move_cost.

        * ira-color.c (update_copy_costs, calculate_allocno_spill_cost,
        color_pass, move_spill_restore, update_curr_costs): Ditto.

        * ira-lives.c (process_single_reg_class_operands): Ditto.

        * ira-emit.c (emit_move_list): Ditto.

        * ira-costs.c (copy_cost): Don't call ira_init_register_move_cost.
        (record_reg_classes): Ditto.  Use functions
        ira_get_register_move_cost and ira_get_may_move_cost instead of
        global vars ira_register_move_cost, ira_may_move_out_cost and
        ira_may_move_in_cost.
        (record_address_regs): Don't call ira_init_register_move_cost.
        Use function ira_get_may_move_cost instead of global
        ira_may_move_in_cost.
        (process_bb_node_for_hard_reg_moves): Use function
        ira_get_register_move_cost instead of global ira_register_move_cost.
        (ira_costs): Don't call ira_init_register_move_cost.


Modified:
    branches/gcc-4_4-branch/gcc/ChangeLog
    branches/gcc-4_4-branch/gcc/ira-color.c
    branches/gcc-4_4-branch/gcc/ira-conflicts.c
    branches/gcc-4_4-branch/gcc/ira-costs.c
    branches/gcc-4_4-branch/gcc/ira-emit.c
    branches/gcc-4_4-branch/gcc/ira-int.h
    branches/gcc-4_4-branch/gcc/ira-lives.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39762

[Bug rtl-optimization/39762] [4.4 Regression] IRA ICE with -msoft-float

[jakub at gcc dot gnu dot org]

------- Comment #7 from jakub at gcc dot gnu dot org  2009-04-27 06:55 -------
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39762