[Bug c/39812] New: [4.5 regression] gcc.target/i386/cleanup-1.c and 8 gnat.dg tests FAIL between r146303 and r146339

[Bug c/39812] New: [4.5 regression] gcc.target/i386/cleanup-1.c and 8 gnat.dg tests FAIL between r146303 and r146339

[laurent at guerby dot net]

Between:

146303 => http://gcc.gnu.org/ml/gcc-testresults/2009-04/msg01859.html
146339 => http://gcc.gnu.org/ml/gcc-testresults/2009-04/msg01961.html

The following tests started failing on the -m32 run:

FAIL: gcc.target/i386/cleanup-1.c execution test

FAIL: gnat.dg/aliased_prefix_accessibility.adb execution test
FAIL: gnat.dg/conv_bug.adb execution test
FAIL: gnat.dg/curr_task.adb execution test
FAIL: gnat.dg/iprot_test.adb execution test
FAIL: gnat.dg/missing_acc_check.adb execution test
FAIL: gnat.dg/not_null.adb execution test
FAIL: gnat.dg/test_enum_io.adb execution test
FAIL: gnat.dg/test_overflow_sum.adb execution test


-- 
           Summary: [4.5 regression] gcc.target/i386/cleanup-1.c and 8
                    gnat.dg tests FAIL between r146303 and r146339
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: laurent at guerby dot net
 GCC build triplet: i686-unknown-linux
  GCC host triplet: i686-unknown-linux
GCC target triplet: i686-unknown-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39812

[Bug c/39812] [4.5 regression] gcc.target/i386/cleanup-1.c and 8 gnat.dg tests FAIL between r146303 and r146339

[laurent at guerby dot net]

------- Comment #1 from laurent at guerby dot net  2009-04-19 12:37 -------
r146313 works and r146314 fails the 8 gnat.dg tests:

r146314 | rguenth | 2009-04-18 15:02:00 +0200 (Sat, 18 Apr 2009) | 11 lines

2009-04-18  Richard Guenther  <rguenther@suse.de>

        PR middle-end/39804
        * tree-ssa-ccp.c (fold_stmt_1): New function factored from ...
        (fold_stmt): ... this and ...
        (fold_stmt_inplace): ... this.
        (fold_stmt_1): Fold references in calls and asms.
        * tree-cfg.c (remove_useless_stmts_cond): Use fold_stmt.

        * gcc.target/i386/pr39804.c: New testcase.


-- 

laurent at guerby dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laurent at guerby dot net,
                   |                            |rguenth at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39812

[Bug c/39812] [4.5 regression] gcc.target/i386/cleanup-1.c and 8 gnat.dg tests FAIL between r146303 and r146339

[hjl dot tools at gmail dot com]

------- Comment #2 from hjl dot tools at gmail dot com  2009-04-19 15:37 -------
*** Bug 39816 has been marked as a duplicate of this bug. ***


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl dot tools at gmail dot
                   |                            |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39812

[Bug middle-end/39812] [4.5 regression] Revision 146322 failed gcc.target/i386/cleanup-1.c and 8 gnat.dg tests FAIL between r146303 and r146339

[hjl dot tools at gmail dot com]

------- Comment #3 from hjl dot tools at gmail dot com  2009-04-19 15:40 -------
This is caused by revision 146322:

http://gcc.gnu.org/ml/gcc-cvs/2009-04/msg00959.html

I also saw

FAIL: gcc.target/i386/cleanup-2.c execution test

on Linux/Intel64.


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jh at suse dot cz
             Status|UNCONFIRMED                 |NEW
          Component|c                           |middle-end
     Ever Confirmed|0                           |1
  GCC build triplet|i686-unknown-linux          |
   GCC host triplet|i686-unknown-linux          |
 GCC target triplet|i686-unknown-linux          |x86
   Last reconfirmed|0000-00-00 00:00:00         |2009-04-19 15:40:42
               date|                            |
            Summary|[4.5 regression]            |[4.5 regression] Revision
                   |gcc.target/i386/cleanup-1.c |146322 failed
                   |and 8 gnat.dg tests FAIL    |gcc.target/i386/cleanup-1.c
                   |between r146303 and r146339 |and 8 gnat.dg tests FAIL
                   |                            |between r146303 and r146339


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39812

[Bug middle-end/39812] [4.5 regression] Revision 146314 failed 8 gnat.dg tests

[hjl dot tools at gmail dot com]

------- Comment #4 from hjl dot tools at gmail dot com  2009-04-19 15:43 -------
Apparently, there are 2 bugs. I will reopen 39816 for
gcc.target/i386/cleanup-1.c.


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  GCC build triplet|                            |i686-pc-linux-gnu
   GCC host triplet|                            |i686-pc-linux-gnu
 GCC target triplet|x86                         |i686-pc-linux-gnu
            Summary|[4.5 regression] Revision   |[4.5 regression] Revision
                   |146322 failed               |146314 failed 8 gnat.dg
                   |gcc.target/i386/cleanup-1.c |tests
                   |and 8 gnat.dg tests FAIL    |
                   |between r146303 and r146339 |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39812

[Bug middle-end/39812] [4.5 regression] Revision 146314 failed 8 gnat.dg tests

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2009-04-19 19:49 -------
Any hint on what happens?  My Ada skills are rather weak.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39812

[Bug middle-end/39812] [4.5 regression] Revision 146314 failed 8 gnat.dg tests

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39812

[Bug middle-end/39812] [4.5 regression] Revision 146314 failed 8 gnat.dg tests

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2009-04-19 20:37 -------
Works for me on i686-linux.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39812

[Bug middle-end/39812] [4.5 regression] Revision 146314 failed 8 gnat.dg tests

[laurent at guerby dot net]

------- Comment #7 from laurent at guerby dot net  2009-04-19 20:49 -------
For me with -m32:

146313: OK
146314: FAIL
146322: OK

I'm rebuilding 146313 and 146314 and try to diff what changes


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39812

[Bug middle-end/39812] [4.5 regression] Revision 146314 failed 8 gnat.dg tests

[laurent at guerby dot net]

------- Comment #8 from laurent at guerby dot net  2009-04-20 00:07 -------
I made a procedural mistake above, the right FAIL point is:

146321: OK
146322: FAIL

diff:

+2009-04-18  Jan Hubicka  <jh@suse.cz>
+
+       * cgraph.c (cgraph_make_edge, dump_cgraph_node, cgraph_set_call_stmt):
+       Set nothrow flag.
+       * cgraph.h (struct function): Reduce loop_nest to 30 bits; add
+       can_throw_external flag.
+       * ipa-reference.c (ipa_utils_reduced_inorder): Update call.
+       * ipa-pure-const.c (ignore_edge): New function.
+       (propagate): Compute order for NOTHROW computation; set NOTHROWs
+       only over can_throw_external edges.
+       (local_pure_const): Add nothrow flag.
+       * ipa-utils.c (searchc): Add ignore_edge callback.
+       (ipa_utils_reduced_inorder): Add ignore_edge callback.
+       * ipa-utils.h (ipa_utils_reduced_inorder): Update prototype.
+       (set_nothrow_function_flags): Update cgraph.
+       * tree-cfg.c (verify_stmt): Relax nothrow checking when in IPA mode.
+

To reproduce on a simple test case:

BUILD=/some/where
SRC=/some/whereelse

$BUILD/gcc/gnatmake -f -g -m32 --GCC=$BUILD/gcc/xgcc
--GNATLINK=$BUILD/gcc/gnatlink --GNATBIND=$BUILD/gcc/gnatbind
--RTS=$BUILD/x86_64-unknown-linux-gnu/32/libada/
$SRC/gcc/testsuite/gnat.dg/not_null.adb -cargs -B$BUILD/gcc  -largs
-B$BUILD/gcc
./not_null

This will raise an exception which means the main program exception handler
does not receive the exception.

This was likely fixed by:

2009-04-19  Jan Hubicka  <jh@suse.cz>

        * cgraph.c (cgraph_create_edge, cgraph_set_call_stmt): Set proper cfun.
        (dump_cgraph_node): Dump can throw external flag.
        * ipa-pure-const.c (propagate): Fix propagation of nothrow flags.

I will confirm later on.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39812

[Bug middle-end/39812] [4.5 regression] Revision 146314 failed 8 gnat.dg tests

[laurent at guerby dot net]

------- Comment #9 from laurent at guerby dot net  2009-04-20 08:33 -------
Confirmed, Jan Hubicka second patch fixed the issue:

146344: FAIL
146349: OK

My apologies to Richard :)


-- 

laurent at guerby dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39812