[Bug tree-optimization/39960] New: [4.5 Regression] struct-reorg is broken

[Bug tree-optimization/39960] New: [4.5 Regression] struct-reorg is broken

[rguenth at gcc dot gnu dot org]

FAIL: gcc.dg/struct/wo_prof_double_malloc.c (internal compiler error)
FAIL: gcc.dg/struct/wo_prof_double_malloc.c (internal compiler error)
FAIL: gcc.dg/struct/wo_prof_double_malloc.c (test for excess errors)
FAIL: gcc.dg/struct/wo_prof_double_malloc.c (test for excess errors)

/space/rguenther/src/svn/trunk/gcc/testsuite/gcc.dg/struct/wo_prof_double_malloc.c:26:
error: non-trivial conversion at assignment^M
struct type_struct *^M
struct test_struct_sub.1 *^M
# .MEM_41 = VDEF <.MEM_18>^M
*D.3347_31 = D.3349_40;^M
^M

struct-reorg doesn't bother to update reference trees properly and creates
invalid gimple.


-- 
           Summary: [4.5 Regression] struct-reorg is broken
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rguenth at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39960

[Bug tree-optimization/39960] [4.5 Regression] struct-reorg is broken

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39960

[Bug tree-optimization/39960] [4.5 Regression] struct-reorg is broken

[hp at gcc dot gnu dot org]

------- Comment #1 from hp at gcc dot gnu dot org  2009-04-30 01:25 -------
Confirmed at r146982 for cris-elf.


-- 

hp at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-04-30 01:25:49
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39960

[Bug tree-optimization/39960] [4.5 Regression] struct-reorg is broken

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39960

[Bug tree-optimization/39960] [4.5 Regression] struct-reorg is broken

[janis at gcc dot gnu dot org]

------- Comment #2 from janis at gcc dot gnu dot org  2009-07-08 20:46 -------
On powerpc*-linux the test begins to fail in the same way with this patch:

    http://gcc.gnu.org/viewcvs?view=rev&rev=146831

    r146831 | rguenth | 2009-04-27 11:18:38 +0000 (Mon, 27 Apr 2009)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39960

[Bug tree-optimization/39960] [4.5 Regression] struct-reorg is broken

[janis at gcc dot gnu dot org]

------- Comment #3 from janis at gcc dot gnu dot org  2009-07-08 21:29 -------
The test started failing with the patch reported in comment #2 because it
enabled type checking; sorry for the noise.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39960

[Bug tree-optimization/39960] [4.5 Regression] struct-reorg is broken

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2009-09-23 16:22 -------
Likewise.  Not really P1 as user-visible only with checking enabled.  Not a
regression is the wrong-code part as IPA struct-reorg was creating TBAA
wrong-code since ever, now made visible via type-checking.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmitchel at gcc dot gnu dot
                   |                            |org
           Keywords|                            |ice-checking, ice-on-valid-
                   |                            |code
           Priority|P1                          |P3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39960

[Bug tree-optimization/39960] [4.5 Regression] struct-reorg is broken

[olga at il dot ibm dot com]

------- Comment #5 from olga at il dot ibm dot com  2009-11-17 13:47 -------
This patch should solve the problem. Please confirm for your platforms.

http://gcc.gnu.org/ml/gcc-patches/2009-11/msg00849.html

Thanks,
Olga


-- 

olga at il dot ibm dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olga at il dot ibm dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39960

[Bug tree-optimization/39960] [4.5 Regression] struct-reorg is broken

[olga at gcc dot gnu dot org]

------- Comment #6 from olga at gcc dot gnu dot org  2009-11-20 16:57 -------
Subject: Bug 39960

Author: olga
Date: Fri Nov 20 16:57:35 2009
New Revision: 154374

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=154374
Log:
2009-11-17 Olga Golovanevsky <olga@il.ibm.com>

        PR middle-end/39960
        * ipa-struct-reorg.c (find_pos_in_stmt): New parameter.
        (ref_pos): New field in structure.
        (insert_new_var_in_stmt): New function.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-struct-reorg.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39960

[Bug tree-optimization/39960] [4.5 Regression] struct-reorg is broken

[hjl dot tools at gmail dot com]

------- Comment #7 from hjl dot tools at gmail dot com  2009-11-21 22:08 -------
Fixed.


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39960