[Bug middle-end/40015] New: [4.5.0 Regression] Revision 147083 failed gfortran.dg/array_memcpy_4.f90

[Bug middle-end/40015] New: [4.5.0 Regression] Revision 147083 failed gfortran.dg/array_memcpy_4.f90

[hjl dot tools at gmail dot com]

Revision 147083:

http://gcc.gnu.org/ml/gcc-cvs/2009-05/msg00057.html

triggered:

FAIL: gfortran.dg/array_memcpy_4.f90  -O  scan-tree-dump-times original "d = "
1


-- 
           Summary: [4.5.0 Regression]  Revision 147083 failed
                    gfortran.dg/array_memcpy_4.f90
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl dot tools at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40015

[Bug middle-end/40015] [4.5.0 Regression] Revision 147083 failed gfortran.dg/array_memcpy_4.f90

[hp at gcc dot gnu dot org]

------- Comment #1 from hp at gcc dot gnu dot org  2009-05-04 05:54 -------
Seen for cris-elf too...


-- 

hp at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hp at gcc dot gnu dot org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-05-04 05:54:58
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40015

[Bug middle-end/40015] [4.5.0 Regression] Revision 147083 failed gfortran.dg/array_memcpy_4.f90

[dominiq at lps dot ens dot fr]

------- Comment #2 from dominiq at lps dot ens dot fr  2009-05-04 06:30 -------
Confirmed on i686-apple-darwin9, array_memcpy_4.f90.003t.original is

MAIN__ ()
{
  struct t d[5];
  struct t s[5];
  static integer(kind=4) options.0[8] = {68, 255, 0, 0, 0, 1, 0, 1};

  _gfortran_set_options (8, (void *) &options.0);
  (void) __builtin_memcpy ((void *) &d, (void *) &s, 60);
}

and does not depend on the optimization level.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40015

[Bug middle-end/40015] [4.5.0 Regression] Revision 147083 failed gfortran.dg/array_memcpy_4.f90

[dominiq at lps dot ens dot fr]

------- Comment #3 from dominiq at lps dot ens dot fr  2009-05-04 06:32 -------
At revision 147065 I get:

MAIN__ ()
{
  struct t d[5];
  struct t s[5];
  static integer(kind=4) options.0[8] = {68, 255, 0, 0, 0, 1, 0, 1};

  _gfortran_set_options (8, (void *) &options.0);
  d = VIEW_CONVERT_EXPR<struct t[5]>(s);
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40015

[Bug middle-end/40015] [4.5.0 Regression] Revision 147083 failed gfortran.dg/array_memcpy_4.f90

[dominiq at lps dot ens dot fr]

------- Comment #4 from dominiq at lps dot ens dot fr  2009-05-04 08:59 -------
This test has been introduced by the patch in
http://gcc.gnu.org/ml/fortran/2007-01/msg00425.html.
The tests gfortran.dg/array_memcpy_[1-3].f90 use

! { dg-final { scan-tree-dump-times "memcpy" * "original" } }

So a simple fix would be to replace

! { dg-final { scan-tree-dump-times "d = " 1 "original" } }

with

! { dg-final { scan-tree-dump-times "memcpy" 1 "original" } }

but I don't understand why array_memcpy_4.f90 used to give a different
construct and this change could mask a more serious problem.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40015

[Bug middle-end/40015] [4.5.0 Regression] Revision 147083 failed gfortran.dg/array_memcpy_4.f90

[rguenther at suse dot de]

------- Comment #5 from rguenther at suse dot de  2009-05-04 09:01 -------
Subject: Re:  [4.5.0 Regression]  Revision 147083 failed
 gfortran.dg/array_memcpy_4.f90

On Mon, 4 May 2009, dominiq at lps dot ens dot fr wrote:

> ------- Comment #4 from dominiq at lps dot ens dot fr  2009-05-04 08:59 -------
> This test has been introduced by the patch in
> http://gcc.gnu.org/ml/fortran/2007-01/msg00425.html.
> The tests gfortran.dg/array_memcpy_[1-3].f90 use
> 
> ! { dg-final { scan-tree-dump-times "memcpy" * "original" } }
> 
> So a simple fix would be to replace
> 
> ! { dg-final { scan-tree-dump-times "d = " 1 "original" } }
> 
> with
> 
> ! { dg-final { scan-tree-dump-times "memcpy" 1 "original" } }
> 
> but I don't understand why array_memcpy_4.f90 used to give a different
> construct and this change could mask a more serious problem.

I will investigate - we really should get the memcpy removed.

Richard.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40015

[Bug middle-end/40015] [4.5.0 Regression] Revision 147083 failed gfortran.dg/array_memcpy_4.f90

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2009-05-04 09:25 -------
I have a patch.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2009-05-04 05:54:58         |2009-05-04 09:25:57
               date|                            |
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40015

[Bug middle-end/40015] [4.5.0 Regression] Revision 147083 failed gfortran.dg/array_memcpy_4.f90

[rguenth at gcc dot gnu dot org]

------- Comment #7 from rguenth at gcc dot gnu dot org  2009-05-04 11:02 -------
Subject: Bug 40015

Author: rguenth
Date: Mon May  4 11:01:59 2009
New Revision: 147094

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=147094
Log:
2009-05-04  Richard Guenther  <rguenther@suse.de>

        PR middle-end/40015
        * builtins.c (fold_builtin_memory_op): Do not decay to element
        type if the size matches the whole array.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/builtins.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40015

[Bug middle-end/40015] [4.5.0 Regression] Revision 147083 failed gfortran.dg/array_memcpy_4.f90

[rguenth at gcc dot gnu dot org]

------- Comment #8 from rguenth at gcc dot gnu dot org  2009-05-04 12:43 -------
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40015