[Bug other/40159] New: [4.5 regression] "make all" ignores build failures

[Bug other/40159] New: [4.5 regression] "make all" ignores build failures

[schwab at linux-m68k dot org]

Since r147415 all failures from recursive make calls are ignored and "make all"
always exits successfully.


-- 
           Summary: [4.5 regression] "make all" ignores build failures
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: schwab at linux-m68k dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40159

[Bug other/40159] [4.5 regression] "make all" ignores build failures

[jsm28 at gcc dot gnu dot org]

-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40159

[Bug other/40159] [4.5 regression] "make all" ignores build failures

[aoliva at gcc dot gnu dot org]

------- Comment #1 from aoliva at gcc dot gnu dot org  2009-05-18 06:54 -------
I (and the automated regression testers) can't seem to duplicate this.  May I
have a bit more detail as to the circumstances in which the problem occurs,
please?


-- 

aoliva at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40159

[Bug other/40159] [4.5 regression] "make all" ignores build failures

[schwab at linux-m68k dot org]

------- Comment #2 from schwab at linux-m68k dot org  2009-05-18 09:37 -------
The last command in the "all" rule is : which is always successfull:

# The target built for a native non-bootstrap build.
.PHONY: all
all:
@if gcc-bootstrap
        [ -f stage_final ] || echo stage3 > stage_final
        @r=`${PWD_COMMAND}`; export r; \
        s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
        $(MAKE) $(RECURSE_FLAGS_TO_PASS) `cat stage_final`-bubble
@endif gcc-bootstrap
        @: $(MAKE); $(unstage)
        @r=`${PWD_COMMAND}`; export r; \
        s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
@if gcc-bootstrap
        if [ -f stage_last ]; then : ; \
          TFLAGS="$(STAGE$(shell sed s,^stage,, stage_last)_TFLAGS)"; \
          $(MAKE) $(TARGET_FLAGS_TO_PASS) all-host all-target; \
        else \
@endif gcc-bootstrap
          $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target; \
@if gcc-bootstrap
        fi; \
@endif gcc-bootstrap
        :


-- 

schwab at linux-m68k dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |schwab at linux-m68k dot org
                   |dot org                     |
             Status|WAITING                     |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-05-18 09:37:41
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40159

[Bug other/40159] [4.5 regression] "make all" ignores build failures

[aoliva at gcc dot gnu dot org]

------- Comment #3 from aoliva at gcc dot gnu dot org  2009-05-18 15:34 -------
Uhh...  This shouldn't matter when commands are run in a shell with set -e, 
like make does, no?

Anyhow, thanks for the analysis.  I suppose replacing the final : for exit $$?
should fix this, right?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40159

[Bug other/40159] [4.5 regression] "make all" ignores build failures

[schwab at linux-m68k dot org]

------- Comment #4 from schwab at linux-m68k dot org  2009-05-18 15:48 -------
GNU make does not use sh -e.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40159

[Bug other/40159] [4.5 regression] "make all" ignores build failures

[aoliva at gcc dot gnu dot org]

------- Comment #5 from aoliva at gcc dot gnu dot org  2009-05-19 00:01 -------
Subject: Bug 40159

Author: aoliva
Date: Tue May 19 00:01:17 2009
New Revision: 147683

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=147683
Log:
PR other/40159
* Makefile.tpl (all): Don't end with unconditional success.
* Makefile.in: Rebuilt.

Modified:
    trunk/ChangeLog
    trunk/Makefile.in
    trunk/Makefile.tpl


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40159

[Bug other/40159] [4.5 regression] "make all" ignores build failures

[aoliva at gcc dot gnu dot org]

------- Comment #6 from aoliva at gcc dot gnu dot org  2009-05-19 00:04 -------
Subject: Bug 40159

Author: aoliva
Date: Tue May 19 00:04:17 2009
New Revision: 147684

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=147684
Log:
PR other/40159
* Makefile.tpl (all): Don't end with unconditional success.
* Makefile.in: Rebuilt.

Modified:
    branches/var-tracking-assignments-branch/ChangeLog
    branches/var-tracking-assignments-branch/Makefile.in
    branches/var-tracking-assignments-branch/Makefile.tpl


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40159

[Bug other/40159] [4.5 regression] "make all" ignores build failures

[aoliva at gcc dot gnu dot org]

------- Comment #7 from aoliva at gcc dot gnu dot org  2009-05-19 00:05 -------
Subject: Bug 40159

Author: aoliva
Date: Tue May 19 00:04:57 2009
New Revision: 147685

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=147685
Log:
PR other/40159
* Makefile.tpl (all): Don't end with unconditional success.
* Makefile.in: Rebuilt.

Modified:
    branches/var-tracking-assignments-4_4-branch/ChangeLog
    branches/var-tracking-assignments-4_4-branch/Makefile.in
    branches/var-tracking-assignments-4_4-branch/Makefile.tpl


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40159

[Bug other/40159] [4.5 regression] "make all" ignores build failures

[aoliva at gcc dot gnu dot org]

------- Comment #8 from aoliva at gcc dot gnu dot org  2009-05-19 00:07 -------
Fixed.


-- 

aoliva at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40159

[Bug other/40159] [4.5 regression] "make all" ignores build failures

[aoliva at gcc dot gnu dot org]

------- Comment #9 from aoliva at gcc dot gnu dot org  2009-05-19 01:30 -------
Subject: Bug 40159

Author: aoliva
Date: Tue May 19 01:30:35 2009
New Revision: 147695

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=147695
Log:
PR other/40159
* Makefile.tpl (all): Don't assume gcc-bootstrap and
gcc-no-bootstrap are mutually exclusive.
* Makefile.in: Rebuilt.

Modified:
    trunk/ChangeLog
    trunk/Makefile.in
    trunk/Makefile.tpl


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40159

[Bug other/40159] [4.5 regression] "make all" ignores build failures

[aoliva at gcc dot gnu dot org]

------- Comment #10 from aoliva at gcc dot gnu dot org  2009-05-19 01:31 -------
Subject: Bug 40159

Author: aoliva
Date: Tue May 19 01:31:12 2009
New Revision: 147696

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=147696
Log:
PR other/40159
* Makefile.tpl (all): Don't assume gcc-bootstrap and
gcc-no-bootstrap are mutually exclusive.
* Makefile.in: Rebuilt.

Modified:
    branches/var-tracking-assignments-branch/ChangeLog
    branches/var-tracking-assignments-branch/Makefile.in
    branches/var-tracking-assignments-branch/Makefile.tpl


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40159

[Bug other/40159] [4.5 regression] "make all" ignores build failures

[aoliva at gcc dot gnu dot org]

------- Comment #11 from aoliva at gcc dot gnu dot org  2009-05-19 01:32 -------
Subject: Bug 40159

Author: aoliva
Date: Tue May 19 01:32:09 2009
New Revision: 147697

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=147697
Log:
PR other/40159
* Makefile.tpl (all): Don't assume gcc-bootstrap and
gcc-no-bootstrap are mutually exclusive.
* Makefile.in: Rebuilt.

Modified:
    branches/var-tracking-assignments-4_4-branch/ChangeLog
    branches/var-tracking-assignments-4_4-branch/Makefile.in
    branches/var-tracking-assignments-4_4-branch/Makefile.tpl


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40159