[Bug libffi/40444] New: [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.

[Bug libffi/40444] New: [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.

[dominiq at lps dot ens dot fr]

See comment #4 of pr40385:

                === libffi Summary for unix ===

# of expected passes            1594
# of expected failures          10
# of unsupported tests          15

Running target unix/-m64
FAIL: libffi.call/closure_fn0.c -O0 -W -Wall execution test
...
FAIL: libffi.special/unwindtest.cc  -shared-libgcc -lstdc++ execution test

                === libffi Summary for unix/-m64 ===

# of expected passes            776
# of unexpected failures        409
# of expected failures          10
# of unsupported tests          15

                === libffi Summary ===

# of expected passes            2370
# of unexpected failures        409
# of expected failures          20
# of unsupported tests          30

I have had a look at some crash reports. They look as:

[ibook-dhum] gcc/_gcc_clean% cat
~/Library/Logs/CrashReporter/closure_fn0.exe_2009-06-15-074300_ibook-dhum.crash
Process:         closure_fn0.exe [67697]
Path:            ./closure_fn0.exe
Identifier:      closure_fn0.exe
Version:         ??? (???)
Code Type:       X86-64 (Native)
Parent Process:  expect [60005]

Date/Time:       2009-06-15 07:43:00.456 +0200
OS Version:      Mac OS X 10.5.7 (9J61)
Report Version:  6
Anonymous UUID:  E80146C8-66E0-457D-87E0-4A904418933C

Exception Type:  EXC_BAD_ACCESS (SIGBUS)
Exception Codes: KERN_PROTECTION_FAILURE at 0x0000000100100210
Crashed Thread:  0

Thread 0 Crashed:
0   ???                                 0x0000000100100210 0 + 4296016400
1   closure_fn0.exe                     0x00000001000009f4 start + 52

Thread 0 crashed with X86 Thread State (64-bit):
  rax: 0x0000000100100210  rbx: 0x00007fff5fbf8c60  rcx: 0x0000000000000004 
rdx: 0x0000000000000003
  rdi: 0x0000000000000001  rsi: 0x0000000000000002  rbp: 0x00007fff5fbf8ca0 
rsp: 0x00007fff5fbf8b88
   r8: 0x000000000000007f   r9: 0x00000000000001ad  r10: 0x0000000100002150 
r11: 0x0000000100004f20
  r12: 0x0000000000000000  r13: 0x0000000000000000  r14: 0x0000000000000000 
r15: 0x0000000000000000
  rip: 0x0000000100100210  rfl: 0x0000000000010246  cr2: 0x0000000100100210

Binary Images:
       0x100000000 -        0x100000fff +closure_fn0.exe ??? (???)
<6d8a3f27722de7f10c1822591331d4f3>
/Volumes/MacBook/opt/gcc/i686-darwin/i686-apple-darwin9/libffi/testsuite/closure_fn0.exe
       0x100003000 -        0x100005ff7 +libffi.4.dylib ??? (???)
<ca0f9c56e408e1f77be7289ad188fc7e>
/opt/gcc/i686-darwin/i686-apple-darwin9/x86_64/libffi/.libs/libffi.4.dylib
       0x10000a000 -        0x10001eff1 +libgcc_s.1.dylib ??? (???)
<28ae595aba1589142c1755e5b0ac38dc> /opt/gcc/i686-darwin/gcc/libgcc_s.1.dylib
    0x7fff5fc00000 -     0x7fff5fc2e643  dyld 97.1 (???)
<b40847f1ce1ba2ed13837aeccbf19284> /usr/lib/dyld
    0x7fff82d7e000 -     0x7fff82f09ffb  libSystem.B.dylib ??? (???)
<558e10ab4bc6790fd3ee1abd14458085> /usr/lib/libSystem.B.dylib
    0x7fff83fe2000 -     0x7fff83fe6fff  libmathCommon.A.dylib ??? (???)
/usr/lib/system/libmathCommon.A.dylib
    0x7fffffe00000 -     0x7fffffe01780  libSystem.B.dylib ??? (???)
/usr/lib/libSystem.B.dylib


-- 
           Summary: [4.5 Regression] libffi badly broken with -m64 by some
                    revision between 148383 and 148472.
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libffi
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dominiq at lps dot ens dot fr
 GCC build triplet: i686-apple-darwin9
  GCC host triplet: i686-apple-darwin9
GCC target triplet: i686-apple-darwin9


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444

[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.

[aph at gcc dot gnu dot org]

------- Comment #1 from aph at gcc dot gnu dot org  2009-06-15 15:47 -------
Adding Andreas Tobler; perhaps he knows.


-- 

aph at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreast at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444

[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.

[andreast at gcc dot gnu dot org]

-- 

andreast at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |andreast at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-06-16 07:33:36
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444

[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.

[andreast at gcc dot gnu dot org]

------- Comment #2 from andreast at gcc dot gnu dot org  2009-06-16 07:38 -------
Index: testsuite/lib/libffi-dg.exp
===================================================================
--- testsuite/lib/libffi-dg.exp (revision 148518)
+++ testsuite/lib/libffi-dg.exp (working copy)
@@ -187,6 +187,13 @@
     lappend options "additional_flags=-I${libffi_include}
-I${srcdir}/../include  -I${libffi_include}/.."
     lappend options "additional_flags=${libffi_link_flags}"

+    # Darwin needs a stack execution allowed flag.
+
+    if { [istarget "*-*-darwin9*"] || [istarget "*-*-darwin1*"]
+        || [istarget "*-*-darwin2*"] } {
+       lappend options "additional_flags=-Wl,-allow_stack_execute"
+    }
+
     # If you're building the compiler with --prefix set to a place
     # where it's not yet installed, then the linker won't be able to
     # find the libgcc used by libffi.dylib.  We could pass the


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444

[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.

[dominiq at lps dot ens dot fr]

------- Comment #3 from dominiq at lps dot ens dot fr  2009-06-16 09:46 -------
With the patch in comment #2 I get:

                === libffi tests ===

Schedule of variations:
    unix
    unix/-m64

Running target unix
Using /sw/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /sw/share/dejagnu/config/unix.exp as generic interface file for target.
Using /opt/gcc/gcc-4.5-work/libffi/testsuite/config/default.exp as
tool-and-target-specific interface file.
Running /opt/gcc/gcc-4.5-work/libffi/testsuite/libffi.call/call.exp ...
Running /opt/gcc/gcc-4.5-work/libffi/testsuite/libffi.special/special.exp ...

                === libffi Summary for unix ===

# of expected passes            1594
# of expected failures          10
# of unsupported tests          15
Running target unix/-m64
Using /sw/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /sw/share/dejagnu/config/unix.exp as generic interface file for target.
Using /opt/gcc/gcc-4.5-work/libffi/testsuite/config/default.exp as
tool-and-target-specific interface file.
Running /opt/gcc/gcc-4.5-work/libffi/testsuite/libffi.call/call.exp ...
FAIL: libffi.call/cls_dbls_struct.c -O0 -W -Wall output pattern test, is 1.0
0.0
1.0 2.0
? should match 1.0 2.0
?.0 2.0

FAIL: libffi.call/cls_dbls_struct.c -O2 output pattern test, is 1.0 0.0
1.0 2.0
? should match 1.0 2.0
?.0 2.0

FAIL: libffi.call/cls_dbls_struct.c -O3 output pattern test, is 1.0 0.0
1.0 2.0
? should match 1.0 2.0
?.0 2.0

FAIL: libffi.call/cls_dbls_struct.c -Os output pattern test, is 1.0 0.0
1.0 2.0
? should match 1.0 2.0
?.0 2.0

FAIL: libffi.call/cls_dbls_struct.c -O2 -fomit-frame-pointer output pattern
test, is 1.0 0.0
1.0 2.0
? should match 1.0 2.0
?.0 2.0

Running /opt/gcc/gcc-4.5-work/libffi/testsuite/libffi.special/special.exp ...

                === libffi Summary for unix/-m64 ===

# of expected passes            1589
# of unexpected failures        5
# of expected failures          10
# of unsupported tests          15

                === libffi Summary ===

# of expected passes            3183
# of unexpected failures        5
# of expected failures          20
# of unsupported tests          30

Thanks for the patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444

[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.

[dominiq at lps dot ens dot fr]

------- Comment #4 from dominiq at lps dot ens dot fr  2009-06-16 09:50 -------
libffi/testsuite/libffi.call/cls_dbls_struct.c is "XFAILed" for
x86_64-*-linux-*. It should probably xfailed also for x86_64*darwin* and
i686-apple-darwin* with -m64.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444

[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.

[aph at gcc dot gnu dot org]

------- Comment #5 from aph at gcc dot gnu dot org  2009-06-16 10:12 -------
Thanks for the patch, Andreas.  Please push upstream(s).


-- 

aph at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2009-06-16 07:33:36         |2009-06-16 10:12:07
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444

[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.

[andreast at gcc dot gnu dot org]

------- Comment #6 from andreast at gcc dot gnu dot org  2009-06-16 17:28 -------
Subject: Bug 40444

Author: andreast
Date: Tue Jun 16 17:28:29 2009
New Revision: 148542

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=148542
Log:
2009-06-16  Andreas Tobler  <a.tobler@schweiz.org>

        PR libffi/40444
        * testsuite/lib/libffi-dg.exp (libffi_target_compile): Add
        allow_stack_execute for Darwin.

Modified:
    trunk/libffi/ChangeLog
    trunk/libffi/testsuite/lib/libffi-dg.exp


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444

[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.

[andreast at gcc dot gnu dot org]

------- Comment #7 from andreast at gcc dot gnu dot org  2009-06-16 17:30 -------
Fixed.


-- 

andreast at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444